[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2872 LGTM please change the title to incluce jira ticket number ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9726/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1678/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1468/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1673/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9721/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1463/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9718/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1460/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2872 @manishgupta88 this is basic implementation of pool(kind of pool :)) and currently it only for direct flow(new flow), In future I am planing to replace reusable buffer with proper byte array pooling which can be used for both old and new flow. I will raise a JIRA for the same ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2872 @kumarvishal09 ...In general, instead of passing the `ReusableDataBuffer` instance everwhere can we make this class singleton and create a `byte[]` pool and use the concept of object pool. This will help in following ways: 1. It will avoid modification of too many method/code modifications as wherever required we can take the object from pool and make the code simpler. 2. Currentlt it is being used for filling hthe decompressed data to avoid array copy. In future it will be easier to make use of the reusable buffer object pool wherever required without making too many changes in the code. We can discuss more on this and decide. ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9674/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1626/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1417/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1608/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9656/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1398/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9650/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1602/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1392/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2872 retest this please ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1599/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9647/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1389/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1388/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9645/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1597/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1387/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9528/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1479/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1264/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1251/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1466/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9515/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9472/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1423/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1208/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1422/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1207/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9392/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1338/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1128/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9379/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1327/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1116/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1113/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9375/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1110/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1321/ ---
[GitHub] carbondata issue #2872: [WIP] Added reusable buffer code
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2872 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9371/ ---
