[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-18 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
LGTM


---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
LGTM


---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10074/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2025/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1815/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1814/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
@Shubh18s : I have checked the code, 
all the column names are stored without trim in SDK. But 
long_string_columns table properties is having trim. column name has string 
without trim  but properties have string with trim. Hence the schema mismatch.

After this change, sort_columns and invertedIndexFor are affected. 
As CarbonWriterBuilder.sortBy() is exposed to user, here also trim is not 
there as per previous code. so add trim() here also. similar changes in 
CarbonWriterBuilder.invertedIndexFor()




---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10062/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2013/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1801/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
@Shubh18s : why for only varchar columns ? how it was handled other columns 
? I guess this problem is there for other columns also


---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2005/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10053/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1793/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-17 Thread Shubh18s
Github user Shubh18s commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
retest this please


---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1998/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10046/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1786/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.3.2, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/10020/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1972/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1761/



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread brijoobopanna
Github user brijoobopanna commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
add to whitelist



---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread brijoobopanna
Github user brijoobopanna commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
retest this please


---


[GitHub] carbondata issue #2988: [CARBONDATA-3174] Fix trailing space issue with varc...

2018-12-14 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2988
  
Can one of the admins verify this patch?


---