Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/1102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r128276064
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -32,23 +39,37 @@
/**
* maxValue
*/
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r127624668
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -32,23 +39,37 @@
/**
* maxValue
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126616762
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -29,26 +32,50 @@
*/
public class ValueEncoderMe
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126616780
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations und
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126428058
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodedMeasurePage.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed t
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126427558
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new ColumnPage
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126428076
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new ColumnPage
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126427005
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -64,15 +63,6 @@ public ColumnPageStatsV
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126426968
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations und
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126061470
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodedMeasurePage.java
---
@@ -0,0 +1,88 @@
+/*
+ * License
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126061178
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodedMeasurePage.java
---
@@ -0,0 +1,88 @@
+/*
+ * License
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126060644
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new ColumnP
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126059819
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/TablePage.java
---
@@ -84,19 +112,28 @@
measurePage = new ColumnP
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126059272
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -64,15 +63,6 @@ public ColumnPageSta
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126058814
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126058673
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/SimpleStatsResult.java
---
@@ -15,9 +15,25 @@
* limitations
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1102#discussion_r126058547
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/ValueEncoderMeta.java ---
@@ -29,26 +32,50 @@
*/
public class ValueEncode
18 matches
Mail list logo