[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126973284 --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/dictionary/client/SecureDictionaryClientHandler.java --- @@ -0,0 +1,122 @@

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126936641 --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/dictionary/client/SecureDictionaryClientHandler.java --- @@ -0,0 +1,122 @@

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126935953 --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/dictionary/client/SecureDictionaryClientHandler.java --- @@ -0,0 +1,122 @@

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126932824 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -59,7 +59,7 @@ class

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126930980 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/service/NonSecureDictionaryServiceProvider.java --- @@ -0,0 +1,37 @@ +/* +

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126906879 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/NonSecureDictionaryServerHandler.java --- @@ -76,8 +75,7 @@ public void

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126904754 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126904515 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126904475 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126900846 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryMessage.java --- @@ -50,7 +50,32 @@ */

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread sounakr
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126900457 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java --- @@ -26,6 +26,7 @@ import

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126880211 --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/dictionary/client/SecureDictionaryClientHandler.java --- @@ -0,0 +1,122 @@

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126871630 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/NewCarbonDataLoadRDD.scala --- @@ -59,7 +59,7 @@ class

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126871123 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/NonSecureDictionaryServerHandler.java --- @@ -76,8 +75,7 @@ public void

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126871296 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/service/NonSecureDictionaryServiceProvider.java --- @@ -0,0 +1,37 @@ +/* +

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126871253 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/service/DictionaryOnePassService.java --- @@ -0,0 +1,30 @@ +/* + *

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126871009 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/NonSecureDictionaryServer.java --- @@ -0,0 +1,247 @@ +/* + *

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126870879 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126870601 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126870510 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java --- @@ -14,153 +14,28 @@ * See the License for

[GitHub] carbondata pull request #1152: [CARBONDATA-1288] Secure Dictionary Server Im...

2017-07-12 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1152#discussion_r126870083 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/client/NonSecureDictionaryClientHandler.java --- @@ -57,7 +57,7 @@ public void