Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/1177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129289344
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterWithBucketingImpl.java
---
@@ -185,12
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129289336
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/UnsafeParallelReadMergeSorterWithBucketingImpl.java
---
@@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129286013
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -58,12 +58,14 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129281827
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -57,12 +57,15 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129281674
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1310,6 +1310,18 @@
public static final
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129281496
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/CarbonRowDataWriterProcessorStepImpl.java
---
@@ -112,9 +115,11
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129280832
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -57,12 +57,15 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129280724
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129280640
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129280458
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -892,6 +892,23 @@ public int
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129279731
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -57,12 +57,15 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129279394
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/UnsafeSortDataRows.java
---
@@ -306,7 +309,9 @@ private
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129198419
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129204565
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/CarbonRowDataWriterProcessorStepImpl.java
---
@@ -112,9 +115,11
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129195193
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -892,6 +892,23 @@ public int
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129219109
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1310,6 +1310,18 @@
public static
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129197372
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129202230
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -57,12 +57,15 @@
Github user bill1208 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129195768
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/merger/RowResultMergerProcessor.java
---
@@ -57,12 +57,15 @@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129061078
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/UnsafeSortDataRows.java
---
@@ -306,7 +309,9 @@ private
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129062284
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterBatchProcessorStepImpl.java
---
@@ -58,12 +58,14 @@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129057078
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterWithBucketingImpl.java
---
@@
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r129057384
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/UnsafeParallelReadMergeSorterWithBucketingImpl.java
---
@@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128666796
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/spark/util/SparkUtil4Test.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128665149
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting the
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128664527
--- Diff:
integration/spark-common-test/src/test/resources/multi_dir/data.csv ---
@@ -0,0 +1,10 @@
+1,name1
+2,name2
--- End diff --
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128560327
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/spark/util/SparkUtil4Test.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128558208
--- Diff:
integration/spark-common-test/src/test/resources/multi_dir/data.csv ---
@@ -0,0 +1,10 @@
+1,name1
+2,name2
--- End diff --
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128556528
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/unsafe/UnsafeSortDataRows.java
---
@@ -345,9 +350,12 @@ public
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128555999
--- Diff: docs/useful-tips-on-carbondata.md ---
@@ -231,5 +231,6 @@ scenarios. After the completion of POC, some of the
configurations impacting
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1177#discussion_r128147381
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1308,6 +1308,18 @@
public static
32 matches
Mail list logo
