[GitHub] carbondata pull request #1438: [CARBONDATA-1649]insert overwrite fix during ...

[akashrn5]

Github user akashrn5 closed the pull request at:

https://github.com/apache/carbondata/pull/1438


---

[GitHub] carbondata pull request #1438: [CARBONDATA-1649]insert overwrite fix during ...

[akashrn5]

Github user akashrn5 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1438#discussion_r151332421
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala
 ---
@@ -186,6 +186,12 @@ case class LoadTableCommand(
   LOGGER.error(ex, s"Dataload failure for $dbName.$tableName")
   throw new RuntimeException(s"Dataload failure for 
$dbName.$tableName, ${ex.getMessage}")
 case ex: Exception =>
+  if (ex.isInstanceOf[InterruptedException] &&
+  ex.getMessage.contains("update fail status")) {
--- End diff --

ok, i will add a new Exception for this, and throw that exception


---

[GitHub] carbondata pull request #1438: [CARBONDATA-1649]insert overwrite fix during ...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1438#discussion_r151331644
  
--- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala
 ---
@@ -186,6 +186,12 @@ case class LoadTableCommand(
   LOGGER.error(ex, s"Dataload failure for $dbName.$tableName")
   throw new RuntimeException(s"Dataload failure for 
$dbName.$tableName, ${ex.getMessage}")
 case ex: Exception =>
+  if (ex.isInstanceOf[InterruptedException] &&
+  ex.getMessage.contains("update fail status")) {
--- End diff --

It is not good to rely on message inside the exception, can you create one 
special exception for this case?


---