[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/1790


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[arshadmohammad]

Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161640543
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If CarbonData table is stored in CarbonData HIVE meta store then 
refresh will not register the CarbonData table to HIVE meta store catalogue.
--- End diff --

Thanks @KanakaKumar for your reviews. I handled the comment. Please have a 
look


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[KanakaKumar]

Github user KanakaKumar commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161461376
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If CarbonData table is stored in CarbonData HIVE meta store then 
refresh will not register the CarbonData table to HIVE meta store catalogue.
--- End diff --

Sorry I mean "If old cluster uses hive meta store, refresh will not work as 
schema file not exists in file system"


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[mohammadshahidkhan]

Github user mohammadshahidkhan commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161375031
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If CarbonData table is stored in CarbonData HIVE meta store then 
refresh will not register the CarbonData table to HIVE meta store catalogue.
--- End diff --

@KanakaKumar if schema file is present in the file system then why refresh 
will not work.
Refresh will not work schema not present in the filesystem.


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[KanakaKumar]

Github user KanakaKumar commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161213978
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If CarbonData table is stored in CarbonData HIVE meta store then 
refresh will not register the CarbonData table to HIVE meta store catalogue.
--- End diff --

Please change the point like below to convey the details of reason.

"If old cluster uses hive meta store refresh will not work as schema file 
is present in file system"


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[arshadmohammad]

Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161169827
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If Carbon table is stored in carbon HIVE meta store then refresh will 
not register the Carbon table to HIVE meta store catalogue.
--- End diff --

Changed


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[sgururajshetty]

Github user sgururajshetty commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1790#discussion_r161145720
  
--- Diff: docs/data-management-on-carbondata.md ---
@@ -271,6 +271,7 @@ This tutorial is going to introduce all commands and 
data operations on CarbonDa
   * Before executing this command the old table schema and data should be 
copied into the new database location.
   * If the table is aggregate table, then all the aggregate tables should 
be copied to the new database location.
   * For old store, the time zone of the source and destination cluster 
should be same.
+  * If Carbon table is stored in carbon HIVE meta store then refresh will 
not register the Carbon table to HIVE meta store catalogue.
--- End diff --

Change all the instances of Carbon to CarbonData


---

[GitHub] carbondata pull request #1790: [CARBONDATA-2009][Documentation] Document Ref...

[arshadmohammad]

GitHub user arshadmohammad opened a pull request:

https://github.com/apache/carbondata/pull/1790

[CARBONDATA-2009][Documentation] Document Refresh command constraint

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed? NO
 
 - [ ] Any backward compatibility impacted? NO
 
 - [ ] Document update required? YES

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   NA( This PR has only document change )
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.  NA



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arshadmohammad/carbondata CARBONDATA-2009

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1790.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1790


commit d53fee295ef8860f8c12a7d38c653015f7809f05
Author: Mohammad Arshad 
Date:   2018-01-11T01:40:12Z

[CARBONDATA-2009][Documentation] Document Refresh command constraint




---