[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[anubhav100]

Github user anubhav100 closed the pull request at:

https://github.com/apache/carbondata/pull/1795


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1795#discussion_r161794151
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortDataRows.java
 ---
@@ -270,7 +270,7 @@ private void writeDataToFile(Object[][] 
recordHolderList, int entryCountLocal, F
 } else if (dataType == DataTypes.SHORT) {
   stream.writeShort((Short) value);
 } else if (dataType == DataTypes.INT) {
-  stream.writeInt((Integer) value);
+  stream.writeInt(Integer.parseInt(value.toString()));
--- End diff --

@jackylyk ok i get your point you mean we should handle it at the base root 
level ok I am looking into it


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1795#discussion_r161792809
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortDataRows.java
 ---
@@ -270,7 +270,7 @@ private void writeDataToFile(Object[][] 
recordHolderList, int entryCountLocal, F
 } else if (dataType == DataTypes.SHORT) {
   stream.writeShort((Short) value);
 } else if (dataType == DataTypes.INT) {
-  stream.writeInt((Integer) value);
+  stream.writeInt(Integer.parseInt(value.toString()));
--- End diff --

But what is the root cause of this bug? I think your change (convert to 
string and then int) is like hiding this bug.


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1795#discussion_r161663046
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortDataRows.java
 ---
@@ -270,7 +270,7 @@ private void writeDataToFile(Object[][] 
recordHolderList, int entryCountLocal, F
 } else if (dataType == DataTypes.SHORT) {
   stream.writeShort((Short) value);
 } else if (dataType == DataTypes.INT) {
-  stream.writeInt((Integer) value);
+  stream.writeInt(Integer.parseInt(value.toString()));
--- End diff --

here is exception trace 18/01/10 16:17:12 ERROR 
CompactionResultSortProcessor: [Executor task launch 
worker-36][partitionID:customer1;queryID:15798380253871] Compaction failed: 
java.lang.Long cannot be cast to java.lang.Integer
java.lang.ClassCastException: java.lang.Long cannot be cast to 
java.lang.Integer
at 
org.apache.carbondata.processing.sort.sortdata.SortDataRows.writeDataToFile(SortDataRows.java:273)
at 
org.apache.carbondata.processing.sort.sortdata.SortDataRows.startSorting(SortDataRows.java:214)
at 
org.apache.carbondata.processing.merger.CompactionResultSortProcessor.processResult(CompactionResultSortProcessor.java:226)
at 
org.apache.carbondata.processing.merger.CompactionResultSortProcessor.execute(CompactionResultSortProcessor.java:159)
at 
org.apache.carbondata.spark.rdd.CarbonMergerRDD$$anon$1.(CarbonMergerRDD.scala:234)
at 
org.apache.carbondata.spark.rdd.CarbonMergerRDD.internalCompute(CarbonMergerRDD.scala:81)


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[anubhav100]

Github user anubhav100 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1795#discussion_r161446115
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortDataRows.java
 ---
@@ -270,7 +270,7 @@ private void writeDataToFile(Object[][] 
recordHolderList, int entryCountLocal, F
 } else if (dataType == DataTypes.SHORT) {
   stream.writeShort((Short) value);
 } else if (dataType == DataTypes.INT) {
-  stream.writeInt((Integer) value);
+  stream.writeInt(Integer.parseInt(value.toString()));
--- End diff --

https://issues.apache.org/jira/browse/CARBONDATA-2016


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[jackylk]

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1795#discussion_r161242586
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SortDataRows.java
 ---
@@ -270,7 +270,7 @@ private void writeDataToFile(Object[][] 
recordHolderList, int entryCountLocal, F
 } else if (dataType == DataTypes.SHORT) {
   stream.writeShort((Short) value);
 } else if (dataType == DataTypes.INT) {
-  stream.writeInt((Integer) value);
+  stream.writeInt(Integer.parseInt(value.toString()));
--- End diff --

Can you post the error message and describe what is the root cause of this 
bug?


---

[GitHub] carbondata pull request #1795: [CARBONDATA-2016] Exception displays while ex...

[anubhav100]

GitHub user anubhav100 opened a pull request:

https://github.com/apache/carbondata/pull/1795

[CARBONDATA-2016] Exception displays while executing compaction with alter 
query

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anubhav100/incubator-carbondata 
CARBONDATA-2016

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1795


commit 94a1df25bf2165ff6fcd0ffa66051664f8115998
Author: anubhav100 
Date:   2018-01-11T10:08:49Z

Exception displays while executing compaction with alter query

commit 476d659b6e4cf0b66f87194778854ef75d593eea
Author: anubhav100 
Date:   2018-01-11T10:11:09Z

Revert "Exception displays while executing compaction with alter query"

This reverts commit 94a1df25bf2165ff6fcd0ffa66051664f8115998.

commit 43d6368c1567c537ea6b0f4f70a02a9d5d51c079
Author: anubhav100 
Date:   2018-01-11T10:12:15Z

Exception displays while executing compaction with alter query




---