[GitHub] carbondata pull request #1950: [CARBONDATA-2145] Refactored PreAggregate fun...

[SangeetaGulia]

Github user SangeetaGulia closed the pull request at:

https://github.com/apache/carbondata/pull/1950


---

[GitHub] carbondata pull request #1950: [CARBONDATA-2145] Refactored PreAggregate fun...

[SangeetaGulia]

GitHub user SangeetaGulia opened a pull request:

https://github.com/apache/carbondata/pull/1950

[CARBONDATA-2145] Refactored PreAggregate functionality for dictionary 
include

Description: Add the count to measure column only when the column is 
dictionary type in maintable.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [x] Any interfaces changed? No
 
 - [x] Any backward compatibility impacted? No
 
 - [x] Document update required? No

 - [x] Testing done 
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
Ran already wriiten Unit Test case to test the functionality.
Added Unit Test Case to check count on string type.

- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.  (N/A)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SangeetaGulia/incubator-carbondata 
refactoringPreAgg

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1950


commit 576eb2e8997420125e90afbf85b37ca9cf9429ef
Author: SangeetaGulia 
Date:   2018-02-07T08:15:29Z

Refactored code for encodings when dictionary_include is present

commit 71ab2208aa0a45b9504f6dd9245b23d5f996
Author: SangeetaGulia 
Date:   2018-02-07T08:16:11Z

Added test case on preAggregate for string type with count as aggregate 
function




---