[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2246 ---

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189422726 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189421336 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189318314 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189223250 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-17 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189142890 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -175,6 +175,18 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-17 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r188972807 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -175,6 +175,18 @@ public

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-16 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r188817870 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1657,6 +1657,16 @@ public static

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-16 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r188615464 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1657,6 +1657,16 @@ public static

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-09 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r186940468 --- Diff: store/sdk/src/test/java/org/apache/carbondata/store/LocalCarbonStoreTest.java --- @@ -28,9 +28,16 @@ import

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-08 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r186923021 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -259,14 +259,16 @@ public static

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-08 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r186921137 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -259,14 +259,16 @@ public static

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-03 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r185716301 --- Diff: store/sdk/src/test/java/org/apache/carbondata/store/LocalCarbonStoreTest.java --- @@ -28,9 +28,16 @@ import

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-04-27 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/2246 [CARBONDATA-2413] After running CarbonWriter, there is null/_system directory about datamap change the system folder location property, which will change the system location of datamap