[GitHub] carbondata pull request #2326: [CARBONDATA-2503] Data write fails if empty v...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2326 ---

[GitHub] carbondata pull request #2326: [CARBONDATA-2503] Data write fails if empty v...

2018-05-22 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2326#discussion_r189787853 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -488,6 +491,8 @@ private void

[GitHub] carbondata pull request #2326: [CARBONDATA-2503] Data write fails if empty v...

2018-05-22 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2326#discussion_r189787603 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -406,8 +406,9 @@ private CarbonTable

[GitHub] carbondata pull request #2326: [CARBONDATA-2503] Data write fails if empty v...

2018-05-22 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2326#discussion_r189787714 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -431,18 +432,20 @@ private void