[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

2018-07-30 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2578#discussion_r206396378 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/LoadOption.java --- @@ -236,7 +236,7 @@ } }

[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

2018-07-30 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2578#discussion_r206091924 --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java --- @@ -172,7 +191,7 @@ public void

[GitHub] carbondata pull request #2578: Fix Dictionary_Include for ComplexDataType

2018-07-30 Thread Indhumathi27
GitHub user Indhumathi27 opened a pull request: https://github.com/apache/carbondata/pull/2578 Fix Dictionary_Include for ComplexDataType Why this PR for? Check if a column is given as Dictionary_Include and fill cardinality for that column - [ ] Any interfaces changed?