Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2772
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r228050566
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -100,17 +100,17 @@ private DataChunk2
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r228049899
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -534,6 +534,11 @@ private int
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r227304248
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageEncoder.java
---
@@ -100,17 +100,17 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2772#discussion_r227303328
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java
---
@@ -534,6 +534,11 @@ private int
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2772
[CARBONDATA-2977] Write uncompress_size to ChunkCompressMeta in the file
Currently total_uncompressed_size and total_compress_size in the
ChunkCompressMeta in the carbondata file is always 0.
