[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3036 ---

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread runzhliu
Github user runzhliu commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3036#discussion_r244537813 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -287,31 +287,31 @@ private void

[GitHub] carbondata pull request #3036: [CARBONDATA-3208] Remove unused parameters, i...

2018-12-30 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3036#discussion_r244535093 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -287,31 +287,31 @@ private void