[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3044 ---
[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224509 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,24 @@ Users can specify which columns to include and exclude for local dictionary gene **NOTE:** Drop Complex child column is not supported. - - # CHANGE DATA TYPE + - # CHANGE COLUMN NAME/TYPE - This command is used to change the data type from INT to BIGINT or decimal precision from lower to higher. + This command is used to change the column's name and the data type from INT to BIGINT or decimal precision from lower to higher and rename column. --- End diff -- Write this as below `This command is used to change column name and the data type from INT to BIGINT or decimal precision from lower to higher.` ---
[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224386 --- Diff: docs/ddl-of-carbondata.md --- @@ -47,7 +47,8 @@ CarbonData DDL statements are documented here,which includes: * [RENAME TABLE](#rename-table) * [ADD COLUMNS](#add-columns) * [DROP COLUMNS](#drop-columns) -* [CHANGE DATA TYPE](#change-data-type) +* [RENAME COLUMN](#change-column-name-/-type) +* [CHANGE DATA TYPE](#change-column-name-/-type) --- End diff -- check for linking. With this text it will not link ---
[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r245224565 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,24 @@ Users can specify which columns to include and exclude for local dictionary gene **NOTE:** Drop Complex child column is not supported. - - # CHANGE DATA TYPE + - # CHANGE COLUMN NAME/TYPE - This command is used to change the data type from INT to BIGINT or decimal precision from lower to higher. + This command is used to change the column's name and the data type from INT to BIGINT or decimal precision from lower to higher and rename column. Change of decimal data type from lower precision to higher precision will only be supported for cases where there is no data loss. ``` - ALTER TABLE [db_name.]table_name CHANGE col_name col_name changed_column_type + ALTER TABLE [db_name.]table_name CHANGE old_col_name new_col_name column_data_type --- End diff -- Change this as below `ALTER TABLE [db_name.]table_name CHANGE col_old_name col_new_name column_type` ---
[GitHub] carbondata pull request #3044: [CARBONDATA-3149]Documentation for alter tabl...
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3044#discussion_r244919178 --- Diff: docs/ddl-of-carbondata.md --- @@ -681,24 +682,28 @@ Users can specify which columns to include and exclude for local dictionary gene **NOTE:** Drop Complex child column is not supported. - - # CHANGE DATA TYPE + - # RENAME COLUMN AND CHANGE DATATYPE --- End diff -- Change this to `Change Column Name/Type`. Please go through the below link and try to align the documentation in that way if possible https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ChangeColumnName/Type/Position/Comment ---