kumarvishal09 commented on a change in pull request #3098: [CARBONDATA-3235]
Fixed Alter Table Rename
URL: https://github.com/apache/carbondata/pull/3098#discussion_r250533327
##########
File path:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
##########
@@ -61,6 +61,8 @@ private[sql] case class CarbonAlterTableRenameCommand(
}
val oldTableName = oldTableIdentifier.table.toLowerCase
val newTableName = newTableIdentifier.table.toLowerCase
+ val oldIdentifier = TableIdentifier(oldTableName, Some(oldDatabaseName))
Review comment:
what the purpose of creating oldIdentifier and newIdentifier again?? when
already both identifiers are present
https://github.com/apache/carbondata/pull/3098/files#diff-9fb2c5a8b63af8d61563a154cdfc8a3cR46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
