Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/338#discussion_r90397726
--- Diff:
core/src/main/java/org/apache/carbondata/core/compression/DoubleCompressor.java
---
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/338#discussion_r90397522
--- Diff:
core/src/main/java/org/apache/carbondata/core/compression/BigIntCompressor.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395469
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -814,85 +810,86 @@
* Rocord s
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395244
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/AbstractMeasureChunkReader.java
---
@@ -18,
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395252
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/CompressedMeasureChunkFileReader2.java
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395412
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -814,85 +810,86 @@
* Rocord s
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395264
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/CompressedMeasureChunkFileReader2.java
---
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90395320
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/metadata/blocklet/DataFileFooter.java
---
@@ -38,7 +38,7 @@
/**
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/338#discussion_r90394339
--- Diff:
core/src/main/java/org/apache/carbondata/core/compression/BigIntCompressor.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/338#discussion_r90393993
--- Diff:
core/src/main/java/org/apache/carbondata/core/compression/BigIntCompressor.java
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/366
please rebase, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90386123
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/dimension/CompressedDimensionChunkFileBasedReader2.java
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90386030
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/block/TableBlockInfo.java
---
@@ -81,13 +84,14 @@ public TableBl
Github user kumarvishal09 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/265
@jackylk all the existing test cases are running with V2 and some I have
updated with V1 version. ok I will add test cases for reading V1 version file
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
GitHub user jackylk opened a pull request:
https://github.com/apache/incubator-carbondata/pull/375
Fix compile error for spark1.6 integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata spark16
A
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/362
I have ginve one more comment and, others LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/362#discussion_r90365594
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/hive/DistributionUtil.scala
---
@@ -101,47 +101,107 @@ object DistributionUtil
[
https://issues.apache.org/jira/browse/CARBONDATA-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li resolved CARBONDATA-473.
-
Resolution: Fixed
Assignee: Fei Wang
> spark 2 stable datasource api integration
> -
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
Thanks for working for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
CI passed
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/717/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
CI running
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/716/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
CI running
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/715/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/265
please add testcase for V2 write and read
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90250147
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -814,85 +810,86 @@
* Rocord size in
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90249468
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/metadata/blocklet/DataFileFooter.java
---
@@ -38,7 +38,7 @@
/**
*
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90249260
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/CompressedMeasureChunkFileReader2.java
---
@@ -0,
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90249159
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/CompressedMeasureChunkFileReader2.java
---
@@ -0,
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90249003
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/measure/AbstractMeasureChunkReader.java
---
@@ -18,58 +18
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90246051
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/dimension/CompressedDimensionChunkFileBasedReader2.java
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90245110
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/CarbonDataReaderFactory.java
---
@@ -0,0 +1,93 @@
+/*
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/265#discussion_r90244822
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/block/TableBlockInfo.java
---
@@ -81,13 +84,14 @@ public TableBlockInf
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
There are codestyle failing, please correct them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
WilliamZhu created CARBONDATA-477:
-
Summary: Can we merge storeLocation and metaLocation into one?
Key: CARBONDATA-477
URL: https://issues.apache.org/jira/browse/CARBONDATA-477
Project: CarbonData
WilliamZhu created CARBONDATA-476:
-
Summary: storeLocation start with file:/// cause table not found
exceptioin
Key: CARBONDATA-476
URL: https://issues.apache.org/jira/browse/CARBONDATA-476
Project: C
Github user allwefantasy commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90229415
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -604,4 +606,33 @@ public stat
Github user allwefantasy commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90228110
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonMetastoreCatalog.scala
---
@@ -307,10 +307,17 @@ class CarbonMe
Github user allwefantasy commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90228003
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -763,10 +763,9 @@ case cl
Github user scwf commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
@jacklk added test case from empty table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
Yes, bigint datatype has some issue, please raise a JIRA for it.
And can you add some basic testcase for this PR
---
If your project is set up for it, you can reply to this email an
GitHub user anubhav100 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/374
[Carbondata 475] Added test cases for
org.apache.carbondata.core.carbon.querystatistics
Be sure to do all of the following to help us incorporate your contribution
quickly and e
Github user scwf commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
the result has some issues for the carbon example:
```
+--++---+---+---+
|shortField|intField|bigintField|doubleField|stringField|
+--
Anurag Srivastava created CARBONDATA-475:
Summary: Implement unit test cases for core.carbon.querystatics
package
Key: CARBONDATA-475
URL: https://issues.apache.org/jira/browse/CARBONDATA-475
[
https://issues.apache.org/jira/browse/CARBONDATA-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anurag Srivastava updated CARBONDATA-475:
-
Issue Type: Test (was: Bug)
> Implement unit test cases for core.carbon.query
GitHub user anuragknoldus opened a pull request:
https://github.com/apache/incubator-carbondata/pull/373
test case for columnar package and manage package for filesystem
Implement test case for columnar package and manage packaging for
file-system project
You can merge this pull re
Anurag Srivastava created CARBONDATA-474:
Summary: Implement unit test cases for
core.datastorage.store.columnar package
Key: CARBONDATA-474
URL: https://issues.apache.org/jira/browse/CARBONDATA-474
Github user manishgupta88 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/362
@jackylk ...Handled all review comments. Kindly review and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user scwf commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/372#discussion_r90207315
--- Diff: integration/spark-common/pom.xml ---
@@ -84,6 +79,11 @@
junit
+ com.databricks
+ spark-cs
Github user jackylk commented on the issue:
https://github.com/apache/incubator-carbondata/pull/372
Is there an example to run carbon with spark2?
Can these code work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90197023
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -604,4 +606,33 @@ public static
GitHub user scwf opened a pull request:
https://github.com/apache/incubator-carbondata/pull/372
[CARBONDATA-473] integrate with spark 2 stable datasource api
1. read path: based on spark2 datasource api
2. load path: give a tool to do data load
You can merge this pull request
Fei Wang created CARBONDATA-473:
---
Summary: spark 2 stable datasource api integration
Key: CARBONDATA-473
URL: https://issues.apache.org/jira/browse/CARBONDATA-473
Project: CarbonData
Issue Type
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90195041
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonMetastoreCatalog.scala
---
@@ -307,10 +307,17 @@ class CarbonMeta
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/368#discussion_r90194407
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -763,10 +763,9 @@ case clas
55 matches
Mail list logo
