[GitHub] incubator-carbondata issue #632: [CARBONDATA-732] Exclude netty dependencies...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/632 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-carbondata pull request #632: [CARBONDATA-732] Exclude netty depen...

2017-03-07 Thread PKOfficial
GitHub user PKOfficial opened a pull request: https://github.com/apache/incubator-carbondata/pull/632 [CARBONDATA-732] Exclude netty dependencies in assembly module You can merge this pull request into a Git repository by running: $ git pull

[jira] [Assigned] (CARBONDATA-732) User unable to execute the select/Load query using thrift server.

2017-03-07 Thread anubhav tarar (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] anubhav tarar reassigned CARBONDATA-732: Assignee: anubhav tarar > User unable to execute the select/Load query using

[jira] [Assigned] (CARBONDATA-740) Add logger for rows processed while closing in AbstractDataLoadProcessorStep

2017-03-07 Thread Cao, Lionel (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cao, Lionel reassigned CARBONDATA-740: -- Assignee: Cao, Lionel (was: Liang Chen) > Add logger for rows processed while

[GitHub] incubator-carbondata issue #629: [CARBONDATA-740] add logger for total rows ...

2017-03-07 Thread lionelcao
Github user lionelcao commented on the issue: https://github.com/apache/incubator-carbondata/pull/629 @ravipesala Added step name, please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-carbondata issue #628: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-07 Thread lionelcao
Github user lionelcao commented on the issue: https://github.com/apache/incubator-carbondata/pull/628 Hi @ravipesala , I compared those two files before commit and I think the difference has no impact to the functionality. Any ideas? --- If your project is set up for it, you can

[GitHub] incubator-carbondata issue #629: [CARBONDATA-740] add logger for total rows ...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/629 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1032/ --- If your project is set up for it, you can reply to this email and

[jira] [Closed] (CARBONDATA-745) Does carbondata apply to scenes that need to sort historical and current data?

2017-03-07 Thread ke xu (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ke xu closed CARBONDATA-745. > Does carbondata apply to scenes that need to sort historical and current data? >

[jira] [Resolved] (CARBONDATA-745) Does carbondata apply to scenes that need to sort historical and current data?

2017-03-07 Thread ke xu (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ke xu resolved CARBONDATA-745. -- Resolution: Resolved Fix Version/s: 1.0.0-incubating > Does carbondata apply to scenes that

[jira] [Commented] (CARBONDATA-745) Does carbondata apply to scenes that need to sort historical and current data?

2017-03-07 Thread ke xu (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900540#comment-15900540 ] ke xu commented on CARBONDATA-745: -- It is the need to sort a field of the table,returns the sorted

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-07 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104709184 --- Diff: format/src/main/thrift/carbondata.thrift --- @@ -183,11 +183,23 @@ struct FileFooter{ } /** +* Footer for

[jira] [Updated] (CARBONDATA-748) "between and" filter query is very slow

2017-03-07 Thread Jarck (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarck updated CARBONDATA-748: - thanks for your quick response and suggestion. But if don't change setFilterdIndexToBitSet. what

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 Yes, those are the 2 cases we can do binary search on dimension. Regarding question1 , no it does not create inverted index if the data is already sorted(naturally sorted).

[GitHub] incubator-carbondata issue #631: [CARBONDATA-751]Adding Header And Making Fo...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1030/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-07 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104660895 --- Diff: pom.xml --- @@ -93,6 +93,7 @@ common +format --- End diff -- I have change the

[GitHub] incubator-carbondata pull request #631: [CARBONDATA-751]Adding Header And Ma...

2017-03-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/631#discussion_r104660524 --- Diff: pom.xml --- @@ -93,6 +93,7 @@ common +format --- End diff -- This is not required since

[jira] [Created] (CARBONDATA-751) Adding Header and making footer optional

2017-03-07 Thread kumar vishal (JIRA)
kumar vishal created CARBONDATA-751: --- Summary: Adding Header and making footer optional Key: CARBONDATA-751 URL: https://issues.apache.org/jira/browse/CARBONDATA-751 Project: CarbonData

[GitHub] incubator-carbondata issue #631: [WIP]Adding Header And Making Footer Option...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/631 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1029/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #631: [WIP]Adding Header And Making Footer...

2017-03-07 Thread kumarvishal09
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/incubator-carbondata/pull/631 [WIP]Adding Header And Making Footer Optional Currently carbon does not support appendable format, so below changes is to support appendable format in V3 data file format by

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1028/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #624: [CARBONDATA-747][WIP] Add simple performanc...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/624 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1027/ --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (CARBONDATA-745) Does carbondata apply to scenes that need to sort historical and current data?

2017-03-07 Thread Liang Chen (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899315#comment-15899315 ] Liang Chen commented on CARBONDATA-745: --- First, see if i understood it: There is a sorted

[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1026/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #630: [CARBONDATA-730]added decimal type i...

2017-03-07 Thread anubhav100
GitHub user anubhav100 opened a pull request: https://github.com/apache/incubator-carbondata/pull/630 [CARBONDATA-730]added decimal type in carbon data frame writer Below exception is thrown while trying to save dataframe with a decimal column type. scala> df.printSchema

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread simafengyun
Github user simafengyun commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 so binary search only fit the below cases,please comfirm thanks 1 the first dimension column , since it's logicl order are the same with physical order in blocklet

[GitHub] incubator-carbondata pull request #624: [CARBONDATA-747][WIP] Add simple per...

2017-03-07 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/624#discussion_r104642435 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CompareTest.scala --- @@ -0,0 +1,122 @@ +/* + * Licensed to

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 @simafengyun you are right, default we sort the data but we can avoid sorting using `no_inverted_index` property at tblproperties level. So if user uses this configuration then we

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread simafengyun
Github user simafengyun commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 You mentioned the below, >> But using this search in setFilterdIndexToBitSet is not always correct. Because here the data may not be sorted

[GitHub] incubator-carbondata issue #628: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/628 @lionelcao Thank you for working on this, But there are some differences in files from `CarbonFilters` of spark-common package and spark2 package. That is why I mentioned in jira

[GitHub] incubator-carbondata pull request #629: [CARBONDATA-740] add logger for tota...

2017-03-07 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/629#discussion_r104634820 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java --- @@ -157,6 +157,7 @@

[GitHub] incubator-carbondata issue #629: [CARBONDATA-740] add logger for total rows ...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/629 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1025/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #623: [CARBONDATA-746] Add spark-sql CLI s...

2017-03-07 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/623#discussion_r104629836 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/cli/CarbonSQLCLIDriver.scala --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] incubator-carbondata pull request #623: [CARBONDATA-746] Add spark-sql CLI s...

2017-03-07 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/623#discussion_r104630150 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/cli/CarbonContext.scala --- @@ -0,0 +1,30 @@ +/* + *

[GitHub] incubator-carbondata pull request #629: [CARBONDATA-740] add logger for tota...

2017-03-07 Thread lionelcao
GitHub user lionelcao opened a pull request: https://github.com/apache/incubator-carbondata/pull/629 [CARBONDATA-740] add logger for total rows processed add logger for total rows processed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-carbondata pull request #628: [CARBONDATA-743] Remove redundant Ca...

2017-03-07 Thread lionelcao
GitHub user lionelcao opened a pull request: https://github.com/apache/incubator-carbondata/pull/628 [CARBONDATA-743] Remove redundant CarbonFilters file Remove redundant CarbonFilters file in spark2 and keep the one in spark common You can merge this pull request into a Git

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 @simafengyun Please raise this PR on master as we don't have any plans to provide patches on branch-0.2. And also please format the code. --- If your project is set up for it, you

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 @simafengyun Thanks for working on it. Range binary search is impressive. we can use same search in other places as well. But using this search in `setFilterdIndexToBitSet`

[GitHub] incubator-carbondata issue #627: CARBONDATA-748

2017-03-07 Thread simafengyun
Github user simafengyun commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 yes I just fixed on branch-0.2. If code is ok, I can continue to fix for version 1.0 At 2017-03-07 17:20:44, "Zhichao

[GitHub] incubator-carbondata pull request #625: [CARBONDATA-743] Remove redundant Ca...

2017-03-07 Thread lionelcao
Github user lionelcao closed the pull request at: https://github.com/apache/incubator-carbondata/pull/625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-carbondata issue #627: fix jira CARBONDATA-748 for version 0.2

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1023/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata issue #627: fix jira CARBONDATA-748 for version 0.2

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1022/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...

2017-03-07 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/622#discussion_r104622543 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -116,8 +116,8 @@ class

[GitHub] incubator-carbondata issue #627: fix jira CARBONDATA-748 for version 0.2

2017-03-07 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #627: fix jira CARBONDATA-748 for version 0.2

2017-03-07 Thread Hexiaoqiao
Github user Hexiaoqiao commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 @simafengyun thanks for your work, please rename title follow the format `[CARBONDATA-issue number>] Title of the pull request`. --- If your project is set up for it, you can

[GitHub] incubator-carbondata pull request #627: fix jira CARBONDATA-748 for version ...

2017-03-07 Thread Hexiaoqiao
Github user Hexiaoqiao commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/627#discussion_r104617853 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -152,6 +152,159 @@ static boolean lessThanUnsigned(long

[GitHub] incubator-carbondata issue #625: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/625 Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1021/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #627: fix jira CARBONDATA-748 for version ...

2017-03-07 Thread Hexiaoqiao
Github user Hexiaoqiao commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/627#discussion_r104614642 --- Diff: core/src/main/java/org/apache/carbondata/scan/filter/executer/IncludeFilterExecuterImpl.java --- @@ -154,24 +154,45 @@ private

[GitHub] incubator-carbondata pull request #627: fix jira CARBONDATA-748 for version ...

2017-03-07 Thread Hexiaoqiao
Github user Hexiaoqiao commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/627#discussion_r104613452 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -152,6 +152,159 @@ static boolean lessThanUnsigned(long

[GitHub] incubator-carbondata issue #625: [CARBONDATA-743] Remove redundant CarbonFil...

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/625 Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1020/ --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-carbondata pull request #627: fix jira CARBONDATA-748 for version ...

2017-03-07 Thread Hexiaoqiao
Github user Hexiaoqiao commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/627#discussion_r104611743 --- Diff: core/src/main/java/org/apache/carbondata/core/util/ByteUtil.java --- @@ -152,6 +152,159 @@ static boolean lessThanUnsigned(long

[GitHub] incubator-carbondata issue #627: fix jira CARBONDATA-748 for version 0.2

2017-03-07 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/incubator-carbondata/pull/627 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-carbondata pull request #627: fix jira CARBONDATA-748 for version ...

2017-03-07 Thread simafengyun
GitHub user simafengyun opened a pull request: https://github.com/apache/incubator-carbondata/pull/627 fix jira CARBONDATA-748 for version 0.2 fix jira CARBONDATA-748, use binary search to replace linear search the performance is much better no ,from more than 10 seconds to a