[GitHub] incubator-carbondata issue #648: [CARBONDATA-758]remove kettle related code ...

2017-03-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/648 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can re

[GitHub] incubator-carbondata issue #642: [CARBONDATA-756]Fixed RLE Encoding Issue

2017-03-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/642 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can re

[GitHub] incubator-carbondata issue #648: [CARBONDATA-758]remove kettle related code ...

2017-03-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/648 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #646: [CARBONDATA-748] put if clause out of the f...

2017-03-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/646 @mayunSaicmotor please squash into one commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-carbondata pull request #645: Add Git config for how to contributi...

2017-03-10 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/645 Add Git config for how to contribution guide Add Git config for how to contribution guide: $ git config --global user.email "y...@example.com" $ git confi

[GitHub] incubator-carbondata pull request #640: [CARBONDATA-755]Confusing comment ab...

2017-03-10 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/640#discussion_r105523770 --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala --- @@ -44,7 +44,7 @@ object CarbonExample

[GitHub] incubator-carbondata issue #638: [Carbondata 748] use binary search improve ...

2017-03-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/638 @mayunSaicmotor please change "[Carbondata 748] " to "[CARBONDATA-748]" for PR's title. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-carbondata issue #640: Update CarbonExample.scala

2017-03-09 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/640 @sehriff Thanks for your contributions. Please create a JIRA issue as per the guide : https://github.com/apache/incubator-carbondata/blob/master/docs/How-to-contribute

[GitHub] incubator-carbondata issue #636: [CARBONDATA-741] Remove useless classes

2017-03-09 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/636 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #614: [CARBONDATA-714]Documented how to handle ba...

2017-03-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/614 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #634: [CARBONDATA-753] Fix Date and Timest...

2017-03-08 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/634#discussion_r104925662 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -383,7 +383,7

[GitHub] incubator-carbondata pull request #614: [CARBONDATA-714]Documented how to ha...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/614#discussion_r104550978 --- Diff: docs/faq.md --- @@ -18,30 +18,57 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata pull request #614: [CARBONDATA-714]Documented how to ha...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/614#discussion_r104550787 --- Diff: docs/faq.md --- @@ -18,30 +18,57 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata pull request #614: [CARBONDATA-714]Documented how to ha...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/614#discussion_r104548399 --- Diff: docs/faq.md --- @@ -18,30 +18,57 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata pull request #614: [CARBONDATA-714]Documented how to ha...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/614#discussion_r104547671 --- Diff: docs/faq.md --- @@ -18,30 +18,57 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata pull request #622: [CARBONDATA-744] The property "spark...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/622#discussion_r104545841 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -116,8 +116,8 @@ class

[GitHub] incubator-carbondata pull request #625: [CARBONDATA-743] Remove redundant Ca...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/625#discussion_r104424923 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -1,397 +0,0

[GitHub] incubator-carbondata pull request #625: [CARBONDATA-743] Remove redundant Ca...

2017-03-06 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/625#discussion_r104424040 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala --- @@ -1,397 +0,0

[GitHub] incubator-carbondata issue #617: [CARBONDATA-719] Add release guide

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/617 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #617: [CARBONDATA-719] Add release guide

2017-02-28 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/617#discussion_r103472571 --- Diff: docs/release-guide.md --- @@ -0,0 +1,482 @@ + + +# Apache CarbonData Release Guide + +Apache CarbonData

[GitHub] incubator-carbondata issue #578: [CARBONDATA-684] Improve Tests and Coverage...

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/578 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #614: [CARBONDATA-714]Documented how to handle ba...

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/614 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #616: [CARBONDATA-708] Fixed Between Filter Issue...

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/616 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #617: [CARBONDATA-719] Add release guide

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/617 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #615: [CARBONDATA-733]Fixed Testcase failure Issu...

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/615 LGTM, verified. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #615: [CARBONDATA-733]Fixed Testcase failure Issu...

2017-02-28 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/615 Tested at my machine, it is failed, please check : Tests in error: BlockIndexStoreTest.testLoadAndGetTaskIdToSegmentsMapForSingleSegment:85 NullPointer

[GitHub] incubator-carbondata issue #595: [CARBONDATA-700]corrected doc for ddl opera...

2017-02-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/595 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #611: [CARBONDATA-731] Enhance and correct quick ...

2017-02-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/611 @Hexiaoqiao can you review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-carbondata pull request #611: [CARBONDATA-731] Enhance and correct...

2017-02-27 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/611#discussion_r103344126 --- Diff: docs/installation-guide.md --- @@ -40,42 +40,46 @@ followed by : ### Procedure -* [Build the CarbonData

[GitHub] incubator-carbondata issue #613: [CARBONDATA-718] Add rat to check if all fi...

2017-02-27 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/613 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #609: [CARBONDATA-726] Added code for V3 f...

2017-02-25 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/609#discussion_r103079634 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -83,7 +83,7

[GitHub] incubator-carbondata pull request #609: [CARBONDATA-726] Added code for V3 f...

2017-02-24 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/609#discussion_r103073461 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -81,7 +81,7

[GitHub] incubator-carbondata issue #603: Fix the bug of inverted index that store in...

2017-02-22 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/603 @Zhangshunyu As you mentioned "Problem: In current code, inverted index in ddl info is not stored into store, and when we restart the cluster, query might mis

[GitHub] incubator-carbondata pull request #607: [CARBONDATA-712]resolve the bug for ...

2017-02-22 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/607#discussion_r102593162 --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordsLogger.java

[GitHub] incubator-carbondata pull request #595: [CARBONDATA-700]corrected doc for dd...

2017-02-22 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/595#discussion_r102417415 --- Diff: docs/ddl-operation-on-carbondata.md --- @@ -115,8 +115,7 @@ TBLPROPERTIES ("COLUMN_GROUPS"="(

[GitHub] incubator-carbondata pull request #602: [CARBONDATA-710] Updated the FAQs an...

2017-02-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/602#discussion_r102396819 --- Diff: docs/faq.md --- @@ -18,30 +18,124 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata pull request #602: [CARBONDATA-710] Updated the FAQs an...

2017-02-21 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/602#discussion_r102396384 --- Diff: docs/faq.md --- @@ -18,30 +18,124 @@ --> # FAQs -* **Auto Compaction not Work

[GitHub] incubator-carbondata issue #602: [CARBONDATA-710] Updated the FAQs and Troub...

2017-02-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/602 @sgururajshetty please review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-carbondata issue #582: [CARBONDATA-687] Added documentation for ne...

2017-02-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/582 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100695668 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/row/CarbonRowBatch.java --- @@ -17,27 +17,40

[GitHub] incubator-carbondata pull request #598: [CARBONDATA-703] Update build comman...

2017-02-11 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/598 [CARBONDATA-703] Update build command after optimizing thrift compile issues Update build command after optimizing thrift compile issues You can merge this pull request

[GitHub] incubator-carbondata issue #596: [CARBONDATA-702] Created carbondata reposit...

2017-02-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/596 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #596: [CARBONDATA-702] Created carbondata reposit...

2017-02-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/596 upload format jar script should be : > mvn deploy:deploy-file -DpomFile=/home/root1/carbon/incubator-carbondata/format/pom.xml -Dfile=/home/root1/carbon/incuba

[GitHub] incubator-carbondata issue #596: [WIP]Test for repository

2017-02-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/596 @ravipesala please update build document accordingly https://github.com/apache/incubator-carbondata/tree/master/build --- If your project is set up for it, you can reply

[GitHub] incubator-carbondata pull request #582: [CARBONDATA-687] Added documentation...

2017-02-09 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/582#discussion_r100323473 --- Diff: docs/ddl-operation-on-carbondata.md --- @@ -27,18 +27,19 @@ The following DDL operations are supported in CarbonData

[GitHub] incubator-carbondata pull request #592: [CARBONDATA-695] Reads carbon data t...

2017-02-07 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/592 [CARBONDATA-695] Reads carbon data to dataframe in example/spark2 Create DataFrame example in example/spark2, read carbon data to dataframe. You can merge this pull request

[GitHub] incubator-carbondata pull request #582: [CARBONDATA-687] Added documentation...

2017-02-07 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/582#discussion_r99877552 --- Diff: docs/troubleshooting.md --- @@ -18,13 +18,249 @@ --> # Troubleshooting -This tutorial is designed to prov

[GitHub] incubator-carbondata issue #586: [WIP]Added code to support data loading in ...

2017-02-07 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/586 @kumarvishal09 please squash all commits to one commit once you finish all changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-carbondata issue #587: [CARBONDATA-694] Updated Quick Start

2017-02-06 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/587 @PallaviSingh1992 This JIRA issue has been assgined to He xiaoqiao, please don't fix it repeatedly. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-carbondata issue #577: [CARBONDATA-683] Reduce test time

2017-02-01 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/577 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #581: [CARBONDATA-686]� Extend period coverage in...

2017-01-30 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/581 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #581: [CARBONDATA-686]� Extend period coverage in...

2017-01-30 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/581 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #574: [CARBONDATA-682] Added License to FloatData...

2017-01-26 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/574 please squash the commits to one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-carbondata pull request #568: Fix docs issues

2017-01-24 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/568#discussion_r97675261 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf

[GitHub] incubator-carbondata pull request #568: Fix docs issues

2017-01-24 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/568#discussion_r97675250 --- Diff: docs/quick-start-guide.md --- @@ -70,24 +70,22 @@ val carbon = SparkSession.builder().config(sc.getConf

[GitHub] incubator-carbondata pull request #568: Fix docs issues

2017-01-23 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266970 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required

[GitHub] incubator-carbondata pull request #568: Fix docs issues

2017-01-23 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/568#discussion_r97266982 --- Diff: docs/configuration-parameters.md --- @@ -142,7 +142,7 @@ This section provides the details of all the configurations required

[GitHub] incubator-carbondata pull request #568: Fix docs issues

2017-01-22 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/568 Fix docs issues Fix docs issues * quick-start-guide * configuration-parameters * data-management You can merge this pull request into a Git repository by running

[GitHub] incubator-carbondata issue #563: [CARBONDATA-670] Added MD Files

2017-01-20 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/563 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

2017-01-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/563#discussion_r97071128 --- Diff: docs/overview-of-carbondata.md --- @@ -0,0 +1,67 @@ + +# Overview --- End diff -- remove overview

[GitHub] incubator-carbondata pull request #563: [CARBONDATA-670] Added MD Files

2017-01-20 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/563#discussion_r97070802 --- Diff: README.md --- @@ -40,6 +40,9 @@ CarbonData is built using Apache Maven, to [build CarbonData](https://github.com

[GitHub] incubator-carbondata issue #531: [CARBONDATA-612]throw exception when trying...

2017-01-20 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/531 @anubhav100 the feature would be supported in all versions, but only be suggested using in spark 2.1 for getting ideal performance. --- If your project is set up for it, you can

[GitHub] incubator-carbondata pull request #557: [WIP] Set carbon properties location...

2017-01-19 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/557#discussion_r97020867 --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala --- @@ -39,14 +42,15

[GitHub] incubator-carbondata pull request #559: Fix issues for document link

2017-01-19 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/559 Fix issues for document link Fix issues for document link You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613

[GitHub] incubator-carbondata issue #546: [CARBONDATA-655][CARBONDATA-604]Make no ket...

2017-01-19 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/546 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #546: [CARBONDATA-655][CARBONDATA-604]Make...

2017-01-18 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/546#discussion_r96658462 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -390,11 +390,19 @@ case

[GitHub] incubator-carbondata issue #547: [CARBONDATA-656]Simplify the carbon session...

2017-01-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/547 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #547: [CARBONDATA-656]Simplify the carbon session...

2017-01-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/547 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #549: CARBONDATA-561 delete duplicated code in sp...

2017-01-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/549 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #540: [CARBONDATA-654] Add data update and...

2017-01-18 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/540#discussion_r96595675 --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala --- @@ -0,0 +1,81

[GitHub] incubator-carbondata issue #547: [CARBONDATA-656]Simplify the carbon session...

2017-01-17 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/547 please update SparkSessionExample also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-carbondata pull request #547: [CARBONDATA-656]Simplify the carbon ...

2017-01-17 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/547#discussion_r96579044 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/test/Spark2TestQueryExecutor.scala --- @@ -53,9 +52,7 @@ object

[GitHub] incubator-carbondata pull request #547: [CARBONDATA-656]Simplify the carbon ...

2017-01-17 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/547#discussion_r96579008 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala --- @@ -53,11 +43,8 @@ object

[GitHub] incubator-carbondata issue #545: [CARBONDATA-476][CARBONDATA-644]Added suppo...

2017-01-17 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/545 verified, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-carbondata issue #543: [CARBONDATA-619] give error if compaction t...

2017-01-17 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/543 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #537: fix unapproved licenses

2017-01-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/537 @QiangCai Please keep consistent with scala file header(same with spark) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-carbondata issue #532: [CARBONDATA-638] Move package in carbon-cor...

2017-01-16 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/532 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata issue #532: [CARBONDATA-638] Move package in carbon-cor...

2017-01-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/532 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata issue #538: Multiline is not used now

2017-01-15 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/538 please raise one JIRA issue and modify PR title accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-carbondata issue #537: fix unapproved licenses

2017-01-14 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/537 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #537: fix unapproved licenses

2017-01-14 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/537#discussion_r96131657 --- Diff: pom.xml --- @@ -439,15 +439,22 @@ **/*.csv **/*.dictionary

[GitHub] incubator-carbondata issue #510: Document update for UID

2017-01-14 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/510 @jackylk agree. is better to add Update and Delete description in a separate document, it is easier for the target user to find this document --- If your project is set up

[GitHub] incubator-carbondata pull request #534: [CARBONDATA-632] Fix wrong comments ...

2017-01-13 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/534 [CARBONDATA-632] Fix wrong comments of load data in CarbonDataRDDFactory.scala Fix wrong comments of load data in CarbonDataRDDFactory.scala: 1.Currently, not use

[GitHub] incubator-carbondata issue #530: fix default profile for spark-common-test

2017-01-12 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/530 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #522: Update carbondata description and cl...

2017-01-11 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/522 Update carbondata description and clean .pdf files 1.Update CarbonData description, to keep consistent with apache.org 2.Clean .pdf files in github, the meetup material

[GitHub] incubator-carbondata issue #519: Update description,keep consistent with apa...

2017-01-11 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/519 Close this PR, create a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-carbondata pull request #519: Update description,keep consistent w...

2017-01-11 Thread chenliang613
Github user chenliang613 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-carbondata pull request #519: Update description,keep consistent w...

2017-01-10 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/519#discussion_r95519112 --- Diff: README.md --- @@ -19,10 +19,7 @@ -Apache CarbonData(incubating) is a new big data file format for faster

[GitHub] incubator-carbondata pull request #519: Update description,keep consistent w...

2017-01-10 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/519 Update description,keep consistent with apache.org Update description,keep consistent with apache.org You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-carbondata issue #513: [CARBONDATA-618] Added new profile to build...

2017-01-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/513 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #516: Update build command

2017-01-10 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/516 Update build command Update build command. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata

[GitHub] incubator-carbondata pull request #513: [WIP] Added new profile to build all...

2017-01-10 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/513#discussion_r95326026 --- Diff: examples/spark2/pom.xml --- @@ -27,9 +27,12 @@ carbondata-examples-spark2 - Apache CarbonData :: Spark2

[GitHub] incubator-carbondata issue #514: [CARBONDATA-614]Fix issue: Dictionary file ...

2017-01-10 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/514 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #515: Remove the duplicated class CarbonDa...

2017-01-10 Thread chenliang613
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/515 Remove the duplicated class CarbonDataWriterException.java Remove the duplicated class CarbonDataWriterException.java [1] [1

[GitHub] incubator-carbondata issue #508: [CARBONDATA-611] Make the default maven com...

2017-01-09 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/508 please delete the below duplicated properties: spark-1.5 true -- delete 1.5.2 --delete 2.10 --delete

[GitHub] incubator-carbondata issue #495: [CARBONDATA-570] clean up carbon-hadoop mod...

2017-01-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/495 @jackylk please squash into one commit, i could not merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-carbondata issue #504: [CARBONDATA-606] Add Flink example to read ...

2017-01-08 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/504 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-carbondata pull request #504: [CARBONDATA-606] Add Flink example t...

2017-01-08 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/504#discussion_r95092681 --- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/DatasourceExample.scala --- @@ -37,5 +37,8 @@ object

[GitHub] incubator-carbondata pull request #504: [CARBONDATA-606] Add Flink example t...

2017-01-08 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/504#discussion_r95092537 --- Diff: pom.xml --- @@ -347,6 +347,16 @@ + flink + +1.1.3 --- End diff

[GitHub] incubator-carbondata pull request #504: [CARBONDATA-606] Add Flink example t...

2017-01-08 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/504#discussion_r95092470 --- Diff: examples/flink/pom.xml --- @@ -0,0 +1,76 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w

<    1   2   3   >