[GitHub] incubator-carbondata issue #459: [CARBONDATA-558] Fix load performace issue ...

2016-12-26 Thread foryou2030
Github user foryou2030 commented on the issue: https://github.com/apache/incubator-carbondata/pull/459 @manishgupta88 , yes , I compared the code of new flow with the kettle flow, and found the difference. We can check the method populateOutputRow in class

[GitHub] incubator-carbondata pull request #455: [CARBONDATA-554] Fix check style

2016-12-23 Thread foryou2030
Github user foryou2030 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-carbondata issue #455: [CARBONDATA-554] Fix check style

2016-12-23 Thread foryou2030
Github user foryou2030 commented on the issue: https://github.com/apache/incubator-carbondata/pull/455 ok, closed. @ravipesala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-carbondata pull request #459: [CARBONDATA-558] Fix load performace...

2016-12-23 Thread foryou2030
GitHub user foryou2030 opened a pull request: https://github.com/apache/incubator-carbondata/pull/459 [CARBONDATA-558] Fix load performace when use_kettle=false Why raise this pr? When I load a data file, the measure column contains many empty strings, if use_kettle=false, the

[GitHub] incubator-carbondata pull request #458: [CARBONDATA-557] Fix use_kettle not ...

2016-12-23 Thread foryou2030
GitHub user foryou2030 opened a pull request: https://github.com/apache/incubator-carbondata/pull/458 [CARBONDATA-557] Fix use_kettle not working # Why raise this pr? when run command: LOAD DATA LOCAL INPATH '/path/data.csv' into table t3 OPTIONS('USE

[GitHub] incubator-carbondata pull request #455: [CARBONDATA-554] Fix check style

2016-12-22 Thread foryou2030
GitHub user foryou2030 opened a pull request: https://github.com/apache/incubator-carbondata/pull/455 [CARBONDATA-554] Fix check style # Why raise this pr? It seems that the CI don't check style at present. when run command "mvn clean install -DskipTests"

[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

2016-12-18 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/310#discussion_r92961704 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/TableDictionaryGenerator.java --- @@ -0,0 +1,110

[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

2016-12-18 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/310#discussion_r92961683 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/DictionaryGeneratorForServer.java --- @@ -0,0 +1,71

[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

2016-12-18 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/310#discussion_r92959768 --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/CarbonTable.java --- @@ -504,4 +521,19 @@ public void

[GitHub] incubator-carbondata issue #310: [CARBONDATA-401] One Pass Load

2016-12-15 Thread foryou2030
Github user foryou2030 commented on the issue: https://github.com/apache/incubator-carbondata/pull/310 @jackylk, pls review it, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-carbondata issue #436: [CARBONDATA-532] [WIP] fix bigdecimal compr...

2016-12-14 Thread foryou2030
Github user foryou2030 commented on the issue: https://github.com/apache/incubator-carbondata/pull/436 @jackylk yes, duplicated , i will closed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-carbondata pull request #436: [CARBONDATA-532] [WIP] fix bigdecima...

2016-12-14 Thread foryou2030
Github user foryou2030 closed the pull request at: https://github.com/apache/incubator-carbondata/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-carbondata pull request #436: [CARBONDATA-532] [WIP] fix bigdecima...

2016-12-14 Thread foryou2030
Github user foryou2030 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/436#discussion_r92528784 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala --- @@ -436,17 +436,17 @@ case

[GitHub] incubator-carbondata issue #436: [CARBONDATA-532] [WIP] fix bigdecimal compr...

2016-12-14 Thread foryou2030
Github user foryou2030 commented on the issue: https://github.com/apache/incubator-carbondata/pull/436 ready to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-carbondata pull request #436: fix bigdecimal compression issues wh...

2016-12-14 Thread foryou2030
GitHub user foryou2030 opened a pull request: https://github.com/apache/incubator-carbondata/pull/436 fix bigdecimal compression issues when use_kettle=false Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure

[GitHub] incubator-carbondata pull request #:

2016-12-11 Thread foryou2030
Github user foryou2030 commented on the pull request: https://github.com/apache/incubator-carbondata/commit/6c9194d97c54351434866f423ef44907b887ae5a#commitcomment-20151330 In integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala: In