[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-16 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101462875 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java --- @@ -39,11 +39,13 @@ * Sorts the

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101460125 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java --- @@ -39,11 +39,13 @@ * Sorts the

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101443741 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java --- @@ -39,11 +39,13 @@ * Sorts the

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436963 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -375,6 +376,9 @@

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436969 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java --- @@ -116,8

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432953 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java --- @@ -116,8

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-15 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432584 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java --- @@ -86,11 +88,10

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721876 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java --- @@ -375,6 +376,9 @@

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721771 --- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java --- @@ -116,8

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721427 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java --- @@ -86,11

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100721258 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -641,7 +641,7 @@ /** *

[GitHub] incubator-carbondata pull request #594: [CARBONDATA-701]Fix memory leak issu...

2017-02-12 Thread chenliang613
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/594#discussion_r100695668 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/row/CarbonRowBatch.java --- @@ -17,27 +17,40 @@