Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mayunSaicmotor commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105550419
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -96,13 +93,39
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105549626
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -96,13 +93,39 @@
Github user mayunSaicmotor commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548693
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -41,21 +41,20
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548337
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23 @@
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548338
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23 @@
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548334
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -41,21 +41,20 @@
GitHub user mayunSaicmotor opened a pull request:
https://github.com/apache/incubator-carbondata/pull/649
[CARBONDATA-748] put 'if' clause out of the 'for' clause and add test case
put the 'if' clause out of the 'for' clause to avoid to execute too many
'if' clause and improve
