[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai closed the pull request at: https://github.com/apache/incubator-carbondata/pull/722 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867883 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/NoSortProcessorStepImpl.java --- @@ -0,0 +1,123 @@ +/*

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867759 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/btree/BTreeDataRefNodeFinder.java --- @@ -51,16 +51,15 @@ /**

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867836 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -490,8 +490,20 @@ abstract c

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867776 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -54,6 +54,8 @@ */ priva

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-05 Thread QiangCai
Github user QiangCai commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109867805 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala --- @@ -154,6

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-04 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815736 --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/steps/NoSortProcessorStepImpl.java --- @@ -0,0 +1,123 @@ +/*

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-04 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815428 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -490,8 +490,20 @@ abstract cl

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-04 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815295 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala --- @@ -154,6

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-04 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109815081 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java --- @@ -54,6 +54,8 @@ */ privat

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-04 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/722#discussion_r109814360 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/btree/BTreeDataRefNodeFinder.java --- @@ -51,16 +51,15 @@ /**

[GitHub] incubator-carbondata pull request #722: [CARBONDATA-782]support unsorted tab...

2017-04-02 Thread QiangCai
GitHub user QiangCai opened a pull request: https://github.com/apache/incubator-carbondata/pull/722 [CARBONDATA-782]support unsorted table (when SORT_COLUMNS is empty) When SORT_COLUMNS of a table is empty or the table doesn't have dimensions(besides complex type column), this tabl