Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101460125
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432953
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436969
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/IntermediateFileMerger.java
---
@@ -116,8
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101436963
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortDataRows.java
---
@@ -375,6 +376,9
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101462875
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/Sorter.java
---
@@ -39,11 +39,13 @@
* Sorts
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/596
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/594#discussion_r101432584
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/sort/impl/ParallelReadMergeSorterImpl.java
---
@@ -86,11 +88,10
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/539
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96129390
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +782,47 @@ case class
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r96129389
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
---
@@ -194,28 +196,25 @@ public boolean
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/537
@ravipesala
already added header check to java stype
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/537
@chenliang613
java's license header is the same with scala's.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/537#discussion_r96141120
--- Diff: pom.xml ---
@@ -439,15 +439,22 @@
**/*.csv
**/*.dictionary
**/*.ktr
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/537
@chenliang613 @jackylk @ravipesala
now the license header of Java file is different with the license header of
Scala file.
Which one we should choose?
java file
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/537
I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/217
close this pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/285
@ashokblend please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/360
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/278
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/682/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/363
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/278#discussion_r89950862
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/csvreaderstep/CsvInput.java
---
@@ -384,21 +383,75 @@ public boolean
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/278#discussion_r89950872
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -932,7 +942,8 @@ object
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/278#discussion_r89950829
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataLoadRDD.scala
---
@@ -548,77 +552,53 @@ class
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/278#discussion_r88588734
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -164,4 +165,53 @@ object
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/278
Rebase done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/366
please rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/413
[CARBONDATA-516][SPARK2]fix union issue in CarbonLateDecoderRule
In spark2, Union class is no longer the sub-class of BinaryNode. We need
fix union issue in CarbonLateDecoderRule
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/339#discussion_r92332659
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/dictionary/ReverseDictionaryCache.java
---
@@ -167,12 +167,9 @@ private
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/411
@ravipesala
Please correct CI to support -Pbuild-with-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/413
@jackylk
Added test case
Local test case pass for spark1.5 and spark2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/439
[CARBONDATA-536]initialize updateTableMetadata method in LoadTable for
Spark2
For spark2, GlobalDictionaryUtil.updateTableMetadataFunc should been
initialized
You can merge
Github user QiangCai closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/345
Close this PR. In the future, I will raise another PR to support mixed data
format table.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/518
[WIP]unify file header reader
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/incubator-carbondata fileheader
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/524#discussion_r95714873
--- Diff:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/allqueries/AllDataTypesTestCaseAggregate.scala
---
@@ -59,21
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/524
[CARBONDATA-627]fix union test case for spark2
Analyze:
Union test case failed in spark2. The result of union query is twice of the
result of left query.
Root Cause
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/520
close this pr. I didn't reproduce this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/518#discussion_r95518312
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -301,4 +304,45 @@ object
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/518#discussion_r95518311
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -373,83 +368,15 @@ private
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/518#discussion_r95518309
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
---
@@ -462,6 +389,13 @@ public static
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/530
fix default profile for spark-common-test
now the profile spark-1.6 should be active by default.
You can merge this pull request into a Git repository by running:
$ git pull
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
@ravipesala
ok, no conflict, just need do rebase.
PR528 is for kettle flow in spark2 and move test case to spark-common-test.
---
If your project is set up for it, you can
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/529
@ravipesala
In PR 528, I fixed InsertInto issue for kettle flow and move test case to
spark-common-test.
---
If your project is set up for it, you can reply to this email
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973885
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/optimizer/CarbonOptimizer.scala
---
@@ -237,9 +237,15 @@ class
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/528#discussion_r95973907
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetastore.scala
---
@@ -782,7 +781,49 @@ case class
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/514
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/514
[CARBONDATA-614]Fix issue: Dictionary file name is locked for updation.
1. set carbon property CarbonCommonConstants.STORE_LOCATION for
CarbonBlockDistinctValuesCombineRDD
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/520
fix dependency issue for IntelliJ IDEA
When using profile spark-2.1, can not run test case of spark-common-test in
IntelliJ IDEA.
You can merge this pull request into a Git
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/518#discussion_r95507937
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -301,4 +304,45 @@ object
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/528
Fix InsertInto test case for spark2
Changes:
1. move insertInto test case to spark-common-test module from spark module
2. add test case: insert into carbon table from
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/390
[CARBONDATA-492]fix a bug of profile spark-2.0 for intellij idea
When profile spark-2.0 is chosen , CarbonExample have error in Intellij idea
You can merge this pull request
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/377
[CARBONDATA-478]Spark2 module should have different SparkRowReadSupportImpl
with spark1
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/384
[CARBONDATA-488][SPARK2]add InsertInto feature for spark2
1. add InsertInto feature for spark2
2. optimize CarbonExample to use relation path
And use InsertInto
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/382
[CARBONDATA-486]fix bug for reading dataframe concurrently
Fix a insertinto bug for reading from hive table concurrently
You can merge this pull request into a Git repository
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/403
[CARBONDATA-497][SPARK2]fix datatype issue of CarbonLateDecoderRule
1. Fix the data type of dictionary dimension to resolve the logical plan
2. Perfect translateFilter
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/472#discussion_r94367280
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/499
[CARBONDATA-218]fix data loading issue for UT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/incubator-carbondata
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/450
@kumarvishal09
please rebase and fix some known issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060180
--- Diff: integration/spark-common-test/pom.xml ---
@@ -0,0 +1,232 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/481#discussion_r95060705
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/test/TestQueryExecutorImplV1.scala
---
@@ -0,0 +1,51
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/508
@ravipesala
In my opinion, If some profile is active by default and only contains some
property elements, we can remove this profile and add these property elements
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/508
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/481
[WIP]reuse test case for integration module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/incubator-carbondata
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/494
[CARBONDATA-218]Using CSVInputFormat instead of spark-csv during dictionary
geneartion
1. Using CSVInputFormat instead of spark-csv during dictionary geneartion
2. Remove
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/494#discussion_r94545504
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -356,37 +363,49
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/481
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/481
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/452#discussion_r93733275
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/util/TableAPIUtil.scala ---
@@ -51,4 +56,15 @@ object TableAPIUtil
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/452#discussion_r93733676
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/util/TableAPIUtil.scala ---
@@ -51,4 +56,15 @@ object TableAPIUtil
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/449
@chenliang613 @jackylk
Rebase done and fixed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107841211
--- Diff: dev/java-code-format-template.xml ---
@@ -34,8 +34,8
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107890848
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonOutputFormat.java
---
@@ -0,0 +1,49
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863484
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
@@ -0,0 +1,191
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863410
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
@@ -0,0 +1,191
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107881262
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java
---
@@ -0,0 +1,249
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862824
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
@@ -0,0 +1,191
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107873741
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -0,0 +1,99
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107893281
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -0,0 +1,99
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107875522
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveRecordReader.java
---
@@ -0,0 +1,249
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107863523
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
@@ -0,0 +1,191
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107894484
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -0,0 +1,99
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107862312
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonArrayInspector.java
---
@@ -0,0 +1,191
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/672#discussion_r107886267
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/CarbonHiveSerDe.java
---
@@ -0,0 +1,232 @@
+/*
+ * Licensed
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/659#discussion_r108033699
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndex.java
---
@@ -16,30 +16,52 @@
*/
package
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/659#discussion_r108146058
--- Diff:
core/src/test/java/org/apache/carbondata/core/datastore/block/SegmentTaskIndexTest.java
---
@@ -58,7 +58,9 @@
@Mock
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/635
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user QiangCai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/715
[CARBONDATA-782]support SORT_COLUMNS
The tasks of SORT_COLUMNS:
Support create table with sort_columns property.
e.g. tblproperties('sort_columns' = 'col7,col3
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/635
close this pr.
I will raise another pr to merge to 12-dev branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user QiangCai closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/659
@kumarvishal09 dump picture is driver tree.
@watermen this pr only implement to reuse segment properties in driver
side. can you try to do it in executor side? About the building
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/715
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/691
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/691
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/696
@watermen
It is unnecessary to store carbondata file path in carbonindex file.
During btree building, just use carbondata file name to sort
tableblockinfos.
please check
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/697#discussion_r107920260
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala
---
@@ -111,16 +111,24 @@ object
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/697#discussion_r107919139
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala
---
@@ -111,16 +111,24 @@ object
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/697#discussion_r107918771
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/CarbonFilters.scala
---
@@ -111,16 +111,24 @@ object
Github user QiangCai commented on the issue:
https://github.com/apache/incubator-carbondata/pull/694
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
1 - 100 of 205 matches
Mail list logo
