[jira] [Commented] (CARBONDATA-292) add COLUMNDICT operation info in DML operation guide
[ https://issues.apache.org/jira/browse/CARBONDATA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15579123#comment-15579123 ] ASF GitHub Bot commented on CARBONDATA-292: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-carbondata/pull/223 > add COLUMNDICT operation info in DML operation guide > > > Key: CARBONDATA-292 > URL: https://issues.apache.org/jira/browse/CARBONDATA-292 > Project: CarbonData > Issue Type: Improvement >Reporter: Jay >Priority: Minor > > there is no COLUMNDICT operation guide in DML-Operations-on-Carbon.md, so > need to add. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-292) add COLUMNDICT operation info in DML operation guide
[ https://issues.apache.org/jira/browse/CARBONDATA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571797#comment-15571797 ] ASF GitHub Bot commented on CARBONDATA-292: --- Github user Jay357089 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/223#discussion_r83205716 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -104,8 +109,10 @@ Following are the options that can be used in load data: 'MULTILINE'='true', 'ESCAPECHAR'='\', 'COMPLEX_DELIMITER_LEVEL_1'='$', 'COMPLEX_DELIMITER_LEVEL_2'=':', - 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary' + 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary', + 'COLUMNDICT'='empno:/dictFilePath/empnoDict.csv, empname:/dictFilePath/empnameDict.csv' --- End diff -- done. > add COLUMNDICT operation info in DML operation guide > > > Key: CARBONDATA-292 > URL: https://issues.apache.org/jira/browse/CARBONDATA-292 > Project: CarbonData > Issue Type: Improvement >Reporter: Jay >Priority: Minor > > there is no COLUMNDICT operation guide in DML-Operations-on-Carbon.md, so > need to add. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-292) add COLUMNDICT operation info in DML operation guide
[ https://issues.apache.org/jira/browse/CARBONDATA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570540#comment-15570540 ] ASF GitHub Bot commented on CARBONDATA-292: --- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/223#discussion_r83133189 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -104,8 +109,10 @@ Following are the options that can be used in load data: 'MULTILINE'='true', 'ESCAPECHAR'='\', 'COMPLEX_DELIMITER_LEVEL_1'='$', 'COMPLEX_DELIMITER_LEVEL_2'=':', - 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary' + 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary', + 'COLUMNDICT'='empno:/dictFilePath/empnoDict.csv, empname:/dictFilePath/empnameDict.csv' --- End diff -- No, I mean just delete it from the Example section. And that node should be added in the option expanation section. > add COLUMNDICT operation info in DML operation guide > > > Key: CARBONDATA-292 > URL: https://issues.apache.org/jira/browse/CARBONDATA-292 > Project: CarbonData > Issue Type: Improvement >Reporter: Jay >Priority: Minor > > there is no COLUMNDICT operation guide in DML-Operations-on-Carbon.md, so > need to add. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-292) add COLUMNDICT operation info in DML operation guide
[ https://issues.apache.org/jira/browse/CARBONDATA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570512#comment-15570512 ] ASF GitHub Bot commented on CARBONDATA-292: --- Github user Jay357089 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/223#discussion_r83132221 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -104,8 +109,10 @@ Following are the options that can be used in load data: 'MULTILINE'='true', 'ESCAPECHAR'='\', 'COMPLEX_DELIMITER_LEVEL_1'='$', 'COMPLEX_DELIMITER_LEVEL_2'=':', - 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary' + 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary', + 'COLUMNDICT'='empno:/dictFilePath/empnoDict.csv, empname:/dictFilePath/empnameDict.csv' --- End diff -- i have give Note in the below. if it is not enough, should i delete this option or close this pr? > add COLUMNDICT operation info in DML operation guide > > > Key: CARBONDATA-292 > URL: https://issues.apache.org/jira/browse/CARBONDATA-292 > Project: CarbonData > Issue Type: Improvement >Reporter: Jay >Priority: Minor > > there is no COLUMNDICT operation guide in DML-Operations-on-Carbon.md, so > need to add. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CARBONDATA-292) add COLUMNDICT operation info in DML operation guide
[ https://issues.apache.org/jira/browse/CARBONDATA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568937#comment-15568937 ] ASF GitHub Bot commented on CARBONDATA-292: --- Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/223#discussion_r83022245 --- Diff: docs/DML-Operations-on-Carbon.md --- @@ -104,8 +109,10 @@ Following are the options that can be used in load data: 'MULTILINE'='true', 'ESCAPECHAR'='\', 'COMPLEX_DELIMITER_LEVEL_1'='$', 'COMPLEX_DELIMITER_LEVEL_2'=':', - 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary' + 'ALL_DICTIONARY_PATH'='/opt/alldictionary/data.dictionary', + 'COLUMNDICT'='empno:/dictFilePath/empnoDict.csv, empname:/dictFilePath/empnameDict.csv' --- End diff -- do not give this option since it can not be used together with `ALL_DICTIONARY_PATH` > add COLUMNDICT operation info in DML operation guide > > > Key: CARBONDATA-292 > URL: https://issues.apache.org/jira/browse/CARBONDATA-292 > Project: CarbonData > Issue Type: Improvement >Reporter: Jay >Priority: Minor > > there is no COLUMNDICT operation guide in DML-Operations-on-Carbon.md, so > need to add. -- This message was sent by Atlassian JIRA (v6.3.4#6332)