[GitHub] incubator-carbondata pull request #336: [CARBONDATA-426] replace if else wit...

2016-12-13 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/336#discussion_r92122165 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/merger/CarbonCompactionUtil.java --- @@ -142,20 +142,15 @@

[GitHub] incubator-carbondata pull request #336: [CARBONDATA-426] replace if else wit...

2016-12-01 Thread PallaviSingh1992
Github user PallaviSingh1992 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/336#discussion_r90590085 --- Diff: integration/spark-common/src/main/java/org/apache/carbondata/spark/merger/CarbonCompactionUtil.java --- @@ -142,20 +142,14

[GitHub] incubator-carbondata pull request #336: [CARBONDATA-426] replace if else wit...

2016-11-20 Thread PallaviSingh1992
GitHub user PallaviSingh1992 opened a pull request: https://github.com/apache/incubator-carbondata/pull/336 [CARBONDATA-426] replace if else with conditional operator Replaced the if-else with Conditional operator. Reduced the number of variables used. Reduced the boiler