[jira] [Commented] (CARBONDATA-362) Optimize the parameters' name in CarbonDataRDDFactory.scala

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631315#comment-15631315
 ] 

ASF GitHub Bot commented on CARBONDATA-362:
---

Github user Hexiaoqiao commented on a diff in the pull request:

https://github.com/apache/incubator-carbondata/pull/281#discussion_r86279989
  
--- Diff: 
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
 ---
@@ -65,7 +65,7 @@ object CarbonDataRDDFactory extends Logging {
   sqlContext: SQLContext,
   carbonLoadModel: CarbonLoadModel,
   storeLocation: String,
-  hdfsStoreLocation: String,
+  StoreLocation: String,
--- End diff --

pls follow the code style and use lowercase character of variable.


> Optimize the parameters' name in CarbonDataRDDFactory.scala
> ---
>
> Key: CARBONDATA-362
> URL: https://issues.apache.org/jira/browse/CARBONDATA-362
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Liang Chen
>Assignee: He Xiaoqiao
>Priority: Trivial
>
> Optimize the parameters' name in CarbonDataRDDFactory.scala:
> changes the name of "hdfsStoreLocation"  to "storePath", because not only 
> support hdfs path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CARBONDATA-362) Optimize the parameters' name in CarbonDataRDDFactory.scala

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CARBONDATA-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631110#comment-15631110
 ] 

ASF GitHub Bot commented on CARBONDATA-362:
---

GitHub user lion-x opened a pull request:

https://github.com/apache/incubator-carbondata/pull/281

[CARBONDATA-362]Optimize the Parameters Name in CarbonDataRDDFactory.scala

# Why raise this PR?
changes the name of "hdfsStoreLocation" to "storePath", because not only 
support hdfs path.

# How to test?
Pass all test cases.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lion-x/incubator-carbondata 
optimizeParametersName

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-carbondata/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit ef50982ee53929d67b3e58d57d7a05a46a8a2ba8
Author: lion-x 
Date:   2016-11-03T01:02:31Z

optimizeParametersName




> Optimize the parameters' name in CarbonDataRDDFactory.scala
> ---
>
> Key: CARBONDATA-362
> URL: https://issues.apache.org/jira/browse/CARBONDATA-362
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Liang Chen
>Priority: Trivial
>
> Optimize the parameters' name in CarbonDataRDDFactory.scala:
> changes the name of "hdfsStoreLocation"  to "storePath", because not only 
> support hdfs path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)