[ https://issues.apache.org/jira/browse/CLOUDSTACK-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rohit Yadav closed CLOUDSTACK-7332. ----------------------------------- commit 9b97077d3bb22d53d116981ea11675f1aaafcfc1 Author: Rohit Yadav <rohit.ya...@shapeblue.com> Date: Wed Aug 13 11:42:02 2014 +0200 CLOUDSTACK-7332: handle cloudmonkey installation for windows Checks and appends pyreadline or readline to dependencies based on platform Signed-off-by: Rohit Yadav <rohit.ya...@shapeblue.com> > CloudMonkey setup.py undefined variable 'requires' > -------------------------------------------------- > > Key: CLOUDSTACK-7332 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7332 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Cloudmonkey > Environment: Windows 8.1, cmd.exe, python 2.7.8, pip 1.5.6 > Reporter: Scott Trotter > Assignee: Rohit Yadav > Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > I'm setting up a Windows system to see how effective (or not) it is for FOSS > development. I installed the following components, in order, one right after > another, using cmd.exe CLI, not PowerShell or Git Bash: > Github for Windows 2.2.0.0 > Python (x64) 2.7.8 > ez_setup.py > get-pip.py > pip install cloudmonkey > The latter resulted in the following error, which I copied from pip.log: > File "e:\temp\pip_build_Scott\cloudmonkey\setup.py", line 32, in <module> > requires.append('readline') > NameError: name 'requires' is not defined > I downloaded apache-cloudstack-cloudmonkey-5.1.0-src.tar.bz2 and unpacked it > manually. Here is the problem area, starting with line 29: > try: > import readline > except ImportError: > requires.append('readline') > This test FAILED on my system, but I'm guessing that it typically doesn't > fail on others because readline is typically already installed by the time > someone tries to install CloudMonkey. > I also poked around in the repo, and it's easy to see how this bug got > introduced. In the last commit on Mar. 19, 2013, the maintainer changed the > way that required modules are handled, in part by removing the 'requires' > variable, but missed the try/except clause shown above. It probably remained > undiscovered this long due to my unusual installation sequence. > This should be very simple to fix. I have pip.log if you need it, but I don't > see any way to attach files in this report form. I can email it to you if you > want. > Questions? sc...@trotternet.com -- This message was sent by Atlassian JIRA (v6.2#6252)