[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404132#comment-16404132 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - nvazquez commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374037021 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404140#comment-16404140 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - DaanHoogland commented on a change in pull request #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#discussion_r175301207 ## File path: engine/schema/src/com/cloud/vm/dao/VMInstanceDao.java ## @@ -151,8 +151,5 @@ boolean isPowerStateUpToDate(long instanceId); -/** - * List running VMs which host and lastHost id are the same - */ -List listRunningVmsByHostAndLastHostSameId(long hostId); +List listNonMigratingVmsByHostEqualsLastHost(long hostId); Review comment: hm, that is not very clear, the name is stating cause and conclusion. I suggest listVmsByHostEqualsLastHost() This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404144#comment-16404144 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - blueorangutan commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374039056 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1789 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404147#comment-16404147 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - blueorangutan commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374039392 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404146#comment-16404146 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - nvazquez commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374039341 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10329) Button in ACL rules page to export all rules as a CSV file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404170#comment-16404170 ] ASF GitHub Bot commented on CLOUDSTACK-10329: - rafaelweingartner commented on a change in pull request #2494: [CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file URL: https://github.com/apache/cloudstack/pull/2494#discussion_r175302601 ## File path: ui/scripts/vpc.js ## @@ -15,6 +15,53 @@ // specific language governing permissions and limitations // under the License. (function($, cloudStack) { +var isNumeric = function (n) { +return !isNaN(parseFloat(n)); +}; +var createSafeCsvValue = function(value){ +if(value){ +return '"' + value + '"'; Review comment: @nitin-maharana thanks for the review, but I did not quite understand your question. Here is an example of CSV generated using the code of this PR: ``` "id","#Rule","CIDR","Action","Protocol","#Protocol","Start Port","End Port","ICMP Type","ICMP Code","Traffic Type","Reason" "ef06c57e-dc8b-40d9-a461-5a30072384ab","2","19.168.56.0/12","Allow","all",,"Ingress", "45835dfb-260c-461d-8051-444ac764151e","102","19.168.56.0/12","Allow","tcp",,"1","1",,,"Ingress", ``` I am using this `createSafeCsvValue ` to enclose the value with double quotes, which will avoid problems with values that may have commas in them. If you open the file generated with this code in Excel, it is transparent for users. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Button in ACL rules page to export all rules as a CSV file > --- > > Key: CLOUDSTACK-10329 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10329 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > It is interesting to create a button in the ACL rule listing page to export > all rules in a CSV file. This file can facilitate the auditing and reporting > of rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404153#comment-16404153 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r170873693 ## File path: engine/schema/src/main/java/com/cloud/network/vpc/NetworkACLVO.java ## @@ -101,4 +101,12 @@ public void setVpcId(long vpcId) { public boolean isDisplay() { return display; } + Review comment: if we change a VO, don't we need a schema/table change as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404150#comment-16404150 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r175301471 ## File path: server/src/test/java/com/cloud/network/vpc/NetworkACLServiceImplTest.java ## @@ -64,9 +67,11 @@ @Mock private NetworkACLItemDao networkAclItemDaoMock; @Mock -private EntityManager EntityManagerMock; +private EntityManager entityManagerMock; @Mock -private AccountManager AccountManager; +private AccountManager AccountManagerMock; Review comment: lower case for this var name as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404152#comment-16404152 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r170873027 ## File path: engine/schema/src/main/java/com/cloud/network/vpc/NetworkACLVO.java ## @@ -101,4 +101,11 @@ public void setVpcId(long vpcId) { public boolean isDisplay() { return display; } + Review comment: if the VO changes, don't we need a table change as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404151#comment-16404151 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r175301406 ## File path: engine/schema/src/main/java/com/cloud/network/vpc/NetworkACLVO.java ## @@ -101,4 +101,12 @@ public void setVpcId(long vpcId) { public boolean isDisplay() { return display; } + Review comment: never mind, dumb remark This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404149#comment-16404149 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - DaanHoogland commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r170872694 ## File path: ui/l10n/nl_NL.js ## @@ -313,6 +313,7 @@ var dictionary = { "label.add.accounts": "Voeg accounts toe", "label.add.accounts.to": "Voeg accounts toe aan", "label.add.acl.list": "voeg een ACL lijst toe", +"label.edit.acl.list": "Edit ACL List", Review comment: "verander een ACL lijst" ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10329) Button in ACL rules page to export all rules as a CSV file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404167#comment-16404167 ] ASF GitHub Bot commented on CLOUDSTACK-10329: - nitin-maharana commented on a change in pull request #2494: [CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file URL: https://github.com/apache/cloudstack/pull/2494#discussion_r175302465 ## File path: ui/scripts/vpc.js ## @@ -15,6 +15,53 @@ // specific language governing permissions and limitations // under the License. (function($, cloudStack) { +var isNumeric = function (n) { +return !isNaN(parseFloat(n)); +}; +var createSafeCsvValue = function(value){ +if(value){ +return '"' + value + '"'; Review comment: Hi @rafaelweingartner, Thanks for adding this functionality. Here, Will the input look like this: ("a","b","c"...) or (a,b,c...). The variable csv in generateCsvForAclRules function converts to string when it is initialized (concatenated with a comma string). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Button in ACL rules page to export all rules as a CSV file > --- > > Key: CLOUDSTACK-10329 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10329 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > It is interesting to create a button in the ACL rule listing page to export > all rules in a CSV file. This file can facilitate the auditing and reporting > of rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9975) Allow customizing system VM templates for SSVM and Console Proxy
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404058#comment-16404058 ] ASF GitHub Bot commented on CLOUDSTACK-9975: rafaelweingartner commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-374016298 @GabrielBrascher can you fix the conflicts please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow customizing system VM templates for SSVM and Console Proxy > > > Key: CLOUDSTACK-9975 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9975 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Gabriel Beims Bräscher >Assignee: Gabriel Beims Bräscher >Priority: Minor > > Currently, it is only possible to change the template used by virtual > routers, but other system VMs do not have the same feature. The virtual > router template is configured according to the respective global settings > parameters: router.template.hyperv, router.template.kvm, router.template.lxc, > router.template.xenserver, router.template.ovm, router.template.vmware. > This ticket proposes the configuration of templates for storage system VMs > (SSVMs) and console proxy system VMs with parameters similar with the virtual > router template configuration: ssvm.template. and > consoleproxy.template. > If a parameter is null then it keeps the current flow for that scenario > (systemvm/virtualization tool). > This proposal allows users to customize virtual machines templates according > to specific needs of each system VM. This feature was useful in a practical > scenario where it was necessary to perform some changes for the console proxy > system VM template. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404135#comment-16404135 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - blueorangutan commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374037149 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404123#comment-16404123 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - nvazquez commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374033433 @borisstoyanov @DaanHoogland @rafaelweingartner thanks for reviewing, I made some refactor to prevent cases in which a host state is 'PrepareForMaintenance' forever. Instead of that, when we detect migrations have failed, host state is set to 'ErrorInMaintenance' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10320) Invalid pair for response object breaking response parsing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404154#comment-16404154 ] ASF GitHub Bot commented on CLOUDSTACK-10320: - DaanHoogland commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374039766 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Invalid pair for response object breaking response parsing > -- > > Key: CLOUDSTACK-10320 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10320 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Major > > Under some circumstances, the API is returning an invalid response, for > simplicity I will expose the JSON case. The API response on a > listVirtualMachines can be this string: > {code:java} > { "listvirtualmachinesresponse" : ] } }{code} > To understand how this is possible, assume you have more than one management > server and one is processing the destroy of a virtual machine in the account > X which is the only one it has. Another process is returning the result of > listVirtualMachines for that same account X. During the listVM command, the > result set is fetch with a searchAndDistinctCount due to the view > ([https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L1024).] > This is done through 2 queries in the GenericDao > [https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java#L1323] > and if you encounter the _right_ conditions, the VM will be marked as > removed in between those 2 queries. This results in having a Pair result with > at least one object but a count of 0. Then following how is done the > serialization of the response at > [https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/response/ApiResponseSerializer.java#L86] > you will reach the case where your output is the one previously mentioned. > To overcome this issue, there isn't a true fix but only a better pair > response to ensure a correct response formatting. If the result set contains > at least something, the count cannot be 0 but we cannot guess the correct > answer, but only state it has at least one element. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10320) Invalid pair for response object breaking response parsing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404156#comment-16404156 ] ASF GitHub Bot commented on CLOUDSTACK-10320: - blueorangutan commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374039824 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Invalid pair for response object breaking response parsing > -- > > Key: CLOUDSTACK-10320 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10320 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Major > > Under some circumstances, the API is returning an invalid response, for > simplicity I will expose the JSON case. The API response on a > listVirtualMachines can be this string: > {code:java} > { "listvirtualmachinesresponse" : ] } }{code} > To understand how this is possible, assume you have more than one management > server and one is processing the destroy of a virtual machine in the account > X which is the only one it has. Another process is returning the result of > listVirtualMachines for that same account X. During the listVM command, the > result set is fetch with a searchAndDistinctCount due to the view > ([https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L1024).] > This is done through 2 queries in the GenericDao > [https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java#L1323] > and if you encounter the _right_ conditions, the VM will be marked as > removed in between those 2 queries. This results in having a Pair result with > at least one object but a count of 0. Then following how is done the > serialization of the response at > [https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/response/ApiResponseSerializer.java#L86] > you will reach the case where your output is the one previously mentioned. > To overcome this issue, there isn't a true fix but only a better pair > response to ensure a correct response formatting. If the result set contains > at least something, the count cannot be 0 but we cannot guess the correct > answer, but only state it has at least one element. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404162#comment-16404162 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - rafaelweingartner commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r175302141 ## File path: server/src/test/java/com/cloud/network/vpc/NetworkACLServiceImplTest.java ## @@ -64,9 +67,11 @@ @Mock private NetworkACLItemDao networkAclItemDaoMock; @Mock -private EntityManager EntityManagerMock; +private EntityManager entityManagerMock; @Mock -private AccountManager AccountManager; +private AccountManager AccountManagerMock; Review comment: Sure, it was a case of "ctrl+v" fail This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404163#comment-16404163 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - rafaelweingartner commented on a change in pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#discussion_r175302160 ## File path: ui/l10n/nl_NL.js ## @@ -313,6 +313,7 @@ var dictionary = { "label.add.accounts": "Voeg accounts toe", "label.add.accounts.to": "Voeg accounts toe aan", "label.add.acl.list": "voeg een ACL lijst toe", +"label.edit.acl.list": "Edit ACL List", Review comment: Thanks ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404165#comment-16404165 ] ASF GitHub Bot commented on CLOUDSTACK-10301: - rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-374041632 @DaanHoogland I applied your suggestions, but I did not understand what you said about "annotations API" and audit trail. Could you explain that further? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow updating the network ACL list name and Description > - > > Key: CLOUDSTACK-10301 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > Currently, it is not possible to update the Network ACL name or Description > of an ACL after it has been created. It might be interesting to expose this > option via API and to add this feature to the UI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10326) Prevent hosts fall into Maintenance when there are running VMs on it
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404403#comment-16404403 ] ASF GitHub Bot commented on CLOUDSTACK-10326: - blueorangutan commented on issue #2493: CLOUDSTACK-10326: Prevent hosts fall into Maintenance when there are running VMs on it URL: https://github.com/apache/cloudstack/pull/2493#issuecomment-374107910 Trillian test result (tid-2387) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33658 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2493-t2387-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 65 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 607.91 | test_vpc_redundant.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.82 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prevent hosts fall into Maintenance when there are running VMs on it > > > Key: CLOUDSTACK-10326 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10326 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Nicolas Vazquez >Assignee: Nicolas Vazquez >Priority: Major > Fix For: 4.11.1.0 > > Attachments: CLOUDSTACK-10326-Debug.png, > CLOUDSTACK-10326-InitialState.png, CLOUDSTACK-10326-Migrating.png, > CLOUDSTACK-10326-MigrationFailed.png > > > This issue was discovered, fixed and tested on KVM, but applies for every > hypervisor. > h2. Background > When enabling maintenance mode in a host, host state is put into > 'PrepareForMaintenance' and running VMs are migrated into another host. After > every VM is migrated, host goes to 'Maintenance' state. > Checks are performed on ResourceManagerImpl.checkAndMaintan() method: > * List VMs with host_id = HOST_ID > * List VMs with last_host_id = HOST_ID and state=Migrating > When both queries are empty, then the host can be put into Maintenance. > When a VM is being migrated to DEST_HOST, its host_id column is set to > DEST_HOST, last_host_id = ORIGIN_HOST and state = Migrating. If then > migration fails, host_id = last_host_id = ORIGIN_HOST > h2. Issue > This sequence: > * Enable maintenance mode on ORIGIN_HOST > * VMs start being migrated to a host, say DEST_HOST > * checkAndMaintain() starts: > ** First check passes (no VM with host_id = ORIGIN_HOST_ID as those are > being migrated) > ** Before the second check, one or more migrations fail > ** Second check passes, however there are VMs running on the host as > migrations have failed. > * Host goes into Maintenance state. > Screenshots attached, query executed on each case: > select id, name, instance_name, state, host_id, last_host_id from vm_instance; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10329) Button in ACL rules page to export all rules as a CSV file
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404363#comment-16404363 ] ASF GitHub Bot commented on CLOUDSTACK-10329: - nitin-maharana commented on issue #2494: [CLOUDSTACK-10329] Button in ACL rules page to export all rules as a CSV file URL: https://github.com/apache/cloudstack/pull/2494#issuecomment-374098031 Code LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Button in ACL rules page to export all rules as a CSV file > --- > > Key: CLOUDSTACK-10329 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10329 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > Fix For: 4.12 > > > It is interesting to create a button in the ACL rule listing page to export > all rules in a CSV file. This file can facilitate the auditing and reporting > of rules. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10320) Invalid pair for response object breaking response parsing
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404401#comment-16404401 ] ASF GitHub Bot commented on CLOUDSTACK-10320: - blueorangutan commented on issue #2481: CLOUDSTACK-10320 - Invalid pair for response object breaking response parsing URL: https://github.com/apache/cloudstack/pull/2481#issuecomment-374107511 Trillian test result (tid-2388) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33025 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2481-t2388-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 128.45 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 138.31 | test_volumes.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 484.70 | test_vpc_redundant.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.86 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Invalid pair for response object breaking response parsing > -- > > Key: CLOUDSTACK-10320 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10320 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Reporter: Marc-Aurèle Brothier >Assignee: Marc-Aurèle Brothier >Priority: Major > > Under some circumstances, the API is returning an invalid response, for > simplicity I will expose the JSON case. The API response on a > listVirtualMachines can be this string: > {code:java} > { "listvirtualmachinesresponse" : ] } }{code} > To understand how this is possible, assume you have more than one management > server and one is processing the destroy of a virtual machine in the account > X which is the only one it has. Another process is returning the result of > listVirtualMachines for that same account X. During the listVM command, the > result set is fetch with a searchAndDistinctCount due to the view > ([https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java#L1024).] > This is done through 2 queries in the GenericDao > [https://github.com/apache/cloudstack/blob/master/framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java#L1323] > and if you encounter the _right_ conditions, the VM will be marked as > removed in between those 2 queries. This results in having a Pair result with > at least one object but a count of 0. Then following how is done the > serialization of the response at > [https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/response/ApiResponseSerializer.java#L86] > you will reach the case where your output is the one previously mentioned. > To overcome this issue, there isn't a true fix but only a better pair > response to ensure a correct response formatting. If the result set contains > at least something, the count cannot be 0 but we cannot guess the correct > answer, but only state it has at least one element. -- This message was sent by Atlassian JIRA (v7.6.3#76005)