[jira] [Created] (CLOUDSTACK-10256) When using ConfigDrive, Cannot deploy vm after rebooting the management server.
Yusei Nishioka created CLOUDSTACK-10256: --- Summary: When using ConfigDrive, Cannot deploy vm after rebooting the management server. Key: CLOUDSTACK-10256 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10256 Project: CloudStack Issue Type: Bug Affects Versions: 4.11.0.0 Environment: CentOS7 Management server, vSphere5.5, NFS as primary and secondary storages. Reporter: Yusei Nishioka Attachments: management-server.log I'm testing ConfigDrive behavior with CloudStack 4.11RC2. At first test, ConfigDrive worked. Then, I rebooted management server and I've deploy new VM. However that vm didn't deploy with below message. Unable to start a VM due to unavailable resources I attached management-server.log at that time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342266#comment-16342266 ] ASF GitHub Bot commented on CLOUDSTACK-10240: - rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-361006831 ok @DaanHoogland. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS cannot migrate a volume from local to shared storage (for XenServer) > > > Key: CLOUDSTACK-10240 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > CloudStack is logically restricting the migration of local storages to shared > storage and vice versa. This restriction is a logical one and can be removed > for XenServer deployments. Therefore, we will enable migration of volumes > between local-shared storages in XenServers independently of their service > offering. This will work as an override mechanism to the disk offering used > by volumes. If administrators want to migrate local volumes to a shared > storage, they should be able to do so (the hypervisor already allows that). > The same the other way around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342262#comment-16342262 ] ASF GitHub Bot commented on CLOUDSTACK-10240: - DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-361006294 no, never mind. (next time better!) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS cannot migrate a volume from local to shared storage (for XenServer) > > > Key: CLOUDSTACK-10240 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > CloudStack is logically restricting the migration of local storages to shared > storage and vice versa. This restriction is a logical one and can be removed > for XenServer deployments. Therefore, we will enable migration of volumes > between local-shared storages in XenServers independently of their service > offering. This will work as an override mechanism to the disk offering used > by volumes. If administrators want to migrate local volumes to a shared > storage, they should be able to do so (the hypervisor already allows that). > The same the other way around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342261#comment-16342261 ] ASF GitHub Bot commented on CLOUDSTACK-8855: DaanHoogland commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-361006147 I restarted the travis run. I don't see any reason but there is some link; the test is a certificate error and the changes are involving reconnects , might be a travis error, though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Error Message for Host Alert State > -- > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.6.0 >Reporter: Bharat Kumar >Assignee: Bharat Kumar >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342250#comment-16342250 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361004616 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342251#comment-16342251 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - blueorangutan commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361004643 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342188#comment-16342188 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - blueorangutan commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-360992062 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1682 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342167#comment-16342167 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-360990206 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342168#comment-16342168 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - blueorangutan commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-360990231 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342116#comment-16342116 ] ASF GitHub Bot commented on CLOUDSTACK-10225: - wido commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-360982193 Thanks @rafaelweingartner ! Fixed that comment This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deprecate com.cloud.utils.StringUtils > - > > Key: CLOUDSTACK-10225 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wido den Hollander >Priority: Major > > com.cloud.utils.StringUtils contains a lot of methods which can be deprecated > in favor of Apache Commons. > We should try to use Apache Commons where possible and reduce our code > footprint. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342102#comment-16342102 ] ASF GitHub Bot commented on CLOUDSTACK-8855: rafaelweingartner commented on issue #2387: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-360980209 @DaanHoogland and @marcaurele these last two days I have been working to fix all conflicts and rebase my PRs against the new master. However, this one that we were working together I did not understand why one of the travis tests are failing. Could you guys lend me your fresh eyes here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Error Message for Host Alert State > -- > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.6.0 >Reporter: Bharat Kumar >Assignee: Bharat Kumar >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342100#comment-16342100 ] ASF GitHub Bot commented on CLOUDSTACK-10240: - rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360979844 I would say that there is only one formatting style for ACS. However, I have seen so many PRs like this one where we see a lot of formatting changes that I am starting to doubt if we are all using the same. I agree with you. My intention here was never to do code formatting. My eclipse is configured to format only edit lines, but for some reason it formatted all of the Java files I touched (maybe I pressed a ctrl+shift+f without noticing). Would you like me to remove the formatting and leave only the real changes I am introducing here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS cannot migrate a volume from local to shared storage (for XenServer) > > > Key: CLOUDSTACK-10240 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > CloudStack is logically restricting the migration of local storages to shared > storage and vice versa. This restriction is a logical one and can be removed > for XenServer deployments. Therefore, we will enable migration of volumes > between local-shared storages in XenServers independently of their service > offering. This will work as an override mechanism to the disk offering used > by volumes. If administrators want to migrate local volumes to a shared > storage, they should be able to do so (the hypervisor already allows that). > The same the other way around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342064#comment-16342064 ] ASF GitHub Bot commented on CLOUDSTACK-10240: - DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360973959 @rafaelweingartner that is the only true formatter for cloudstack, isn't it. still i'd like to have reformattings in a different commit. the mindset of reviewing reformatting is a bit different than that of reviewing semantic/logic changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS cannot migrate a volume from local to shared storage (for XenServer) > > > Key: CLOUDSTACK-10240 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > CloudStack is logically restricting the migration of local storages to shared > storage and vice versa. This restriction is a logical one and can be removed > for XenServer deployments. Therefore, we will enable migration of volumes > between local-shared storages in XenServers independently of their service > offering. This will work as an override mechanism to the disk offering used > by volumes. If administrators want to migrate local volumes to a shared > storage, they should be able to do so (the hypervisor already allows that). > The same the other way around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342062#comment-16342062
]
ASF GitHub Bot commented on CLOUDSTACK-10225:
-
DaanHoogland commented on a change in pull request #2431: CLOUDSTACK-10225:
Deprecate StringUtils in favor of Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#discussion_r164268400
##
File path: utils/src/main/java/com/cloud/utils/StringUtils.java
##
@@ -78,12 +76,13 @@ public static String join(final String delimiter, final
Object... components) {
return org.apache.commons.lang.StringUtils.join(components, delimiter);
}
+/**
+ * @deprecated
+ * Please use org.apache.commons.lang.StringUtils.IsBlank() as a
replacement
Review comment:
missed that one :(
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate com.cloud.utils.StringUtils
> -
>
> Key: CLOUDSTACK-10225
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wido den Hollander
>Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated
> in favor of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code
> footprint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342055#comment-16342055
]
ASF GitHub Bot commented on CLOUDSTACK-10225:
-
rafaelweingartner commented on a change in pull request #2431:
CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#discussion_r164267987
##
File path: utils/src/main/java/com/cloud/utils/StringUtils.java
##
@@ -78,12 +76,13 @@ public static String join(final String delimiter, final
Object... components) {
return org.apache.commons.lang.StringUtils.join(components, delimiter);
}
+/**
+ * @deprecated
+ * Please use org.apache.commons.lang.StringUtils.IsBlank() as a
replacement
Review comment:
What about referencing `org.apache.commons.lang.StringUtils.IsNotBlank`
instead? So, we do not cause confusions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deprecate com.cloud.utils.StringUtils
> -
>
> Key: CLOUDSTACK-10225
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wido den Hollander
>Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated
> in favor of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code
> footprint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342051#comment-16342051
]
ASF GitHub Bot commented on CLOUDSTACK-9677:
rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677:
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267922
##
File path: utils/src/test/java/com/cloud/utils/SwiftUtilTest.java
##
@@ -90,4 +96,134 @@ public void testGetContainerName(){
assertEquals(expected, output);
}
+
+@Test
Review comment:
Unit Tests! That is awesome!!
Thank you very much for these. We need to create a culture of writing them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342049#comment-16342049
]
ASF GitHub Bot commented on CLOUDSTACK-9677:
rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677:
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267865
##
File path: utils/src/main/java/com/cloud/utils/SwiftUtil.java
##
@@ -294,12 +238,80 @@ public static String calculateRFC2104HMAC(String data,
String key)
}
-public static String toHexString(byte[] bytes) {
+static String toHexString(byte[] bytes) {
Review comment:
What about using a commons to convert the string to Hexadecimal?
Something like: org.apache.commons.codec.binary.Hex.encode(byte[])
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342048#comment-16342048
]
ASF GitHub Bot commented on CLOUDSTACK-9677:
rafaelweingartner commented on a change in pull request #2412: CLOUDSTACK-9677:
Adding storage policy support for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#discussion_r164267825
##
File path:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.cloud.hypervisor.xenserver.resource;
+
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import com.cloud.agent.api.to.SwiftTO;
+
+public class XenServerStorageProcessorTest {
+@Test
+public void testOrderOfSwiftUplodScriptParams() {
+CitrixResourceBase resource = Mockito.mock(CitrixResourceBase.class);
+XenServerStorageProcessor mock = new
XenServerStorageProcessor(resource);
+
+SwiftTO swift = Mockito.mock(SwiftTO.class);
+String container = "sample-container-name";
+String ldir = "sample-ldir";
+String lfilename = "sample-lfilename";
+Boolean isISCSI = true;
+
+List params = mock.getSwiftParams(swift, container, ldir,
lfilename, isISCSI);
+
+// make sure the params not null and has correct number of items in it
+Assert.assertNotNull("params is null", params);
+Assert.assertTrue("Expected param list size is either 18 or 20 but it
was" + params.size(), params.size() == 18 || params.size() == 20);
+
+// check the order of params
+Assert.assertEquals("unexpected param.", "op", params.get(0));
+Assert.assertEquals("unexpected param.", "upload", params.get(1));
+Assert.assertEquals("unexpected param.", "url", params.get(2));
+Assert.assertEquals("unexpected param.", swift.getUrl(),
params.get(3));
+Assert.assertEquals("unexpected param.", "account", params.get(4));
+Assert.assertEquals("unexpected param.", swift.getAccount(),
params.get(5));
+Assert.assertEquals("unexpected param.", "username", params.get(6));
+Assert.assertEquals("unexpected param.", swift.getUserName(),
params.get(7));
+Assert.assertEquals("unexpected param.", "key", params.get(8));
+Assert.assertEquals("unexpected param.", swift.getKey(),
params.get(9));
+Assert.assertEquals("unexpected param.", "container", params.get(10));
+Assert.assertEquals("unexpected param.", container, params.get(11));
+Assert.assertEquals("unexpected param.", "ldir", params.get(12));
+Assert.assertEquals("unexpected param.", ldir, params.get(13));
+Assert.assertEquals("unexpected param.", "lfilename", params.get(14));
+Assert.assertEquals("unexpected param.", lfilename, params.get(15));
+Assert.assertEquals("unexpected param.", "isISCSI", params.get(16));
+Assert.assertEquals("unexpected param.", isISCSI.toString(),
params.get(17));
+
+if (swift.getStoragePolicy() != null) {
Review comment:
@khos2ow thanks for creating the unit test case.
I have a doubt here. What is the execution flow you are testing? the one
with storage policy or without it?
Also, what do you think about two distinct tests? One to execute the test
with a storagePolicy and other without.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
> Issue Type: Improvement
> Security Level:
[jira] [Commented] (CLOUDSTACK-10240) ACS cannot migrate a volume from local to shared storage (for XenServer)
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342047#comment-16342047 ] ASF GitHub Bot commented on CLOUDSTACK-10240: - rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-360971535 @Daan, thanks for the feedback here! I am starting to doubt that we are all using the same code formatter (I am using this one [1]). I can remove the code formatting changes and leave only the methods that I created if you prefer. [1] https://cwiki.apache.org/confluence/download/attachments/29687985/ApacheCloudStack.xml?version=1=1382960469000=v2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS cannot migrate a volume from local to shared storage (for XenServer) > > > Key: CLOUDSTACK-10240 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10240 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Rafael Weingärtner >Assignee: Rafael Weingärtner >Priority: Major > > CloudStack is logically restricting the migration of local storages to shared > storage and vice versa. This restriction is a logical one and can be removed > for XenServer deployments. Therefore, we will enable migration of volumes > between local-shared storages in XenServers independently of their service > offering. This will work as an override mechanism to the disk offering used > by volumes. If administrators want to migrate local volumes to a shared > storage, they should be able to do so (the hypervisor already allows that). > The same the other way around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
