[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418226#comment-16418226
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066722
 
 
   @DaanHoogland I checked this last log result. Can I consider that the tests 
is successful then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418225#comment-16418225
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066408
 
 
   Trillian test result (tid-2436)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22786 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2401-t2436-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 452.86 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418105#comment-16418105
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-377036238
 
 
   Trillian test result (tid-2427)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 126331 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2505-t2427-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 60 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 4.25 | test_routers.py
   test_04_extract_template | `Failure` | 128.35 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_secured_vm_migration | `Failure` | 934.74 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 0.22 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.26 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.26 | 
test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 143.42 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 505.57 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.24 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10344) Sometimes a bug happens when moving ACL rules (changing their order with drag and drop)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417968#comment-16417968
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10344:
-

blueorangutan commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL 
rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-377005467
 
 
   Trillian test result (tid-2430)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 108750 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2511-t2430-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 59 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 1.16 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.25 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.42 | 
test_primary_storage.py
   test_02_vpc_privategw_static_routes | `Failure` | 260.08 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 273.46 | 
test_privategw_acl.py
   test_04_restart_network_wo_cleanup | `Failure` | 4.38 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.25 | 
test_snapshots.py
   test_08_migrate_vm | `Error` | 23.71 | test_vm_life_cycle.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 613.18 | 
test_vpc_redundant.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 6.67 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.66 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.88 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Sometimes a bug happens when moving ACL rules (changing their order with drag 
> and drop) 
> 
>
> Key: CLOUDSTACK-10344
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10344
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> An error is happening in certain conditions, such as when you have only 2 ACL 
> rules and you move the last one to the top. There are other conditions, for 
> instance, when moving ACLs that are in a sequence of numbers without gaps.
> Example, rules:
> number | rule
> 1 - rule A
> 2 - rule D
> 3 - rule B
> 4 - rule C
> 5 - rule E
> It is not possible to move "rule C" in position 2, 1, and 3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417800#comment-16417800
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10301:
-

blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the 
network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376969129
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow updating the network ACL list name and Description 
> -
>
> Key: CLOUDSTACK-10301
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> Currently, it is not possible to update the Network ACL name or Description 
> of an ACL after it has been created. It might be interesting to expose this 
> option via API and to add this feature to the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417799#comment-16417799
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10301:
-

borisstoyanov commented on issue #2462: [CLOUDSTACK-10301] Allow updating the 
network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376969001
 
 
   sure @rafaelweingartner 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow updating the network ACL list name and Description 
> -
>
> Key: CLOUDSTACK-10301
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> Currently, it is not possible to update the Network ACL name or Description 
> of an ACL after it has been created. It might be interesting to expose this 
> option via API and to add this feature to the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417681#comment-16417681
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376947269
 
 
   I checked the logs. The problems did not seem to be related to the PR.
   However, it is always good to have the feedback of an expert ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417675#comment-16417675
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946598
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (CLOUDSTACK-10289) Config drive - Metadata leaking internal ids

[Frank Maximus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Frank Maximus reassigned CLOUDSTACK-10289:
--

Assignee: Frank Maximus

> Config drive - Metadata leaking internal ids
> 
>
> Key: CLOUDSTACK-10289
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10289
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Rohit Yadav
>Assignee: Frank Maximus
>Priority: Major
>
> Metadata on config drive looks like this, which is different from what 
> routervm userdata looks like. Leaking internal IDs:
>     # for i in `ls`; do echo -n $i : ; cat $i; echo; done
> availability-zone.txt : zone1
> cloud-identifier.txt : CloudStack-\{af714831-9a23-4ee4-a415-984a6dae1c61}
> instance-id.txt : i-2-24-VM
> local-hostname.txt : i-2-24-VM
> service-offering.txt : Small Instance
> vm-id.txt : 24



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417674#comment-16417674
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946409
 
 
   I think it is @rafaelweingartner let me rekick anyway, you can download the 
logs and examine them.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10226) CloudStack is not importing Local storage properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417663#comment-16417663
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10226:
-

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376944918
 
 
   @DaanHoogland it seems that the tests you executed here were successful 
(despite the errors presented). Can you confirm it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CloudStack is not importing Local storage properly 
> ---
>
> Key: CLOUDSTACK-10226
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10226
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> CloudStack is importing as Local storage any XenServer SR that is of type LVM 
> or EXT. This causes a problem when one wants to use both Direct attach 
> storage and local storage. Moreover, CloudStack was not importing all of the 
> local storage that a host has available when local storage is enabled. It was 
> only importing the First SR it sees.
> To fix the first problem we started ignoring SRs that have the flag 
> shared=true when discovering local storages. SRs configured to be shared are 
> used as direct attached storage, and therefore should not be imported again 
> as local ones.
> To fix the second problem, we started loading all Local storage and importing 
> them accordingly to ACS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10301) Allow updating the network ACL list name and Description

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417659#comment-16417659
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10301:
-

rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating 
the network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376944372
 
 
   @borisstoyanov can you run tests here?
   This is a simple, but useful feature in production.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow updating the network ACL list name and Description 
> -
>
> Key: CLOUDSTACK-10301
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10301
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> Currently, it is not possible to update the Network ACL name or Description 
> of an ACL after it has been created. It might be interesting to expose this 
> option via API and to add this feature to the UI.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10323) Change disk offering when volume is migrated to different type of storage pool.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417658#comment-16417658
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10323:
-

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-376943966
 
 
   @borisstoyanov I amended the code as you suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change disk offering when volume is migrated to different type of storage 
> pool.
> ---
>
> Key: CLOUDSTACK-10323
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10323
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.12
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> This is a continuation of work developed on PR #2425 (CLOUDSTACK-10240), 
> which provided root admins an override mechanism to move volumes between 
> storage systems types (local/shared) even when the disk offering would not 
> allow such operation. To complete the work, we will now provide a way for 
> administrators to enter a new disk offering that can reflect the new 
> placement of the volume. We will add an extra parameter to allow the root 
> admin inform a new disk offering for the volume. Therefore, when the volume 
> is being migrated, it will be possible to replace the disk offering to 
> reflect the new placement of the volume.
> The API method will have the following parameters: 
> * storageid (required)
> * volumeid (required)
> * livemigrate(optional)
> * newdiskofferingid (optional) – this is the new parameter
> The expected behavior is the following: 
> * If “newdiskofferingid” is not provided the current behavior is maintained. 
> Override mechanism will also keep working as we have seen so far. 
> * If the “newdiskofferingid” is provided by the admin, we will execute the 
> following checks
> ** new disk offering mode (local/shared) must match the target storage mode. 
> If it does not match, an exception will be thrown and the operator will 
> receive a message indicating the problem.
> ** we will check if the new disk offering tags match the target storage tags. 
> If it does not match, an exception will be thrown and the operator will 
> receive a message indicating the problem.
> ** check if the target storage has the capacity for the new volume. If it 
> does not have enough space, then an exception is thrown and the operator will 
> receive a message indicating the problem.
> ** check if the size of the volume is the same as the size of the new disk 
> offering. If it is not the same, we will ALLOW the change of the service 
> offering, and a warning message will be logged.
> We execute the change of the Disk offering as soon as the migration of the 
> volume finishes. Therefore, if an error happens during the migration and the 
> volume remains in the original storage system, the disk offering will keep 
> reflecting this situation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10323) Change disk offering when volume is migrated to different type of storage pool.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417656#comment-16417656
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10323:
-

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-376943966
 
 
   @borisstoyanov I ammended the code as you suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Change disk offering when volume is migrated to different type of storage 
> pool.
> ---
>
> Key: CLOUDSTACK-10323
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10323
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.12
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> This is a continuation of work developed on PR #2425 (CLOUDSTACK-10240), 
> which provided root admins an override mechanism to move volumes between 
> storage systems types (local/shared) even when the disk offering would not 
> allow such operation. To complete the work, we will now provide a way for 
> administrators to enter a new disk offering that can reflect the new 
> placement of the volume. We will add an extra parameter to allow the root 
> admin inform a new disk offering for the volume. Therefore, when the volume 
> is being migrated, it will be possible to replace the disk offering to 
> reflect the new placement of the volume.
> The API method will have the following parameters: 
> * storageid (required)
> * volumeid (required)
> * livemigrate(optional)
> * newdiskofferingid (optional) – this is the new parameter
> The expected behavior is the following: 
> * If “newdiskofferingid” is not provided the current behavior is maintained. 
> Override mechanism will also keep working as we have seen so far. 
> * If the “newdiskofferingid” is provided by the admin, we will execute the 
> following checks
> ** new disk offering mode (local/shared) must match the target storage mode. 
> If it does not match, an exception will be thrown and the operator will 
> receive a message indicating the problem.
> ** we will check if the new disk offering tags match the target storage tags. 
> If it does not match, an exception will be thrown and the operator will 
> receive a message indicating the problem.
> ** check if the target storage has the capacity for the new volume. If it 
> does not have enough space, then an exception is thrown and the operator will 
> receive a message indicating the problem.
> ** check if the size of the volume is the same as the size of the new disk 
> offering. If it is not the same, we will ALLOW the change of the service 
> offering, and a warning message will be logged.
> We execute the change of the Disk offering as soon as the migration of the 
> volume finishes. Therefore, if an error happens during the migration and the 
> volume remains in the original storage system, the disk offering will keep 
> reflecting this situation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417647#comment-16417647
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

rafaelweingartner commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376942892
 
 
   @DaanHoogland are you going to introduce the changes here in master as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417641#comment-16417641
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376941687
 
 
   Trillian test result (tid-2429)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 106423 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2449-t2429-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 2.78 | test_routers.py
   test_04_extract_template | `Failure` | 128.31 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 136.58 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 481.47 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.46 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10332) Users are not able to change/edit the protocol of an ACL rule

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417628#comment-16417628
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10332:
-

rafaelweingartner commented on issue #2496: [CLOUDSTACK-10332] Users are not 
able to change/edit the protocol of an ACL rule 
URL: https://github.com/apache/cloudstack/pull/2496#issuecomment-376940834
 
 
   @borisstoyanov thanks!
   So, are you ok with this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Users are not able to change/edit the protocol of an ACL rule 
> --
>
> Key: CLOUDSTACK-10332
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10332
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> Users should be able to edit an ACL rule completely. Therefore, they must be 
> able to change the protocol type and others configs of an ACL rules.
> Right now users are not able to execute the following. 
> * Create an ACL for ICMP
> * Click on edit and change the protocol to TCP
> * An error will happen when saving the rule.
> Users should be able to execute the protocol changes without problem.
> In addition, it is not just the protocol that users are not able to change. 
> For instance, after defining ports, or reason/description for the rule, users 
> are not able to set those values back to null. The same happens for ICMP code 
> and type.
> We will introduce a new parameter called "partialUpdate", which will have its 
> default value as true to maintain backward compatibility. When this parameter 
> is set to false, we will consider only the parameters sent, and not the 
> parameters we already have in the database to change and validate the ACL 
> rule data. This allows us to update parameters already set back to null, and 
> to completely change an ACL rule.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10344) Sometimes a bug happens when moving ACL rules (changing their order with drag and drop)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417626#comment-16417626
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10344:
-

rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving 
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-376940534
 
 
   @nitin-maharana thanks for the review. Do you approve the PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Sometimes a bug happens when moving ACL rules (changing their order with drag 
> and drop) 
> 
>
> Key: CLOUDSTACK-10344
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10344
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
> Fix For: 4.12
>
>
> An error is happening in certain conditions, such as when you have only 2 ACL 
> rules and you move the last one to the top. There are other conditions, for 
> instance, when moving ACLs that are in a sequence of numbers without gaps.
> Example, rules:
> number | rule
> 1 - rule A
> 2 - rule D
> 3 - rule B
> 4 - rule C
> 5 - rule E
> It is not possible to move "rule C" in position 2, 1, and 3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10241) Duplicated file SRs being created in XenServer pools

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417563#comment-16417563
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10241:
-

rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file 
SRs being created in XenServer pools
URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-376931360
 
 
   @rhtyd I will wait more 24 hours before merging this one to give you some 
extra time in cause you have objections. Tests results are green (tests 
executed by @DaanHoogland 14 days ago), and the reviews are positive.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Duplicated file SRs being created in XenServer pools
> 
>
> Key: CLOUDSTACK-10241
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10241
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>Priority: Major
>
> Due to a race condition between multiple management servers, in some rare 
> cases, CloudStack is creating multiple file SRs to the same secondary folder. 
> This causes a problem when introducing the SR to the XenServer pools, as 
> “there will be VDIs with duplicated UUIDs“. The VDIs are the same, but they 
> are seen in different SRs, and therefore cause an error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417300#comment-16417300
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376878832
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1848


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417282#comment-16417282
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376871848
 
 
   Maybe this ^^ needs further investigation since I've provisioned the 
certificates on both the hosts and still getting the same error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417276#comment-16417276
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870877
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417275#comment-16417275
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870609
 
 
   @rhtyd I'm trying to migrate a VM between unsecured hosts and got the 
following exception: 
   ```
   2018-03-28 12:31:52,414 ERROR [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Invocation exception, caused by: 
com.cloud.utils.exception.CloudRuntimeException: org.libvirt.LibvirtException: 
Cannot get interface MTU on 'breth0-769': No such device
   2018-03-28 12:31:52,415 INFO  [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Rethrow exception com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   2018-03-28 12:31:52,415 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Done with run 
of VM work job: com.cloud.vm.VmWorkMigrate for VM 3, job origin: 38
   2018-03-28 12:31:52,415 ERROR [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Unable to 
complete AsyncJobVO {id:39, userId: 2, accountId: 2, instanceType: null, 
instanceId: null, cmd: com.cloud.vm.VmWorkMigrate, cmdInfo: 
rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAACAAIAA3QAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAXNxAH4ABwACcQB-AAlwcQB-AAk,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 6653541943041, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Wed Mar 28 12:31:50 UTC 2018}, job origin:38
   com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   ```
   I've made the hosts unsecured by deleting the executing the 
cloudstack-setup-agent script without the -s option. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10333) Secure VM Live migration for KVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417274#comment-16417274
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10333:
-

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870609
 
 
   @rhtyd I'm trying to migrate a VM between unsecured hosts and got the 
following exception: 
   ```
   2018-03-28 12:31:52,414 ERROR [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Invocation exception, caused by: 
com.cloud.utils.exception.CloudRuntimeException: org.libvirt.LibvirtException: 
Cannot get interface MTU on 'breth0-769': No such device
   2018-03-28 12:31:52,415 INFO  [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Rethrow exception com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   2018-03-28 12:31:52,415 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Done with run 
of VM work job: com.cloud.vm.VmWorkMigrate for VM 3, job origin: 38
   2018-03-28 12:31:52,415 ERROR [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Unable to 
complete AsyncJobVO {id:39, userId: 2, accountId: 2, instanceType: null, 
instanceId: null, cmd: com.cloud.vm.VmWorkMigrate, cmdInfo: 
rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAACAAIAA3QAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAXNxAH4ABwACcQB-AAlwcQB-AAk,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 6653541943041, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Wed Mar 28 12:31:50 UTC 2018}, job origin:38
   com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   ```
   I've made the hosts unsecured by deleting the executing the 
cloudstack-setup-agent script without the -s option. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Secure VM Live migration for KVM
> 
>
> Key: CLOUDSTACK-10333
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10333
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> With use of CA framework to secure hosts, the current mechanisms don't secure 
> libvirtd to use those certificates (used by agent to connect to mgmt server). 
> This causes insecure vm migration over tcp instead of tls. The aim is to use 
> the same framework and certificates to secure live VM migration. This could 
> be coupled with securing of a host and renewal/provisioning of certificates 
> to host.
>  
> FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Secure+Live+VM+Migration+for+KVM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417230#comment-16417230
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10341:
-

blueorangutan commented on issue #2506: CLOUDSTACK-10341: Reduce 
systemvmtemplate size, install nftables
URL: https://github.com/apache/cloudstack/pull/2506#issuecomment-376859587
 
 
   Trillian test result (tid-2428)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 92895 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2428-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 5.03 | test_routers.py
   test_09_reboot_router | `Error` | 178.95 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Systemvmtemplate 4.11 changes
> -
>
> Key: CLOUDSTACK-10341
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10341
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Systemvmtemplate and fail due to low /run memory allocation, the template is 
> slow to copy the size may be further reduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417191#comment-16417191
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417192#comment-16417192
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417187#comment-16417187
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

DaanHoogland commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376851510
 
 
   merging based on LGTMs and test reports


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417190#comment-16417190
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417184#comment-16417184
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

DaanHoogland closed pull request #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine/schema/resources/META-INF/db/schema-41000to41100.sql 
b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
index 2e7f9e9fe9c..4dc11d448fc 100644
--- a/engine/schema/resources/META-INF/db/schema-41000to41100.sql
+++ b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
@@ -19,8 +19,54 @@
 -- Schema upgrade from 4.10.0.0 to 4.11.0.0
 --;
 
+--;
+-- Stored procedure to do idempotent column add;
+--;
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_ADD_COLUMN`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` (
+   IN in_table_name VARCHAR(200)
+, IN in_column_name VARCHAR(200)
+, IN in_column_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 'ADD COLUMN') ; SET @ddl 
= CONCAT(@ddl, ' ', in_column_name); SET @ddl = CONCAT(@ddl, ' ', 
in_column_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY` (
+   IN in_table_name VARCHAR(200)
+, IN in_foreign_key_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' DROP FOREIGN KEY '); 
SET @ddl = CONCAT(@ddl, ' ', in_foreign_key_name); PREPARE stmt FROM @ddl; 
EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('DROP INDEX 
', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl = 
CONCAT(@ddl, ' ', in_table_name); PREPARE stmt FROM @ddl; EXECUTE stmt; 
DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+, IN in_index_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('CREATE 
UNIQUE INDEX ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl 
= CONCAT(@ddl, ' ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 
in_index_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
 -- Add For VPC flag
-ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc INT(1) NOT NULL DEFAULT 
0;
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.network_offerings','for_vpc', 
'INT(1) NOT NULL DEFAULT 0');
+
 UPDATE cloud.network_offerings o
 SET for_vpc = 1
 where
@@ -88,7 +134,7 @@ CREATE TABLE IF NOT EXISTS `cloud`.`annotations` (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
 DROP VIEW IF EXISTS `cloud`.`last_annotation_view`;
-CREATE VIEW `last_annotation_view` AS
+CREATE VIEW `cloud`.`last_annotation_view` AS
 SELECT
 `annotations`.`uuid` AS `uuid`,
 `annotations`.`annotation` AS `annotation`,
@@ -405,21 +451,18 @@ UPDATE `cloud`.`monitoring_services` SET 
pidfile="/var/run/apache2/apache2.pid"
 UPDATE `cloud`.`vm_template` SET guest_os_id=99 WHERE id=8;
 
 -- Network External Ids
-ALTER TABLE `cloud`.`networks` ADD `external_id` varchar(255);
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.networks','external_id', 
'varchar(255)');
 
 -- Separate Subnet for CPVM and SSVM (system vms)
-ALTER TABLE `cloud`.`op_dc_ip_address_alloc`
-ADD COLUMN `forsystemvms` TINYINT(1) NOT NULL DEFAULT '0' COMMENT 'Indicates 
if IP is dedicated for CPVM or SSVM';
+CALL 
`cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.op_dc_ip_address_alloc','forsystemvms', 
'TINYINT(1) NOT NULL DEFAULT 0 COMMENT ''Indicates if IP is dedicated for CPVM 
or SSVM'' ');
 
-ALTER TABLE `cloud`.`op_dc_ip_address_alloc`
-ADD COLUMN `vlan` INT(10) UNSIGNED NULL COMMENT 'Vlan the management network 
range is on';
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.op_dc_ip_address_alloc','vlan', 
'INT(10) UNSIGNED NULL COMMENT ''Vlan the management network range is on'' ');
 
 -- CLOUDSTACK-4757: Support multidisk OVA
-ALTER TABLE `cloud`.`vm_template` ADD COLUMN 

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417188#comment-16417188
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417186#comment-16417186
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417189#comment-16417189
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417185#comment-16417185
 ] 

ASF subversion and git services commented on CLOUDSTACK-10278:
--

Commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73 in cloudstack's branch 
refs/heads/4.11 from ernjvr
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=7647e10 ]

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all lines, 
that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored procs


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-9677) Swift Storage Policy support for Secondary Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417172#comment-16417172
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9677:


rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-376848209
 
 
   Ping @khos2ow can you advise on testing of this PR against swift? This is 
ready to merge based on 2+lgtms and smoke test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Swift Storage Policy support for Secondary Storage
> --
>
> Key: CLOUDSTACK-9677
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9677
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Patrick D.
>Assignee: Patrick D.
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417155#comment-16417155
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376842088
 
 
   Upgrade Test Result: I installed a version 4.6 environment with some of the 
DB changes that were already in 4.11, created a few networks: isolated, shared, 
vpc and created vms on each. I proceeded with the upgrade to 4.11 using this PR 
code. After the upgrade i had to add missing braces to some environment 
variables in the /usr/lib/systemd/system/cloudstack-management.service file and 
also had to configure the /etc/default/cloudstack-management file with the 
correct 4.11 environment variables. After starting the management server and 
running the migrate-dynamicroles.py I was able to log in to the UI and observe 
that the vms were back up and running. A successful upgrade without any DB 
issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417148#comment-16417148
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376842088
 
 
   Upgrade Test Result: I installed a version 4.6 environment, created a few 
networks: isolated, shared, vpc and created vms on each. I proceeded with the 
upgrade to 4.11 using this PR code. After the upgrade i had to add missing 
braces to some environment variables in the 
/usr/lib/systemd/system/cloudstack-management.service file and also had to 
configure the /etc/default/cloudstack-management file with the correct 4.11 
environment variables. After starting the management server and running the 
migrate-dynamicroles.py I was able to log in to the UI and observe that the vms 
were back up and running. A successful upgrade.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafael Weingärtner resolved CLOUDSTACK-10334.
-
   Resolution: Fixed
Fix Version/s: 4.12

> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
> Fix For: 4.12
>
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417120#comment-16417120
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376831626
 
 
   @rhtyd I am ok too. I will merge then  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417122#comment-16417122
 ] 

ASF subversion and git services commented on CLOUDSTACK-10334:
--

Commit c1c587fffe0dc3cc703829a4a4501afb1fee1a45 in cloudstack's branch 
refs/heads/master from lzh3636
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c1c587f ]

CLOUDSTACK-10334: Fix inadequate information for handling catch clauses (#2510)

* Add log stack traces

* Change log stack traces

Add original stack trace to the new throw and delete the error logs


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417121#comment-16417121
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

rafaelweingartner closed pull request #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java 
b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
index feefaabc551..f030209c9a5 100644
--- a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
+++ b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -258,13 +258,11 @@ public void processParameters(final BaseCmd cmd, final 
Map params) {
 }
 
 } catch (final IllegalArgumentException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 } catch (final IllegalAccessException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 }
 
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417119#comment-16417119
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376831626
 
 
   @DaanHoogland I am ok too. I will merge then  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417050#comment-16417050
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376812696
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1846


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417039#comment-16417039
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

rhtyd commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information 
for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376806301
 
 
   @DaanHoogland @rafaelweingartner  this is simply a logging change, Travis is 
green. I'm okay merging based on 2+ lgtms and test run by Travis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417037#comment-16417037
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376805440
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10278) Adding a SQL table column is not Idempotent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417035#comment-16417035
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10278:
-

rhtyd commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376805263
 
 
   Will re-kick test.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Adding a SQL table column is not Idempotent
> ---
>
> Key: CLOUDSTACK-10278
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10278
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Install and Setup
>Affects Versions: 4.10.0.0, 4.11.0.0
>Reporter: Ernie Janse van Rensburg
>Assignee: Ernie Janse van Rensburg
>Priority: Major
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> The SQL code to add a new column to a table in the 
> META-INF/db/schema-41000to41100.sql script is not written in an idempotent 
> way. When the upgrade is re-run, the code above causes a SQL error as 
> reported on the user mailing list: 
> ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:)
> Error executing: ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc
> INT(1) NOT NULL DEFAULT 0
> This is a more generic problem for every version due to to the fact that it 
> is not idempotent
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417034#comment-16417034
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376804849
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10334) Inadequate information for handling catch clauses

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417033#comment-16417033
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10334:
-

DaanHoogland commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376804536
 
 
   not sure @rafaelweingartner , should we?
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Inadequate information for handling catch clauses
> -
>
> Key: CLOUDSTACK-10334
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10334
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java*
> [https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java]
> At Line *261* and Line *265.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all.
> Also they threw new exceptions after the logs, but the throw statements in 
> these two catch clauses are identical, which are not distinguishable.
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and can not distinguish logs generated 
> by these two statements.
>  Maybe adding stack trace information to these two logging statements and 
> change the log message to handle specific situations is a simple way to 
> improve it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416999#comment-16416999
 ] 

ASF subversion and git services commented on CLOUDSTACK-10341:
--

Commit ba61b512b2b1006d7164e039a3cb57db9ba64fab in cloudstack's branch 
refs/heads/master from [~rohit.ya...@shapeblue.com]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=ba61b51 ]

[Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size (#2506)

Signed-off-by: Rohit Yadav 


> Systemvmtemplate 4.11 changes
> -
>
> Key: CLOUDSTACK-10341
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10341
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Systemvmtemplate and fail due to low /run memory allocation, the template is 
> slow to copy the size may be further reduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416998#comment-16416998
 ] 

ASF subversion and git services commented on CLOUDSTACK-10341:
--

Commit 986ecfa7e99d0f29b4d7b3cd8065da31695ec00b in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=986ecfa ]

CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables (#2506)

This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables. This also fixes a failing smoke test.

Signed-off-by: Rohit Yadav 

> Systemvmtemplate 4.11 changes
> -
>
> Key: CLOUDSTACK-10341
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10341
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Systemvmtemplate and fail due to low /run memory allocation, the template is 
> slow to copy the size may be further reduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416983#comment-16416983
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10341:
-

rhtyd closed pull request #2506: CLOUDSTACK-10341: Reduce systemvmtemplate 
size, install nftables
URL: https://github.com/apache/cloudstack/pull/2506
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/test/integration/smoke/test_vpc_redundant.py 
b/test/integration/smoke/test_vpc_redundant.py
index 2fde8d99207..64b1fa67771 100644
--- a/test/integration/smoke/test_vpc_redundant.py
+++ b/test/integration/smoke/test_vpc_redundant.py
@@ -304,8 +304,8 @@ def wait_for_vrrp(self):
 time.sleep(3 * self.advert_int + 5)
 
 def check_routers_state(self,count=2, status_to_check="MASTER", 
expected_count=1, showall=False):
-vals = ["MASTER", "BACKUP", "UNKNOWN"]
-cnts = [0, 0, 0]
+vals = ["MASTER", "BACKUP", "UNKNOWN", "FAULT"]
+cnts = [0, 0, 0, 0]
 
 self.wait_for_vrrp()
 
@@ -612,7 +612,8 @@ def test_04_rvpc_network_garbage_collector_nics(self):
 
 time.sleep(total_sleep * 3)
 
-self.check_routers_state(status_to_check="BACKUP", expected_count=2)
+# Router will be in FAULT state, i.e. keepalived is stopped
+self.check_routers_state(status_to_check="FAULT", expected_count=2)
 self.start_vm()
 self.check_routers_state(status_to_check="MASTER")
 
diff --git a/tools/appliance/build.sh b/tools/appliance/build.sh
index 8b1032ecc8b..ba6fe4dda1a 100755
--- a/tools/appliance/build.sh
+++ b/tools/appliance/build.sh
@@ -195,7 +195,7 @@ function create_definition() {
 set +e
 if [ ! -z "${version}" ]; then
 sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
-"${appliance_build_name}/configure_systemvm_services.sh"
+"${appliance_build_name}/scripts/configure_systemvm_services.sh"
 fi
 set -e
 add_on_exit rm -rf "${appliance_build_name}"
diff --git a/tools/appliance/systemvmtemplate/http/preseed.cfg 
b/tools/appliance/systemvmtemplate/http/preseed.cfg
index cdb649a8f5d..65a573374a9 100644
--- a/tools/appliance/systemvmtemplate/http/preseed.cfg
+++ b/tools/appliance/systemvmtemplate/http/preseed.cfg
@@ -54,28 +54,28 @@ d-i partman-auto/disk string /dev/vda
 d-i partman-auto/method string regular
 d-i partman-auto/expert_recipe string \
   boot-root ::\
-  80 50 160 ext2  \
+  60 60 60 ext2   \
   $primary{ } $bootable{ }\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext2 }\
   mountpoint{ /boot } \
   .   \
-  1200 40 1600 ext4   \
+  975 40 1000 ext4\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ / } \
   .   \
-  800 60 800 ext4 \
+  480 50 700 ext4 \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var }  \
   .   \
-  100 90 200 ext4 \
+  80 90 100 ext4  \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /tmp }  \
   .   \
-  256 100 1024 linux-swap \
+  256 1000 256 linux-swap \
   method{ swap } format{ }\
   .
 
diff --git a/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh 
b/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
index ac48b6b8249..b6de480c4e2 100644
--- a/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
+++ b/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
@@ -23,7 +23,7 @@ set -x
 function fix_tune2fs() {
   for 

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416984#comment-16416984
 ] 

ASF subversion and git services commented on CLOUDSTACK-10341:
--

Commit 986ecfa7e99d0f29b4d7b3cd8065da31695ec00b in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=986ecfa ]

CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables (#2506)

This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables. This also fixes a failing smoke test.

Signed-off-by: Rohit Yadav 

> Systemvmtemplate 4.11 changes
> -
>
> Key: CLOUDSTACK-10341
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10341
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Systemvmtemplate and fail due to low /run memory allocation, the template is 
> slow to copy the size may be further reduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10341) Systemvmtemplate 4.11 changes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416982#comment-16416982
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10341:
-

rhtyd commented on issue #2506: CLOUDSTACK-10341: Reduce systemvmtemplate size, 
install nftables
URL: https://github.com/apache/cloudstack/pull/2506#issuecomment-376792059
 
 
   Test LGTM, failures are due to environment issues or not related to this PR. 
Merging this based on results and two review LGTMs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Systemvmtemplate 4.11 changes
> -
>
> Key: CLOUDSTACK-10341
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10341
> Project: CloudStack
>  Issue Type: Task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
>Priority: Major
> Fix For: 4.12.0.0, 4.11.1.0
>
>
> Systemvmtemplate and fail due to low /run memory allocation, the template is 
> slow to copy the size may be further reduced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)