[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575528#comment-16575528 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411925006 But I should also point out that you are correct in saying that in the event of a failed attempt to create a new snapshot, we should remove the (delta) snapshot from primary storage (as it might act as a false delta if we need to take a future snapshot). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575526#comment-16575526 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411923853 The intention of the code is OK. A volume is being moved from one primary storage to another. If it had any snapshots on the source primary storage, we do not bring them along to the target primary primary storage. Those (primary-side) snapshots only helped in understanding the delta of changes that needed to be copied to secondary storage in the event that another snapshot was taken. Once we move the volume to its new primary storage, we lose knowledge of this delta information (which is OK). If the user asks for a new snapshot of the volume in question, we must take a full snapshot of that volume (but we should leave a new delta snapshot on this primary storage in case yet another snapshot is requested later). The intent of the code is to remove the unused (delta) snapshot that resided on the source primary storage because it is no longer needed. Its mistake is that it not only removes that delta snapshot, but it also removes the entirety of the snapshot (both what might have been on primary storage and what is on secondary storage). This leads to a data loss for the customer. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575496#comment-16575496 ] ASF GitHub Bot commented on CLOUDSTACK-9572: rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411917970 You are right. That code seems to be the other way around. I mean, we should clean when there is a failure, right? At least that is what I understood by the author description. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575494#comment-16575494 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski edited a comment on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411917522 The code to retrieve only primary-storage snapshots is OK. The problem is when the snapshot is given to the Snapshot Service (snapshotSrv.deleteSnapshot(info);). At some point not only does the snapshot on the primary storage get deleted, but so does the snapshot on secondary storage. When I comment out the code in snapshotMgr.cleanupSnapshotsByVolume, everything works the way it used to (meaning the snapshot on the original primary storage is stranded, but the volume is still associated with the correct snapshot on secondary storage). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575495#comment-16575495 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski edited a comment on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411917522 The code to retrieve only primary-storage snapshots is OK. The problem is when the snapshot is given to the Snapshot Service (snapshotSrv.deleteSnapshot(info);). At some point, not only does the snapshot on the primary storage get deleted, but so does the snapshot on secondary storage. When I comment out the code in snapshotMgr.cleanupSnapshotsByVolume, everything works the way it used to (meaning the snapshot on the original primary storage is stranded, but the volume is still associated with the correct snapshot on secondary storage). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575490#comment-16575490
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
mike-tutkowski edited a comment on issue #1740: CLOUDSTACK-9572 Snapshot on
primary storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411916938
From what it looks like, the method is called upon success at least in two
places:
future.complete(res);
} else {
srcVolume.processEvent(Event.OperationSuccessed);
**snapshotMgr.cleanupSnapshotsByVolume(srcVolume.getId());**
future.complete(res);
}
} catch (Exception e) {
} else {
for (Map.Entry entry :
volumeToPool.entrySet()) {
VolumeInfo volume = entry.getKey();
**snapshotMgr.cleanupSnapshotsByVolume(volume.getId());**
volume.processEvent(Event.OperationSuccessed);
}
future.complete(res);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Snapshot on primary storage not cleaned up after Storage migration
> --
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
>Affects Versions: 4.8.0
> Environment: Xen Server
>Reporter: subhash yedugundla
>Priority: Major
> Fix For: 4.8.1
>
>
> Issue Description
> ===
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575489#comment-16575489 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411917522 The code to retrieve only primary-storage snapshots is OK. The problem is when the snapshot is given to the Snapshot Service (snapshotSrv.deleteSnapshot(info);), at some point not only does the snapshot on the primary storage get deleted, but so does the snapshot on secondary storage. When I comment out the code in snapshotMgr.cleanupSnapshotsByVolume, everything works the way it used to (meaning the snapshot on the original primary storage is stranded, but the volume is still associated with the correct snapshot on secondary storage). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575492#comment-16575492
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
mike-tutkowski edited a comment on issue #1740: CLOUDSTACK-9572 Snapshot on
primary storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411916938
From what it looks like, the method is called upon success at least in two
places:
future.complete(res);
} else {
srcVolume.processEvent(Event.OperationSuccessed);
**snapshotMgr.cleanupSnapshotsByVolume(srcVolume.getId());**
future.complete(res);
}
} catch (Exception e) {
**
} else {
for (Map.Entry entry :
volumeToPool.entrySet()) {
VolumeInfo volume = entry.getKey();
**snapshotMgr.cleanupSnapshotsByVolume(volume.getId());**
volume.processEvent(Event.OperationSuccessed);
}
future.complete(res);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Snapshot on primary storage not cleaned up after Storage migration
> --
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
>Affects Versions: 4.8.0
> Environment: Xen Server
>Reporter: subhash yedugundla
>Priority: Major
> Fix For: 4.8.1
>
>
> Issue Description
> ===
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575485#comment-16575485
]
ASF GitHub Bot commented on CLOUDSTACK-9572:
mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary
storage not cleaned up after Stor…
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411916938
From what it looks like, the method is called upon success at least in two
places:
future.complete(res);
} else {
srcVolume.processEvent(Event.OperationSuccessed);
**snapshotMgr.cleanupSnapshotsByVolume(srcVolume.getId());**
future.complete(res);
}
} catch (Exception e) {
@@ -1624,6 +1625,7 @@ public
MigrateVmWithVolumesContext(AsyncCompletionCallback callback, AsyncCal
} else {
for (Map.Entry entry :
volumeToPool.entrySet()) {
VolumeInfo volume = entry.getKey();
**snapshotMgr.cleanupSnapshotsByVolume(volume.getId());**
volume.processEvent(Event.OperationSuccessed);
}
future.complete(res);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Snapshot on primary storage not cleaned up after Storage migration
> --
>
> Key: CLOUDSTACK-9572
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
>Affects Versions: 4.8.0
> Environment: Xen Server
>Reporter: subhash yedugundla
>Priority: Major
> Fix For: 4.8.1
>
>
> Issue Description
> ===
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local
> storage and is transferring this snapshot to secondary storage. But the
> latest snapshot on local storage will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage
> Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and
> is staying on local storage. So local storage will fill up with unneeded
> snapshots.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575403#comment-16575403 ] ASF GitHub Bot commented on CLOUDSTACK-9572: rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411901840 @mike-tutkowski are you sure this problem is caused by this PR? I mean, can you check the code here? The method `snapshotMgr.cleanupSnapshotsByVolume` is only called when there is a failure. Moreover, can you check the method `cleanupSnapshotsByVolume`? If you look there we only list the snapshots in the primary storage (`snapshotFactory.getSnapshots(volumeId, DataStoreRole.Primary)`), which means, the one that failed in the context of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575389#comment-16575389 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411898333 OK, I have been able to reproduce this in a simple environment using only NFS. I create a VM whose root disk resides on an NFS primary storage. I take a snapshot of this root disk. I then migrate the root disk from one NFS primary storage to another. The volume is no longer associated with the snapshot and the removed cell for the snapshot in the cloud.snapshots table has a date in it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575351#comment-16575351 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-411883929 Please note: To get this test to run properly, I had to comment out code in SnapshotManagerImpl.cleanupSnapshotByVolume. If that method is invoked, then any snapshot the volume was associated with prior to the migration of the volume from one primary storage to the next gets deleted. That is a serious problem and seems to have been introduced in #1740. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575349#comment-16575349 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-411883373 Here are the results from the new managed-storage test that is added in this PR: test_online_migrate_volume_from_nfs_storage_to_managed_storage (TestOnlineStorageMigration.TestOnlineStorageMigration) ... === TestName: test_online_migrate_volume_from_nfs_storage_to_managed_storage | Status : SUCCESS === ok test_online_migrate_volume_with_snapshot_from_nfs_storage_to_managed_storage (TestOnlineStorageMigration.TestOnlineStorageMigration) ... === TestName: test_online_migrate_volume_with_snapshot_from_nfs_storage_to_managed_storage | Status : SUCCESS === ok -- Ran 2 tests in 523.545s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575346#comment-16575346 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski edited a comment on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411883027 In fact, one of my tests fails unless I comment out the cleanupSnapshotsByVolume method. The test checks to make sure the volume that is migrated from one primary storage to another is still associated with the snapshot on secondary storage. As it turns out, when cleanupSnapshotByVolume is invoked, the snapshot is completed deleted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575345#comment-16575345 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411883027 In fact, one of my tests fails unless I comment out the cleanupSnapshotsByVolume method. The tests checks to make sure the volume that is migrated from one primary storage to another is still associated with the snapshot on secondary storage. As it turns out, when cleanupSnapshotByVolume is invoked, the snapshot is completed deleted. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575344#comment-16575344 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-411882143 Here is a video that demonstrates this PR: https://www.youtube.com/watch?v=lkVMb6elvz4=12s=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=27 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575342#comment-16575342 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-411881766 @syed Actually, the way it works is that you would invoke the migrateVolume API command. For example, from a line in the tests: Volume.migrate(self.apiClient, livemigrate=True, volumeid=vm_root_volume.id, storageid=self.primary_storage_2.id) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575322#comment-16575322 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - syed commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-411876932 LGTM @mike-tutkowski So supposing I have a volume in a non-managed storage. I just change the disk offering and it would be migrated to managed storage via StorageMotion correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575315#comment-16575315 ] ASF GitHub Bot commented on CLOUDSTACK-9572: mike-tutkowski commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor… URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-411875832 I have noticed that not only is the snapshot on primary storage deleted when cleanupSnapshotsByVolume is invoked, but so is the copy of it that's on secondary storage. Can anyone else reproduce this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshot on primary storage not cleaned up after Storage migration > -- > > Key: CLOUDSTACK-9572 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Storage Controller >Affects Versions: 4.8.0 > Environment: Xen Server >Reporter: subhash yedugundla >Priority: Major > Fix For: 4.8.1 > > > Issue Description > === > 1. Create an instance on the local storage on any host > 2. Create a scheduled snapshot of the volume: > 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local > storage and is transferring this snapshot to secondary storage. But the > latest snapshot on local storage will stay there. This is as expected. > 4. Migrate the instance to another XenServer host with ACS UI and Storage > Live Migration > 5. The Snapshot on the old host on local storage will not be cleaned up and > is staying on local storage. So local storage will fill up with unneeded > snapshots. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
