[jira] [Commented] (CLOUDSTACK-10394) migrateNetwork API doesn't declare networkofferingid as required
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619891#comment-16619891 ] Kris Sterckx commented on CLOUDSTACK-10394: --- Tracked by [https://github.com/apache/cloudstack/issues/2851] Jira issue can be closed as Duplicate > migrateNetwork API doesn't declare networkofferingid as required > > > Key: CLOUDSTACK-10394 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10394 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.11 >Reporter: Kris Sterckx >Assignee: Kris Sterckx >Priority: Major > > See > https://cloudstack.apache.org/api/apidocs-4.11/apis/migrateNetwork.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (CLOUDSTACK-10394) migrateNetwork API doesn't declare networkofferingid as required
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kris Sterckx closed CLOUDSTACK-10394. - Resolution: Duplicate > migrateNetwork API doesn't declare networkofferingid as required > > > Key: CLOUDSTACK-10394 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10394 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API >Affects Versions: 4.11 >Reporter: Kris Sterckx >Assignee: Kris Sterckx >Priority: Major > > See > https://cloudstack.apache.org/api/apidocs-4.11/apis/migrateNetwork.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CLOUDSTACK-10394) migrateNetwork API doesn't declare networkofferingid as required
Kris Sterckx created CLOUDSTACK-10394: - Summary: migrateNetwork API doesn't declare networkofferingid as required Key: CLOUDSTACK-10394 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10394 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: API Affects Versions: 4.11 Reporter: Kris Sterckx Assignee: Kris Sterckx See https://cloudstack.apache.org/api/apidocs-4.11/apis/migrateNetwork.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618993#comment-16618993
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
-
rhtyd commented on issue #2595: CLOUDSTACK-10199: Support requesting a specific
IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-422360990
@blueorangutan test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618995#comment-16618995
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
-
blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-422361165
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618975#comment-16618975
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
-
blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-422358665
Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2303
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10271) detect vulnerabilities in depndencies
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618905#comment-16618905 ] ASF GitHub Bot commented on CLOUDSTACK-10271: - DaanHoogland opened a new pull request #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > detect vulnerabilities in depndencies > - > > Key: CLOUDSTACK-10271 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10271 > Project: CloudStack > Issue Type: Wish > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland >Assignee: Daan Hoogland >Priority: Major > > As a developer I want to know whether and what dependencies I am using that > might harm my users. For this we need to add the owasp dependency checker to > the maven build. It will require more then just this but it is a good first > step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10271) detect vulnerabilities in depndencies
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618904#comment-16618904
]
ASF GitHub Bot commented on CLOUDSTACK-10271:
-
rhtyd closed pull request #2446: CLOUDSTACK-10271 maven plugin for owasp
dependency check added
URL: https://github.com/apache/cloudstack/pull/2446
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pom.xml b/pom.xml
index 7f8d3e0d747..66e60cb6e7c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -65,6 +65,7 @@
2.21.0
3.0.5
3.1.0
+
3.1.1
3.9.0
2.9
2.5.3
@@ -72,6 +73,7 @@
3.7.1
2.21.0
+
1.2.17
1.2.17
@@ -152,6 +154,7 @@
2.0.4
10.1
2.6.4
+2.1.0.1
0.2.0
1.5.1
0.9.11
@@ -577,7 +580,7 @@
org.owasp.esapi
esapi
-2.1.0.1
+${cs.owasp.esapi.version}
@@ -717,6 +720,22 @@
+
+org.owasp
+dependency-check-maven
+
${cs.owasp.dependency-checker-plugin.version}
+
+true
+true
+
+
+
+
+check
+
+
+
+
@@ -1123,6 +1142,18 @@
+
+org.owasp
+dependency-check-maven
+
${cs.owasp.dependency-checker-plugin.version}
+
+
+
+aggregate
+
+
+
+
org.codehaus.mojo
findbugs-maven-plugin
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> detect vulnerabilities in depndencies
> -
>
> Key: CLOUDSTACK-10271
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10271
> Project: CloudStack
> Issue Type: Wish
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Daan Hoogland
>Assignee: Daan Hoogland
>Priority: Major
>
> As a developer I want to know whether and what dependencies I am using that
> might harm my users. For this we need to add the owasp dependency checker to
> the maven build. It will require more then just this but it is a good first
> step.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10271) detect vulnerabilities in depndencies
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618903#comment-16618903 ] ASF GitHub Bot commented on CLOUDSTACK-10271: - rhtyd commented on issue #2446: CLOUDSTACK-10271 maven plugin for owasp dependency check added URL: https://github.com/apache/cloudstack/pull/2446#issuecomment-422344872 @DaanHoogland is this good to go? let me re-kick travis. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > detect vulnerabilities in depndencies > - > > Key: CLOUDSTACK-10271 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10271 > Project: CloudStack > Issue Type: Wish > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Daan Hoogland >Assignee: Daan Hoogland >Priority: Major > > As a developer I want to know whether and what dependencies I am using that > might harm my users. For this we need to add the owasp dependency checker to > the maven build. It will require more then just this but it is a good first > step. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-4045) IP address acquired with associateIpAddress is marked as source NAT, causing disassociateIpAddress to fail later
[ https://issues.apache.org/jira/browse/CLOUDSTACK-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618900#comment-16618900 ] ASF GitHub Bot commented on CLOUDSTACK-4045: rhtyd commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-422344136 can you fix the conflict @houthuis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > IP address acquired with associateIpAddress is marked as source NAT, causing > disassociateIpAddress to fail later > > > Key: CLOUDSTACK-4045 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4045 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0 >Reporter: Murali Reddy >Assignee: Henko Holtzhausen >Priority: Major > Fix For: Future > > > When you can create network, network is in allocated state. when network is > implemented CloudStack implicitly should acquire a public IP for source nat. > But there is assumption that first IP this is associated with network is > always for source NAT IP. So when you do > 1. create network (network is in allocated state) > 2. acquire a public IP and associate with the network > 3. disassociate ip address > #3 will fail because CloudStack marks the IP acquired in #1 to be source NAT. > For users this is counter-intutive because when a IP is acquired, he/she > should be able to release it as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10025) To create a better VNC client for Cloudstack using noVNC
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618898#comment-16618898 ] ASF GitHub Bot commented on CLOUDSTACK-10025: - rhtyd commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-422343457 @syed any updates on this? really looking forward to this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > To create a better VNC client for Cloudstack using noVNC > > > Key: CLOUDSTACK-10025 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10025 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: VNC Proxy >Affects Versions: 4.11.0.0 >Reporter: Sachin >Priority: Minor > Labels: features > > I have implemented this feature as my GSoC'17 project. noVNC is written in > javascript and uses websockets to connect to VNC server. We have modified the > ConsoleProxy server to accept websocket request from noVNC client, which then > forwards the request request to VNC server. > Javascript cannot make plain tcp request, hence the websocket request have to > be forwarded to the VNC server via a proxy server that basically converts > websocket request from client to plain tcp request for VNC server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10106) GPU/vGPU Support on VMWare
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618895#comment-16618895 ] ASF GitHub Bot commented on CLOUDSTACK-10106: - rhtyd commented on issue #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMware URL: https://github.com/apache/cloudstack/pull/2340#issuecomment-422342539 Test LGTM, but I think the code could be further refactored. I'm unable to find time to do that @nitin-maharana but please see parts of the code where you see several ifs-elses, see how you can improve that and also add more tests? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > GPU/vGPU Support on VMWare > -- > > Key: CLOUDSTACK-10106 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10106 > Project: CloudStack > Issue Type: New Feature > Security Level: Public(Anyone can view this level - this is the > default.) > Components: API, UI, VMware >Affects Versions: 4.11.0.0 >Reporter: Nitin Kumar Maharana >Priority: Major > Labels: VMWARE > Fix For: 4.11.0.0 > > > VMware has added support for NVIDIA GRID K1 and NVIDIA GRID K2 cards as well > as NVIDIA Tesla M6 and Tesla M60 cards. This feature allows CloudStack VMs on > ESXi hosts to use the GPU cards connected to it. Currently, it supports only > NVIDIA GRID K1 and K2 cards for CloudStack VMs. > Feature Specification: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681765 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618896#comment-16618896
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
-
blueorangutan commented on issue #2595: CLOUDSTACK-10199: Support requesting a
specific IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-422342563
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10199) Support requesting a specific IPv4 address in Basic Networking during Instance creation
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618891#comment-16618891
]
ASF GitHub Bot commented on CLOUDSTACK-10199:
-
rhtyd commented on issue #2595: CLOUDSTACK-10199: Support requesting a specific
IPv4 address
URL: https://github.com/apache/cloudstack/pull/2595#issuecomment-422342336
@blueorangutan package
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support requesting a specific IPv4 address in Basic Networking during
> Instance creation
> ---
>
> Key: CLOUDSTACK-10199
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10199
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Environment: CloudStack 4.10
>Reporter: Wido den Hollander
>Priority: Major
> Labels: basic-networking
>
> DirectPodBasedNetworkGuru does not support requesting a custom IP-Address
> while creating a new NIC/Instance.
> {quote}
> Error 530: Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null
> {
> "cserrorcode": 4250,
> "errorcode": 530,
> "errortext": "Does not support custom ip allocation at this time:
> NicProfile[0-0-null-null-null",
> "uuidList": []
> }
> {quote}
> Some use-cases prefer the ability to request the IPv4 address which the
> Instance will get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10365) Inconsistent boolean-related method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618541#comment-16618541
]
ASF GitHub Bot commented on CLOUDSTACK-10365:
-
blueorangutan commented on issue #2847: CLOUDSTACK-10365: Change the "getXXX"
boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2847#issuecomment-422270981
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent boolean-related method names
> -
>
> Key: CLOUDSTACK-10365
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> These boolean-return methods are named as "getXXX".
> Other boolean-return methods are named as "isXXX".
> Considering there methods will return boolean values, it should be more clear
> to rename them as "isXXX".
> {code:java}
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getShrinkOk() {
> return shrinkOk;
> }
>
> public boolean getSourceNat() {
> return sourceNat;
> }
>
> public boolean getInternalLb() {
> return internalLb;
> }
>
> public boolean getOfferHA() {
> return offerHA;
> }
>
> public boolean getVolatileVm() {
> return volatileVm;
> }
>
> public boolean getIsUserDefined() {
> return isUserDefined;
> }
>
> public boolean getEnablePassword() {
> return enablePassword;
> }
>
> public boolean getEnableSshKey() {
> return enableSshKey;
> }
>
> public boolean getUuidTranslation() {
> return _doUuidTranslation;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10365) Inconsistent boolean-related method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618540#comment-16618540
]
ASF GitHub Bot commented on CLOUDSTACK-10365:
-
borisstoyanov commented on issue #2847: CLOUDSTACK-10365: Change the "getXXX"
boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2847#issuecomment-422270864
@blueorangutan test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent boolean-related method names
> -
>
> Key: CLOUDSTACK-10365
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> These boolean-return methods are named as "getXXX".
> Other boolean-return methods are named as "isXXX".
> Considering there methods will return boolean values, it should be more clear
> to rename them as "isXXX".
> {code:java}
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getShrinkOk() {
> return shrinkOk;
> }
>
> public boolean getSourceNat() {
> return sourceNat;
> }
>
> public boolean getInternalLb() {
> return internalLb;
> }
>
> public boolean getOfferHA() {
> return offerHA;
> }
>
> public boolean getVolatileVm() {
> return volatileVm;
> }
>
> public boolean getIsUserDefined() {
> return isUserDefined;
> }
>
> public boolean getEnablePassword() {
> return enablePassword;
> }
>
> public boolean getEnableSshKey() {
> return enableSshKey;
> }
>
> public boolean getUuidTranslation() {
> return _doUuidTranslation;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10365) Inconsistent boolean-related method names
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618539#comment-16618539
]
ASF GitHub Bot commented on CLOUDSTACK-10365:
-
blueorangutan commented on issue #2847: CLOUDSTACK-10365: Change the "getXXX"
boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2847#issuecomment-422270417
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2301
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent boolean-related method names
> -
>
> Key: CLOUDSTACK-10365
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10365
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> These boolean-return methods are named as "getXXX".
> Other boolean-return methods are named as "isXXX".
> Considering there methods will return boolean values, it should be more clear
> to rename them as "isXXX".
> {code:java}
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getEnableRRS() {
> return enableRRS;
> }
> public boolean getShrinkOk() {
> return shrinkOk;
> }
>
> public boolean getSourceNat() {
> return sourceNat;
> }
>
> public boolean getInternalLb() {
> return internalLb;
> }
>
> public boolean getOfferHA() {
> return offerHA;
> }
>
> public boolean getVolatileVm() {
> return volatileVm;
> }
>
> public boolean getIsUserDefined() {
> return isUserDefined;
> }
>
> public boolean getEnablePassword() {
> return enablePassword;
> }
>
> public boolean getEnableSshKey() {
> return enableSshKey;
> }
>
> public boolean getUuidTranslation() {
> return _doUuidTranslation;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10380) changing passwordenabled to true while guest vm is running causes unexpected passwordreset again in startvm
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618536#comment-16618536 ] ASF GitHub Bot commented on CLOUDSTACK-10380: - blueorangutan commented on issue #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743#issuecomment-422268709 Trillian test result (tid-3014) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29047 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2743-t3014-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1149.61 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > changing passwordenabled to true while guest vm is running causes unexpected > passwordreset again in startvm > --- > > Key: CLOUDSTACK-10380 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10380 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.12, 4.11.1.0 >Reporter: Raf Smeets >Assignee: Frank Maximus >Priority: Major > > changing passwordenabled to true while guest vm is running causes > passwordreset again in startvm > Steps to reproduce: > # Template passwordenabled flag is set to false > # Start Vm > # Set template passwordenabled flag to true > # StopVm > # ResetPassword for Stopped Vm. Password is PasswordA. > # StartVm. Password is PasswordB. This should not happen!! > # SSH into VM only works with PasswordB. > Next steps are as expected. > # StopVm > # ResetPassword for Stopped Vm. Password is PasswordC. > # 1StartVm. No change in password. > # SSH into VM works with PasswordC. > This was found when > test/integration/plugins/nuagevsp/test_nuage_passwordreset.py started to fail > after merging of PR2651 [https://github.com/apache/cloudstack/pull/2651]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
