[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363791#comment-16363791 ] ASF subversion and git services commented on CLOUDSTACK-10261: -- Commit dee5bb527e7aca4e72e2249b348cca6d688fbe5f in cloudstack's branch refs/heads/master from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=dee5bb5 ] CLOUDSTACK-10261: Libvirt metadata create only one nuage-extension xml tag (#2441) > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360596#comment-16360596 ] ASF subversion and git services commented on CLOUDSTACK-10261: -- Commit dee5bb527e7aca4e72e2249b348cca6d688fbe5f in cloudstack's branch refs/heads/4.11 from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=dee5bb5 ] CLOUDSTACK-10261: Libvirt metadata create only one nuage-extension xml tag (#2441) > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360594#comment-16360594 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364891629 LGTM, merging based on review and test results (ignoring intermittent failures). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360595#comment-16360595 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - rhtyd closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java index 385fe79ef2a..90674eb99a8 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java @@ -1543,16 +1543,15 @@ public void addNuageExtension(String macAddress, String vrIp) { @Override public String toString() { StringBuilder fsBuilder = new StringBuilder(); +fsBuilder.append("\n"); for (Map.Entryaddress : addresses.entrySet()) { -fsBuilder.append("\n") -.append(" \n") -.append("\n"); +fsBuilder.append(" \n"); } -return fsBuilder.toString(); +return fsBuilder.append("\n").toString(); } } diff --git a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java index 006562c213e..b391b94e740 100644 --- a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java +++ b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java @@ -209,4 +209,21 @@ public void testSCSIDef() { assertEquals(str, expected); } +public void testMetadataDef() { +LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef(); + + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1", "ip1"); + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2", "ip2"); + +String xmlDef = metadataDef.toString(); +String expectedXml = "\n" + +"\n" + +" \n" + +" \n" + +"\n" + +"\n"; + +assertEquals(xmlDef, expectedXml); +} + } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360230#comment-16360230 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364817428 Trillian test result (tid-2250) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31012 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2441-t2250-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Failure` | 279.40 | test_vpc_redundant.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.50 | test_host_maintenance.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.79 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360031#comment-16360031 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364770863 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360033#comment-16360033 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364770926 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359782#comment-16359782 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364722003 Trillian test result (tid-2249) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32954 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2441-t2249-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 61 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 140.49 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 146.70 | test_privategw_acl.py test_04_extract_template | `Failure` | 128.32 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_create_volume | `Failure` | 670.33 | test_volumes.py test_06_download_detached_volume | `Failure` | 137.66 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 322.69 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 315.54 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 338.76 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 237.61 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359610#comment-16359610 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364681818 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359605#comment-16359605 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364681742 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359582#comment-16359582 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364679275 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1697 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359520#comment-16359520 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - rhtyd commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364673673 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359521#comment-16359521 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - blueorangutan commented on issue #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441#issuecomment-364673708 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355955#comment-16355955 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - fmaximus opened a new pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355954#comment-16355954 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - DaanHoogland closed pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java index 385fe79ef2a..90674eb99a8 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java @@ -1543,16 +1543,15 @@ public void addNuageExtension(String macAddress, String vrIp) { @Override public String toString() { StringBuilder fsBuilder = new StringBuilder(); +fsBuilder.append("\n"); for (Map.Entryaddress : addresses.entrySet()) { -fsBuilder.append("\n") -.append(" \n") -.append("\n"); +fsBuilder.append(" \n"); } -return fsBuilder.toString(); +return fsBuilder.append("\n").toString(); } } diff --git a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java index 006562c213e..b391b94e740 100644 --- a/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java +++ b/plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java @@ -209,4 +209,21 @@ public void testSCSIDef() { assertEquals(str, expected); } +public void testMetadataDef() { +LibvirtVMDef.MetadataDef metadataDef = new LibvirtVMDef.MetadataDef(); + + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac1", "ip1"); + metadataDef.getMetadataNode(LibvirtVMDef.NuageExtensionDef.class).addNuageExtension("mac2", "ip2"); + +String xmlDef = metadataDef.toString(); +String expectedXml = "\n" + +"\n" + +" \n" + +" \n" + +"\n" + +"\n"; + +assertEquals(xmlDef, expectedXml); +} + } This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10261) Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one interface.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348385#comment-16348385 ] ASF GitHub Bot commented on CLOUDSTACK-10261: - fmaximus opened a new pull request #2441: CLOUDSTACK-10261: Libvirt metadata: only create one nuage-extension tag URL: https://github.com/apache/cloudstack/pull/2441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Nuage: Multinic: Libvirt nuage-extenstion metadata contains only one > interface. > --- > > Key: CLOUDSTACK-10261 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10261 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: cloudstack-agent >Affects Versions: 4.11.0.0 > Environment: Nuage VSP plugin on RHEL 7.4 >Reporter: Frank Maximus >Assignee: Frank Maximus >Priority: Critical > Fix For: 4.11.0.0 > > > When installed ACS 4.11 on top of Rhel7.4 baseimage with libvirt-3.2.0 ,there > is an issue with the metadata of the created VM in cloudstack. > It leads to password reset failure as the nuage vrs is not allowing passage > to DomainRouter. > After debugging , it was found that the nuage-extension in metadata was > missing. > When cloudstack-agent is preparing xml to be sent to openvswitch it contains > metadata with nuage-extension block as follows > > > > > > In /var/log/openvswitch/vm-monitor.log , the received XML of VM is without > nuage-extension block in metadata as follows: > Jan 15 18:17:17 ovs-1 vm-monitor.log: > So the metadata block is now empty. It seems libvirt 3.2.0 requires an url in > its metada, so the libvirt namespace needs to be adapted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)