[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454015#comment-16454015 ] ASF subversion and git services commented on CLOUDSTACK-10288: -- Commit 85203248a4bf8a4c09742ba1c4ae236ee008a15f in cloudstack's branch refs/heads/master from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8520324 ] ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566) * CLOUDSTACK-10289: Config Drive Metadata: Use VM UUID instead of VM id * CLOUDSTACK-10288: Config Drive Userdata: support for binary userdata * CLOUDSTACK-10358: SSH keys are missing on Config Drive disk in some cases > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > Fix For: 4.11.1.0 > > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454021#comment-16454021 ] ASF subversion and git services commented on CLOUDSTACK-10288: -- Commit b3c22df71d0ec3c29fbe37dc3c9812353c1685d9 in cloudstack's branch refs/heads/master from [~rafaelweingartner] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b3c22df ] Forward merge branch '4.11' to master ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566) CLOUDSTACK-9677: Adding storage policy support for swift as secondary storage (#2412) > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > Fix For: 4.11.1.0 > > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454019#comment-16454019 ] ASF subversion and git services commented on CLOUDSTACK-10288: -- Commit 85203248a4bf8a4c09742ba1c4ae236ee008a15f in cloudstack's branch refs/heads/master from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8520324 ] ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566) * CLOUDSTACK-10289: Config Drive Metadata: Use VM UUID instead of VM id * CLOUDSTACK-10288: Config Drive Userdata: support for binary userdata * CLOUDSTACK-10358: SSH keys are missing on Config Drive disk in some cases > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > Fix For: 4.11.1.0 > > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453994#comment-16453994 ] ASF subversion and git services commented on CLOUDSTACK-10288: -- Commit 85203248a4bf8a4c09742ba1c4ae236ee008a15f in cloudstack's branch refs/heads/4.11 from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8520324 ] ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566) * CLOUDSTACK-10289: Config Drive Metadata: Use VM UUID instead of VM id * CLOUDSTACK-10288: Config Drive Userdata: support for binary userdata * CLOUDSTACK-10358: SSH keys are missing on Config Drive disk in some cases > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > Fix For: 4.11.1.0 > > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453999#comment-16453999 ] ASF subversion and git services commented on CLOUDSTACK-10288: -- Commit 85203248a4bf8a4c09742ba1c4ae236ee008a15f in cloudstack's branch refs/heads/4.11 from [~fmaximus] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=8520324 ] ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 (#2566) * CLOUDSTACK-10289: Config Drive Metadata: Use VM UUID instead of VM id * CLOUDSTACK-10288: Config Drive Userdata: support for binary userdata * CLOUDSTACK-10358: SSH keys are missing on Config Drive disk in some cases > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > Fix For: 4.11.1.0 > > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445690#comment-16445690 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-383090688 the error I reported earlier, I could not reproduce. ready for merge fwiw This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445699#comment-16445699 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382670641 @fmaximus I think I found a bug. I will retest but here is the issue: when creating an offering with all options on virtual router except for user data (on configdrive) and creating a template with password enabled it creates a vm in a new network of this new offering type but does not supply the generated password. See the screenshot to see the issue.  I have not been able to reproduce this error, so never mind. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444602#comment-16444602
]
ASF GitHub Bot commented on CLOUDSTACK-10288:
-
nvazquez commented on a change in pull request #2566: ConfigDrive fixes:
CLOUDSTACK-10288, CLOUDSTACK-10289
URL: https://github.com/apache/cloudstack/pull/2566#discussion_r182847446
##
File path: server/src/com/cloud/network/NetworkModelImpl.java
##
@@ -2344,18 +2345,47 @@ public boolean getNetworkEgressDefaultPolicy(Long
networkId) {
}
@Override
-public List generateVmData(String userData, String
serviceOffering, String zoneName,
- String vmName, long vmId, String
publicKey, String password, Boolean isWindows) {
+public List generateVmData(String userData, String
serviceOffering, long datacenterId,
+ String vmName, long vmId, String
vmUuid,
+ String guestIpAddress, String
publicKey, String password, Boolean isWindows) {
+
+DataCenterVO dcVo = _dcDao.findById(datacenterId);
+final String zoneName = dcVo.getName();
+
+IPAddressVO publicIp = _ipAddressDao.findByAssociatedVmId(vmId);
+
final List vmData = new ArrayList();
if (userData != null) {
-vmData.add(new String[]{USERDATA_DIR, USERDATA_FILE, new
String(Base64.decodeBase64(userData),StringUtils.getPreferredCharset())});
+vmData.add(new String[]{USERDATA_DIR, USERDATA_FILE, userData});
}
vmData.add(new String[]{METATDATA_DIR, SERVICE_OFFERING_FILE,
StringUtils.unicodeEscape(serviceOffering)});
vmData.add(new String[]{METATDATA_DIR, AVAILABILITY_ZONE_FILE,
StringUtils.unicodeEscape(zoneName)});
vmData.add(new String[]{METATDATA_DIR, LOCAL_HOSTNAME_FILE,
StringUtils.unicodeEscape(vmName)});
-vmData.add(new String[]{METATDATA_DIR, INSTANCE_ID_FILE, vmName});
-vmData.add(new String[]{METATDATA_DIR, VM_ID_FILE,
String.valueOf(vmId)});
+vmData.add(new String[]{METATDATA_DIR, LOCAL_IPV4_FILE,
guestIpAddress});
+
+String publicIpAddress = guestIpAddress;
+String publicHostName = StringUtils.unicodeEscape(vmName);
+
+if (dcVo.getNetworkType() != DataCenter.NetworkType.Basic) {
+if (publicIp != null) {
+publicIpAddress = publicIp.getAddress().addr();
+publicHostName = publicIp.getAddress().addr();
+} else {
+publicHostName = null;
+}
+}
+vmData.add(new String[]{METATDATA_DIR, PUBLIC_IPV4_FILE,
publicIpAddress});
+vmData.add(new String[]{METATDATA_DIR, PUBLIC_HOSTNAME_FILE,
publicHostName});
+
+if (vmUuid == null) {
+vmData.add(new String[]{METATDATA_DIR, INSTANCE_ID_FILE, vmName});
+vmData.add(new String[]{METATDATA_DIR, VM_ID_FILE,
String.valueOf(vmId)});
+} else {
+vmData.add(new String[]{METATDATA_DIR, INSTANCE_ID_FILE, vmUuid});
+vmData.add(new String[]{METATDATA_DIR, VM_ID_FILE, vmUuid});
+}
+
vmData.add(new String[]{METATDATA_DIR, PUBLIC_KEYS_FILE, publicKey});
Review comment:
As `getSshKey(VirtualMachineProfile profile)` method on
`ConfigDriveNetworkElement` could return null, shouldn't we check here if it is
not null before adding it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Config drive - Usedata corruption when gzipped
> ---
>
> Key: CLOUDSTACK-10288
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Rohit Yadav
>Assignee: Frank Maximus
>Priority: Major
>
> Should be able to create userdata via "echo hi | gzip | base64 -w0" and read
> it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat
> /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444573#comment-16444573
]
ASF GitHub Bot commented on CLOUDSTACK-10288:
-
nvazquez commented on a change in pull request #2566: ConfigDrive fixes:
CLOUDSTACK-10288, CLOUDSTACK-10289
URL: https://github.com/apache/cloudstack/pull/2566#discussion_r182843439
##
File path:
server/test/com/cloud/network/element/ConfigDriveNetworkElementTest.java
##
@@ -236,13 +240,79 @@ public void testGetCapabilities () {
@Test
public void testAddPasswordAndUserdata() throws
InsufficientCapacityException, ResourceUnavailableException {
+List actualVmData = getVmData();
+
+assertThat(actualVmData, containsInAnyOrder(
+new String[]{"userdata", "user_data", VMUSERDATA},
+new String[]{"metadata", "service-offering", VMOFFERING},
+new String[]{"metadata", "availability-zone", ZONENAME},
+new String[]{"metadata", "local-hostname", VMINSTANCENAME},
+new String[]{"metadata", "local-ipv4", "192.168.111.111"},
+new String[]{"metadata", "public-hostname", null},
+new String[]{"metadata", "public-ipv4", "192.168.111.111"},
+new String[]{"metadata", "vm-id", String.valueOf(VMID)},
+new String[]{"metadata", "instance-id", VMINSTANCENAME},
+new String[]{"metadata", "public-keys", PUBLIC_KEY},
+new String[]{"metadata", "cloud-identifier",
String.format("CloudStack-{%s}", CLOUD_ID)},
+new String[]{PASSWORD, "vm_password", PASSWORD}
+));
+}
+
+@Test
+public void testAddPasswordAndUserdataStaticNat() throws
InsufficientCapacityException, ResourceUnavailableException {
+when(_ipAddressDao.findByAssociatedVmId(VMID)).thenReturn(publicIp);
+when(publicIp.getAddress()).thenReturn(new Ip("7.7.7.7"));
+
+List actualVmData = getVmData();
+
+assertThat(actualVmData, containsInAnyOrder(
+new String[]{"userdata", "user_data", VMUSERDATA},
+new String[]{"metadata", "service-offering", VMOFFERING},
+new String[]{"metadata", "availability-zone", ZONENAME},
+new String[]{"metadata", "local-hostname", VMINSTANCENAME},
+new String[]{"metadata", "local-ipv4", "192.168.111.111"},
+new String[]{"metadata", "public-hostname", "7.7.7.7"},
+new String[]{"metadata", "public-ipv4", "7.7.7.7"},
+new String[]{"metadata", "vm-id", String.valueOf(VMID)},
+new String[]{"metadata", "instance-id", VMINSTANCENAME},
+new String[]{"metadata", "public-keys", PUBLIC_KEY},
+new String[]{"metadata", "cloud-identifier",
String.format("CloudStack-{%s}", CLOUD_ID)},
+new String[]{PASSWORD, "vm_password", PASSWORD}
+));
+}
+
+
+@Test
+public void testAddPasswordAndUserdataUuid() throws
InsufficientCapacityException, ResourceUnavailableException {
+when(virtualMachine.getUuid()).thenReturn("vm-uuid");
+
+List actualVmData = getVmData();
+
+assertThat(actualVmData, containsInAnyOrder(
+new String[]{"userdata", "user_data", VMUSERDATA},
+new String[]{"metadata", "service-offering", VMOFFERING},
+new String[]{"metadata", "availability-zone", ZONENAME},
+new String[]{"metadata", "local-hostname", VMINSTANCENAME},
+new String[]{"metadata", "local-ipv4", "192.168.111.111"},
+new String[]{"metadata", "public-hostname", null},
+new String[]{"metadata", "public-ipv4", "192.168.111.111"},
+new String[]{"metadata", "vm-id", "vm-uuid"},
+new String[]{"metadata", "instance-id", "vm-uuid"},
+new String[]{"metadata", "public-keys", PUBLIC_KEY},
+new String[]{"metadata", "cloud-identifier",
String.format("CloudStack-{%s}", CLOUD_ID)},
+new String[]{PASSWORD, "vm_password", PASSWORD}
+));
+}
+
+private List getVmData() throws InsufficientCapacityException,
ResourceUnavailableException {
final Answer answer = mock(Answer.class);
final UserVmDetailVO userVmDetailVO = mock(UserVmDetailVO.class);
when(endpoint.sendMessage(any(HandleConfigDriveIsoCommand.class))).thenReturn(answer);
when(answer.getResult()).thenReturn(true);
when(network.getTrafficType()).thenReturn(Networks.TrafficType.Guest);
when(virtualMachine.getState()).thenReturn(VirtualMachine.State.Stopped);
when(userVmDetailVO.getValue()).thenReturn(PUBLIC_KEY);
+when(nicp.getIPv4Address()).thenReturn("192.168.111.111");
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1646#comment-1646 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382821332 Trillian test result (tid-2519) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 103623 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2566-t2519-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 204.41 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 478.65 | test_privategw_acl.py test_04_restart_network_wo_cleanup | `Failure` | 4.19 | test_routers.py test_01_vpc_site2site_vpn | `Failure` | 336.66 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444015#comment-16444015 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - fmaximus commented on a change in pull request #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#discussion_r182734240 ## File path: test/integration/plugins/nuagevsp/nuage_lib.py ## @@ -0,0 +1,30 @@ +from marvin.cloudstackAPI import createSSHKeyPair, deleteSSHKeyPair Review comment: Fixed in commit 124d091 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444012#comment-16444012 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - fmaximus commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382722192 I found, and fixed another bug, CLOUDSTACK-10358, about SSH keypair not ending up on the configdrive disk in some cases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443785#comment-16443785 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382670641 @fmaximus I think I found a bug. I will retest but here is the issue: when creating an offering with all options on virtual router except for user data (on configdrive) and creating a template with password enabled it creates a vm in a new network of this new offering type but does not supply the generated password. See the screenshot to see the issue.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443674#comment-16443674 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382644500 @rhtyd @rafaelweingartner can you approve of this? I would like to base some new work on it ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442416#comment-16442416 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382368864 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442413#comment-16442413 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382368598 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442363#comment-16442363 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382358880 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1941 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442336#comment-16442336 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382353035 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442334#comment-16442334 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382352827 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437056#comment-16437056 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - DaanHoogland commented on a change in pull request #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#discussion_r181330373 ## File path: test/integration/plugins/nuagevsp/nuage_lib.py ## @@ -0,0 +1,30 @@ +from marvin.cloudstackAPI import createSSHKeyPair, deleteSSHKeyPair Review comment: apache license is missing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437050#comment-16437050
]
ASF GitHub Bot commented on CLOUDSTACK-10288:
-
DaanHoogland commented on a change in pull request #2566: ConfigDrive fixes:
CLOUDSTACK-10288, CLOUDSTACK-10289
URL: https://github.com/apache/cloudstack/pull/2566#discussion_r181329419
##
File path:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##
@@ -480,7 +480,7 @@ public Answer
createConfigDriveIsoForVM(HandleConfigDriveIsoCommand cmd) {
for (String[] item : cmd.getVmData()) {
String dataType = item[CONFIGDATA_DIR];
String fileName = item[CONFIGDATA_FILE];
-String content = item[CONFIGDATA_CONTENT];
+String content = item[CONFIGDATA_CONTENT]; // base64
Review comment:
and remove the comment?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Config drive - Usedata corruption when gzipped
> ---
>
> Key: CLOUDSTACK-10288
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Rohit Yadav
>Assignee: Frank Maximus
>Priority: Major
>
> Should be able to create userdata via "echo hi | gzip | base64 -w0" and read
> it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat
> /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436012#comment-16436012
]
ASF GitHub Bot commented on CLOUDSTACK-10288:
-
rhtyd commented on a change in pull request #2566: ConfigDrive fixes:
CLOUDSTACK-10288, CLOUDSTACK-10289
URL: https://github.com/apache/cloudstack/pull/2566#discussion_r181163582
##
File path:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
##
@@ -480,7 +480,7 @@ public Answer
createConfigDriveIsoForVM(HandleConfigDriveIsoCommand cmd) {
for (String[] item : cmd.getVmData()) {
String dataType = item[CONFIGDATA_DIR];
String fileName = item[CONFIGDATA_FILE];
-String content = item[CONFIGDATA_CONTENT];
+String content = item[CONFIGDATA_CONTENT]; // base64
Review comment:
you can rename the variable to `base64Content`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Config drive - Usedata corruption when gzipped
> ---
>
> Key: CLOUDSTACK-10288
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Affects Versions: 4.11.0.0
>Reporter: Rohit Yadav
>Assignee: Frank Maximus
>Priority: Major
>
> Should be able to create userdata via "echo hi | gzip | base64 -w0" and read
> it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat
> /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435833#comment-16435833 ] ASF GitHub Bot commented on CLOUDSTACK-10288: - blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-380856699 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1911 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Frank Maximus >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10288) Config drive - Usedata corruption when gzipped
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423727#comment-16423727 ] Daan Hoogland commented on CLOUDSTACK-10288: I am lost on this description; $ echo hi | gzip | base64 -w0 does not produce sensible data? Or is it not correctly implemented? the unpack command line does not contain a 'base64 -d' element in the pipe. Is that to be implemented? this would be a client issue. Or should the base64 element be removed from the create command pipe? > Config drive - Usedata corruption when gzipped > --- > > Key: CLOUDSTACK-10288 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10288 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Priority: Major > > Should be able to create userdata via "echo hi | gzip | base64 -w0" and read > it back in VM via "mount -o loop /dev/sr1 /mnt/tmp; cat > /mnt/tmp/cloudstack/userdata/user_data.txt | gunzip" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
