[
https://issues.apache.org/jira/browse/BCEL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528370#comment-14528370
]
Dave Brosius commented on BCEL-173:
---
Sorry for your frustation, in the interim, if you
[
https://issues.apache.org/jira/browse/LANG-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529818#comment-14529818
]
Charles Honton commented on LANG-1127:
--
Yes, as the default system values change, the
GitHub user jacktan1991 opened a pull request:
https://github.com/apache/commons-lang/pull/85
ReflectionToStringBuilder doesn't throw IllegalArgumentException when the
constructor's object param is null
As described in it's
[
https://issues.apache.org/jira/browse/LANG-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Tan updated LANG-1132:
---
Description:
Placeholder for https://github.com/apache/commons-lang/pull/85
{quote}
As described in it's
Jack Tan created LANG-1132:
--
Summary: ReflectionToStringBuilder doesn't throw
IllegalArgumentException when the constructor's object param is null
Key: LANG-1132
URL: https://issues.apache.org/jira/browse/LANG-1132
[
https://issues.apache.org/jira/browse/COMPRESS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529883#comment-14529883
]
Stefan Bodewig commented on COMPRESS-314:
-
I'll create a separate issue for the
Stefan Bodewig created COMPRESS-315:
---
Summary: tar can not write uid or gid = 0x8000
Key: COMPRESS-315
URL: https://issues.apache.org/jira/browse/COMPRESS-315
Project: Commons Compress
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/84#discussion_r29735276
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -4196,7 +4196,8 @@ public static String join(final Iterable? iterable,
final
Github user jacktan1991 commented on the pull request:
https://github.com/apache/commons-lang/pull/85#issuecomment-99330648
Have fixed it. But `ToStringBuilderTest.testReflectionNull` is desigined
like
```java
@Test(expected=IllegalArgumentException.class)
public
[
https://issues.apache.org/jira/browse/LANG-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated LANG-1127:
--
Fix Version/s: (was: Patch Needed)
Discussion
Create a base test for the
[
https://issues.apache.org/jira/browse/LANG-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter reopened LANG-1127:
---
Reopening this issue, since we're still working on the implementation.
Create a base test for
[
https://issues.apache.org/jira/browse/COMPRESS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig updated COMPRESS-314:
Affects Version/s: (was: 1.10)
1.9
Fix Version/s: 1.10
[
https://issues.apache.org/jira/browse/COMPRESS-315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Bodewig resolved COMPRESS-315.
-
Resolution: Fixed
fixed with svn revision 1677921
tar can not write uid or gid =
[
https://issues.apache.org/jira/browse/LANG-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529957#comment-14529957
]
ASF GitHub Bot commented on LANG-1127:
--
Github user coveralls commented on the pull
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/85#issuecomment-99327946
Please fix test failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/76#issuecomment-99328066
[](https://coveralls.io/builds/2496885)
Coverage increased (+0.06%) to 93.37% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/85#issuecomment-99330681
[](https://coveralls.io/builds/2496945)
Coverage increased (+0.0%) to 93.35% when
Benedikt Ritter created MATH-1222:
-
Summary: Use Double.isNaN(double) instead of x != x in FastMath
Key: MATH-1222
URL: https://issues.apache.org/jira/browse/MATH-1222
Project: Commons Math
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529474#comment-14529474
]
ASF GitHub Bot commented on LANG-740:
-
Github user peteryhwong commented on a diff in
Github user peteryhwong commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29721658
--- Diff: src/main/java/org/apache/commons/lang3/concurrent/Memoizer.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529016#comment-14529016
]
ASF GitHub Bot commented on LANG-701:
-
Github user britter commented on the pull
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/84#issuecomment-99235241
[](https://coveralls.io/builds/2494346)
Coverage increased (+0.0%) to 93.35% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/82#issuecomment-99235865
[](https://coveralls.io/builds/2494237)
Coverage decreased (-0.01%) to 93.35% when
Jonathan Nieder created COMPRESS-314:
Summary: TarArchiveInputStream rejects uid or gid = 0x8000
Key: COMPRESS-314
URL: https://issues.apache.org/jira/browse/COMPRESS-314
Project: Commons
[
https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated LANG-1130:
--
Description:
The Apache SonarQube instance shows five major warnings for Commons Lang:
[
https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated LANG-1130:
--
Description:
The Apache SonarQube instance shows five critical warnings for Commons Lang:
Benedikt Ritter created LANG-1131:
-
Summary: StrBuilder.equals(StrBuilder) doesn't check for null
inputs
Key: LANG-1131
URL: https://issues.apache.org/jira/browse/LANG-1131
Project: Commons Lang
[
https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528840#comment-14528840
]
Benedikt Ritter commented on LANG-1130:
---
I've fixed two of the five warnings:
*
[
https://issues.apache.org/jira/browse/MATH-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated MATH-1222:
--
Labels: github (was: )
Use Double.isNaN(double) instead of x != x in FastMath
Benedikt Ritter created LANG-1130:
-
Summary: Fix Sonar warnings
Key: LANG-1130
URL: https://issues.apache.org/jira/browse/LANG-1130
Project: Commons Lang
Issue Type: Task
Affects
[
https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter updated LANG-1130:
--
Summary: Fix critical issues reported by SonarQube (was: Fix Sonar
warnings)
Fix critical
[
https://issues.apache.org/jira/browse/LANG-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved LANG-1131.
---
Resolution: Fixed
Assignee: Benedikt Ritter
Fixed in
[
https://issues.apache.org/jira/browse/MATH-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528717#comment-14528717
]
Benedikt Ritter commented on MATH-1222:
---
Creates a PR
GitHub user eduardomartins-luizalabs opened a pull request:
https://github.com/apache/commons-lang/pull/81
DOC: StringUtils.containsAny. ADD: containsAllWords to StringUtils
Checks if the String contains all words.
```java
StringUtils.containsAllWords(lorem ipsum dolor sit
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99185054
@britter i didn't saw this class, my bad.
Should I send another commit or amend this?
---
If your project is set up for it, you can reply to
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99186498
Usually we make additional commit so that the development of a feature can
be tracked afterwards. Since in this case the commit would change the whole PR,
I think
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99187699
Ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/LANG-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell closed LANG-1129.
---
Resolution: Fixed
Fix Version/s: (was: Patch Needed)
Done.
Remove svn keywords
[
https://issues.apache.org/jira/browse/SCXML-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529115#comment-14529115
]
Benedikt Ritter commented on SCXML-231:
---
It should be no problem to get a GitHub
[
https://issues.apache.org/jira/browse/SCXML-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved SCXML-228.
---
Resolution: Won't Fix
Push current snapshot to maven central
Github user eduardomartins-luizalabs commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/81#discussion_r29704041
--- Diff:
src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java ---
@@ -16,21 +16,16 @@
*/
package
[
https://issues.apache.org/jira/browse/SCXML-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529117#comment-14529117
]
Benedikt Ritter commented on SCXML-228:
---
We don't push snapshots to maven central.
Github user eduardomartins-luizalabs commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99198225
@britter updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/BCEL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528160#comment-14528160
]
Jon Freedman commented on BCEL-173:
---
Java 7 is now in end-of-life no-longer recommended
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99202424
[](https://coveralls.io/builds/2493010)
Coverage increased (+0.01%) to 93.36% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99207396
[](https://coveralls.io/builds/2493019)
Coverage increased (+0.01%) to 93.36% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99201966
[](https://coveralls.io/builds/2492985)
Coverage increased (+0.0%) to 93.35% when
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99202623
[](https://coveralls.io/builds/2493014)
Coverage decreased (-0.0%) to 93.35% when
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528975#comment-14528975
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on the pull
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528976#comment-14528976
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on a diff in the
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29696865
--- Diff:
src/test/java/org/apache/commons/lang3/concurrent/MemoizerTest.java ---
@@ -0,0 +1,112 @@
+package org.apache.commons.lang3.concurrent;
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29696927
--- Diff:
src/test/java/org/apache/commons/lang3/concurrent/MemoizerTest.java ---
@@ -0,0 +1,112 @@
+package org.apache.commons.lang3.concurrent;
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29696898
--- Diff:
src/test/java/org/apache/commons/lang3/concurrent/MemoizerTest.java ---
@@ -0,0 +1,112 @@
+package org.apache.commons.lang3.concurrent;
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528977#comment-14528977
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on a diff in the
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528978#comment-14528978
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on a diff in the
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528980#comment-14528980
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on a diff in the
[
https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved LANG-701.
--
Resolution: Fixed
Fix Version/s: (was: Review Patch)
3.5
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/79#issuecomment-99172436
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrava-luizalabs commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/81#discussion_r29700273
--- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
@@ -1685,7 +1685,7 @@ public static boolean containsAny(final CharSequence
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/81#issuecomment-99181116
This would better fit into ```org.apache.commons.lang3.text.WordUtils```,
because it deals with words. I could imagine having a
[
https://issues.apache.org/jira/browse/LANG-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedikt Ritter resolved LANG-1130.
---
Resolution: Fixed
Fixed in 98220ad03e4b620a98ca355317c9da6c6ac765d1
Fix critical issues
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29696821
--- Diff: src/main/java/org/apache/commons/lang3/concurrent/Computable.java
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/80#issuecomment-99165036
Hello @jamessawle,
thank you for this PR. It looks very good to me. However there are a few
this we need to adjust before I can apply it. Please have a look
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/80#discussion_r29697345
--- Diff:
src/test/java/org/apache/commons/lang3/concurrent/MemoizerTest.java ---
@@ -0,0 +1,112 @@
+package org.apache.commons.lang3.concurrent;
[
https://issues.apache.org/jira/browse/LANG-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528982#comment-14528982
]
ASF GitHub Bot commented on LANG-740:
-
Github user britter commented on a diff in the
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529006#comment-14529006
]
ASF GitHub Bot commented on LANG-701:
-
Github user asfgit closed the pull request at:
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/83
remove compiler warnings from ThreadUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/82
remove compiler warnings of joinWith tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/84
@SuppressWarnings(deprecation) to joinWith, because it uses the
deprecated ObjectUtils.toString(Object) method (which is o.k. to use as
long as commons-lang3 does not require java
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/83#issuecomment-99234742
[](https://coveralls.io/builds/2494291)
Coverage decreased (-0.01%) to 93.35% when
71 matches
Mail list logo
