[jira] [Commented] (LANG-1276) [lang] ArrayIndexOutOfBoundsException StrBuilder replace

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598875#comment-15598875 ] ASF GitHub Bot commented on LANG-1276: -- Github user coveralls commented on the issue:

[jira] [Commented] (LANG-1276) [lang] ArrayIndexOutOfBoundsException StrBuilder replace

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598874#comment-15598874 ] ASF GitHub Bot commented on LANG-1276: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #200: LANG-1276

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/200 [![Coverage Status](https://coveralls.io/builds/8463388/badge)](https://coveralls.io/builds/8463388) Coverage increased (+0.02%) to 93.57% when pulling

[GitHub] commons-lang issue #200: LANG-1276

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/200 [![Coverage Status](https://coveralls.io/builds/8463388/badge)](https://coveralls.io/builds/8463388) Coverage increased (+0.02%) to 93.57% when pulling

[GitHub] commons-lang pull request #200: LANG-1276

2016-10-22 Thread andyklimczak
GitHub user andyklimczak opened a pull request: https://github.com/apache/commons-lang/pull/200 LANG-1276 Fix issue of buf using nonupdated buffer in StrBuilder replaceImpl Avoid array OoB error by keeping variable buf consistent with buffer You can merge this pull request into

[jira] [Commented] (LANG-1276) [lang] ArrayIndexOutOfBoundsException StrBuilder replace

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598867#comment-15598867 ] ASF GitHub Bot commented on LANG-1276: -- GitHub user andyklimczak opened a pull request:

[jira] [Updated] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-1144: --- Attachment: (was: commons-lang.patch) > Multiple calls of >

[jira] [Updated] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-1144: --- Attachment: commons-lang.patch Patch that follows the same double lock idiom. > Multiple calls of >

[jira] [Comment Edited] (POOL-315) GenericObjectPool close() does not wait for the current eviction task

2016-10-22 Thread JIRA
[ https://issues.apache.org/jira/browse/POOL-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597287#comment-15597287 ] Buğra Gedik edited comment on POOL-315 at 10/22/16 7:14 PM: That sounds good as

[jira] [Comment Edited] (POOL-315) GenericObjectPool close() does not wait for the current eviction task

2016-10-22 Thread JIRA
[ https://issues.apache.org/jira/browse/POOL-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597287#comment-15597287 ] Buğra Gedik edited comment on POOL-315 at 10/22/16 7:14 PM: That sounds good as

[jira] [Comment Edited] (POOL-315) GenericObjectPool close() does not wait for the current eviction task

2016-10-22 Thread JIRA
[ https://issues.apache.org/jira/browse/POOL-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597287#comment-15597287 ] Buğra Gedik edited comment on POOL-315 at 10/22/16 7:13 PM: That sounds good as

[jira] [Updated] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LANG-1144: --- Attachment: commons-lang.patch Proposed patch. You could do away with the Null class and just use a

[jira] [Commented] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598136#comment-15598136 ] Gary Gregory commented on LANG-1144: I wish I had paid more attention when this class was added because

[jira] [Comment Edited] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598131#comment-15598131 ] Gary Gregory edited comment on LANG-1144 at 10/22/16 4:48 PM: -- This seems like

[jira] [Commented] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598131#comment-15598131 ] Gary Gregory commented on LANG-1144: This seems like a valid bug report to me. I do not think it

[jira] [Commented] (COMPRESS-327) Support in-memory processing for ZipFile

2016-10-22 Thread Stefan Bodewig (JIRA)
[ https://issues.apache.org/jira/browse/COMPRESS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598120#comment-15598120 ] Stefan Bodewig commented on COMPRESS-327: - applied a modified version of your patch as git

[jira] [Closed] (LANG-1094) Javadoc is not encoding spaces correctly

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed LANG-1094. --- Resolution: Fixed Fix Version/s: 3.5 > Javadoc is not encoding spaces correctly >

[jira] [Commented] (LANG-1094) Javadoc is not encoding spaces correctly

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597985#comment-15597985 ] Pascal Schumacher commented on LANG-1094: - I can confirm that

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-10-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 @Derek-Ashmore Just today I learned that the resetting of the original accessibility of the method I asked you to add is not necessary, because `Method#setAccessible` only modifies

[jira] [Commented] (LANG-1025) Fix Java 8 related problem in site build

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597933#comment-15597933 ] Pascal Schumacher commented on LANG-1025: - I guess that is the only option as clirr seems dead

[jira] [Closed] (LANG-780) Add HashCodeBuilder.append(Enum value)

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed LANG-780. -- Resolution: Won't Fix Fix Version/s: (was: Review Patch) After reading the discussion

[jira] [Closed] (LANG-768) Test jar has the same manifest as production jar

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed LANG-768. -- Resolution: Fixed Assignee: Pascal Schumacher Fix Version/s: (was: Patch

[jira] [Updated] (COMPRESS-327) Support in-memory processing for ZipFile

2016-10-22 Thread Maciej Nowakowski (JIRA)
[ https://issues.apache.org/jira/browse/COMPRESS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maciej Nowakowski updated COMPRESS-327: --- Attachment: SeekableInMemoryByteChannel_tests.patch Added tests for

[jira] [Updated] (LANG-1049) SerializationUtils.deserialize() can not be used within OSGi

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1049: Priority: Major (was: Blocker) > SerializationUtils.deserialize() can not be used within

[jira] [Closed] (LANG-991) Release notes cannot display special characters

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed LANG-991. -- Resolution: Fixed Fix Version/s: (was: Patch Needed) 3.5 should be

[jira] [Commented] (LANG-1047) Add null-safe methods for comparing Charsequences

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597849#comment-15597849 ] Pascal Schumacher commented on LANG-1047: - Since 3.0 a lot of StringUtils methods take

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597838#comment-15597838 ] ASF GitHub Bot commented on LANG-1269: -- Github user coveralls commented on the issue:

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597837#comment-15597837 ] ASF GitHub Bot commented on LANG-1269: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #198: LANG-1269: Wrong name or result of StringUtils#getJ...

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/198 [![Coverage Status](https://coveralls.io/builds/8459485/badge)](https://coveralls.io/builds/8459485) Coverage increased (+0.02%) to 93.57% when pulling

[GitHub] commons-lang issue #198: LANG-1269: Wrong name or result of StringUtils#getJ...

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/198 [![Coverage Status](https://coveralls.io/builds/8459485/badge)](https://coveralls.io/builds/8459485) Coverage increased (+0.02%) to 93.57% when pulling

[jira] [Updated] (LANG-1203) Separated annotations HashCodeExclude and EqualsExclude break the general contract for the hashCode method in java.lang.Object

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1203: Affects Version/s: 3.5 > Separated annotations HashCodeExclude and EqualsExclude break the

[jira] [Closed] (LANG-1216) NumberUtils.isNumber bug

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed LANG-1216. --- Resolution: Fixed Assignee: Pascal Schumacher Fix Version/s: 3.5 Thanks for

[jira] [Comment Edited] (LANG-1216) NumberUtils.isNumber bug

2016-10-22 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597781#comment-15597781 ] Bruno P. Kinoshita edited comment on LANG-1216 at 10/22/16 12:31 PM: -

[jira] [Commented] (LANG-1216) NumberUtils.isNumber bug

2016-10-22 Thread Bruno P. Kinoshita (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597781#comment-15597781 ] Bruno P. Kinoshita commented on LANG-1216: -- Just in case the code changes, here's the code

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597774#comment-15597774 ] ASF GitHub Bot commented on LANG-1269: -- Github user kinow commented on the issue:

[GitHub] commons-lang issue #198: LANG-1269: Wrong name or result of StringUtils#getJ...

2016-10-22 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/198 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Updated] (LANG-1216) NumberUtils.isNumber bug

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1216: Component/s: lang.math.* > NumberUtils.isNumber bug > > >

[GitHub] commons-lang issue #199: LANG-1258: Add ArrayUtils#toStringArray(Object[]) m...

2016-10-22 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/199 Patch looks good. I wonder if the inline if will raise a warning in checkstyle. Other than that, +1 :D --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (LANG-1258) toStringArray(Object[]) method

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597764#comment-15597764 ] ASF GitHub Bot commented on LANG-1258: -- Github user kinow commented on the issue:

[jira] [Commented] (LANG-1258) toStringArray(Object[]) method

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597746#comment-15597746 ] ASF GitHub Bot commented on LANG-1258: -- Github user coveralls commented on the issue:

[jira] [Commented] (LANG-1258) toStringArray(Object[]) method

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597745#comment-15597745 ] ASF GitHub Bot commented on LANG-1258: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #199: LANG-1258: Add ArrayUtils#toStringArray(Object[]) m...

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/199 [![Coverage Status](https://coveralls.io/builds/8459190/badge)](https://coveralls.io/builds/8459190) Coverage increased (+0.04%) to 93.581% when pulling

[GitHub] commons-lang issue #199: LANG-1258: Add ArrayUtils#toStringArray(Object[]) m...

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/199 [![Coverage Status](https://coveralls.io/builds/8459190/badge)](https://coveralls.io/builds/8459190) Coverage increased (+0.04%) to 93.581% when pulling

[GitHub] commons-lang pull request #199: LANG-1258: Add ArrayUtils#toStringArray(Obje...

2016-10-22 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/199 LANG-1258: Add ArrayUtils#toStringArray(Object[]) method patch supplied by IG You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (LANG-1258) toStringArray(Object[]) method

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597739#comment-15597739 ] ASF GitHub Bot commented on LANG-1258: -- GitHub user PascalSchumacher opened a pull request:

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597570#comment-15597570 ] ASF GitHub Bot commented on LANG-1269: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #198: LANG-1269: Wrong name or result of StringUtils#getJ...

2016-10-22 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/198 [![Coverage Status](https://coveralls.io/builds/8458576/badge)](https://coveralls.io/builds/8458576) Coverage increased (+0.004%) to 93.545% when pulling

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597562#comment-15597562 ] ASF GitHub Bot commented on LANG-1269: -- GitHub user PascalSchumacher opened a pull request:

[GitHub] commons-lang pull request #198: LANG-1269: Wrong name or result of StringUti...

2016-10-22 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/198 LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance deprecat StringUtils#getJaroWinklerDistance and add StringUtils#getJaroWinklerSimilarity instead You can merge

[jira] [Commented] (LANG-1269) Wrong name or result of StringUtils::getJaroWinklerDistance

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597540#comment-15597540 ] Pascal Schumacher commented on LANG-1269: - What about deprecating the current method (letting it

[jira] [Comment Edited] (POOL-315) GenericObjectPool close() does not wait for the current eviction task

2016-10-22 Thread JIRA
[ https://issues.apache.org/jira/browse/POOL-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597287#comment-15597287 ] Buğra Gedik edited comment on POOL-315 at 10/22/16 6:30 AM: That sounds good as

[jira] [Commented] (POOL-315) GenericObjectPool close() does not wait for the current eviction task

2016-10-22 Thread JIRA
[ https://issues.apache.org/jira/browse/POOL-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15597287#comment-15597287 ] Buğra Gedik commented on POOL-315: -- That sounds good as a direction. How about modeling it after Java

[jira] [Updated] (LANG-1144) Multiple calls of org.apache.commons.lang3.concurrent.LazyInitializer.initialize() are possible

2016-10-22 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher updated LANG-1144: Priority: Major (was: Critical) > Multiple calls of >