Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/239
@kinow: Thanks for the review. :-)
I also did not know about UN M.49 till yesterday. I just stumbled over this
while analyzing commons-lang test failures on java 9 for
[
https://issues.apache.org/jira/browse/LANG-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Honton resolved LANG-1305.
--
Resolution: Won't Fix
Assignee: Charles Honton
> FastDateFormat in 3.5 failed test of
[
https://issues.apache.org/jira/browse/LANG-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873988#comment-15873988
]
Charles Honton commented on LANG-1305:
--
If you need the colon in the input, then use the 'X' format
[
https://issues.apache.org/jira/browse/LANG-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873893#comment-15873893
]
ASF GitHub Bot commented on LANG-1312:
--
Github user kinow commented on the issue:
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/239
Yesterday learned something new about `String.format` via pull request
#238, and now learning about [UN M.49](https://en.wikipedia.org/wiki/UN_M.49).
Thanks again @PascalSchumacher :-)
[
https://issues.apache.org/jira/browse/LANG-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated LANG-1312:
-
Description:
These all work:
{code:java}
System.out.println(new Locale("en", "001"));
[
https://issues.apache.org/jira/browse/LANG-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pascal Schumacher updated LANG-1305:
Priority: Major (was: Critical)
> FastDateFormat in 3.5 failed test of 3.3.2 while parsing
[
https://issues.apache.org/jira/browse/LANG-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873813#comment-15873813
]
ASF GitHub Bot commented on LANG-1312:
--
Github user coveralls commented on the issue:
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/239
[](https://coveralls.io/builds/10226324)
Coverage increased (+0.02%) to 94.549% when pulling
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/239
[](https://coveralls.io/builds/10226324)
Coverage increased (+0.02%) to 94.549% when pulling
[
https://issues.apache.org/jira/browse/LANG-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873812#comment-15873812
]
ASF GitHub Bot commented on LANG-1312:
--
Github user coveralls commented on the issue:
[
https://issues.apache.org/jira/browse/LANG-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873810#comment-15873810
]
ASF GitHub Bot commented on LANG-1312:
--
GitHub user PascalSchumacher opened a pull request:
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/239
LANG-1312: LocaleUtils#toLocale does not support language followed byâ¦
⦠UN M.49 numeric-3 area code
You can merge this pull request into a Git repository by running:
$ git
[
https://issues.apache.org/jira/browse/LANG-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873757#comment-15873757
]
Pascal Schumacher edited comment on LANG-1265 at 2/19/17 7:13 PM:
--
The
[
https://issues.apache.org/jira/browse/LANG-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873757#comment-15873757
]
Pascal Schumacher edited comment on LANG-1265 at 2/19/17 7:13 PM:
--
The
[
https://issues.apache.org/jira/browse/LANG-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873757#comment-15873757
]
Pascal Schumacher edited comment on LANG-1265 at 2/19/17 7:10 PM:
--
The
Pascal Schumacher created LANG-1312:
---
Summary: LocaleUtils#toLocale does not support language followed
by UN M.49 numeric-3 area code
Key: LANG-1312
URL: https://issues.apache.org/jira/browse/LANG-1312
[
https://issues.apache.org/jira/browse/LANG-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873757#comment-15873757
]
Pascal Schumacher commented on LANG-1265:
-
The FastDateFormat related failures do not occur with
Github user mureinik commented on the issue:
https://github.com/apache/commons-lang/pull/238
Actually, it's worse - If your string contains any other formatter other
than `%n` these methods would throw a `MissingFormatArgumentException`, as you
have no way to pass the arguments to
Github user kinow commented on the issue:
https://github.com/apache/commons-lang/pull/238
Didn't know about this use of `String.format` @PascalSchumacher , thanks :-)
I'm +1 for merging the pull request. Agree it's unlikely, and not sure if
its use was intentional.
---
If
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/238
Thanks for the pull request (and you other pull requests).
This pull request actually slightly changes the behavior of the methods.
There is at least one use for
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/238
[](https://coveralls.io/builds/10223267)
Coverage remained the same at 94.53% when pulling
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/238
Validate's String.format without arguments
While calling `String.format("some string")` without any additional
arguments is not technically wrong, it's redundant, as it just
returns
23 matches
Mail list logo
