[GitHub] commons-lang pull request #246: DateUtilsTest asserts

2017-02-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] commons-lang issue #246: DateUtilsTest asserts

2017-02-27 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/246 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang issue #246: DateUtilsTest asserts

2017-02-27 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/246 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] commons-lang pull request #246: DateUtilsTest asserts

2017-02-27 Thread mureinik
GitHub user mureinik opened a pull request: https://github.com/apache/commons-lang/pull/246 DateUtilsTest asserts Use JUnit's assertFalse for assertions with conditions instead of re-implementing the logic here by testing the condition and throwing an AssertionFailureExceptio

[jira] [Commented] (MATH-1403) Collinearity test: QR Decomposition rank incorrect (SVD ok)

2017-02-27 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885855#comment-15885855 ] Gilles commented on MATH-1403: -- Jama's documentation for says: {noformat} public int rank()

[jira] [Commented] (MATH-1403) Collinearity test: QR Decomposition rank incorrect (SVD ok)

2017-02-27 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885839#comment-15885839 ] Gilles commented on MATH-1403: -- bq. Unfortunately I am not knowledgeable enough to tackle this

[jira] [Commented] (TEXT-64) Investigate locale issue in ExtendedMessageFormatTest

2017-02-27 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885774#comment-15885774 ] Rob Tompkins commented on TEXT-64: -- We are comparing the results from {{java.text.MessageFor

[jira] [Commented] (TEXT-64) Investigate locale issue in ExtendedMessageFormatTest

2017-02-27 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885728#comment-15885728 ] Rob Tompkins commented on TEXT-64: -- The above hypothesis is incorrect. The scenario in which

[jira] [Commented] (MATH-1403) Collinearity test: QR Decomposition rank incorrect (SVD ok)

2017-02-27 Thread Hugo Ferrira (JIRA)
[ https://issues.apache.org/jira/browse/MATH-1403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885640#comment-15885640 ] Hugo Ferrira commented on MATH-1403: Hello Gilles, Thanks for the feedback. Unfortunat