[jira] [Updated] (JEXL-287) Wrong resolution of local variables

2019-01-13 Thread Dmitri Blinov (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitri Blinov updated JEXL-287: --- Description: Consider the following example {code:java} x = 1; if (false) var x = 2; x {code} In this e

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362123 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362069 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362055 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247362048 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361985 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361985 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on a change in pull request #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#discussion_r247361944 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[GitHub] MarkDacek commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

2019-01-13 Thread GitBox
MarkDacek commented on issue #395: Replaces the given String, with the String which is nested in between two Strings. URL: https://github.com/apache/commons-lang/pull/395#issuecomment-453863749 For one, the default return value should be the original `str`, not null. That way, it would be