[GitHub] [commons-csv] ranjithrp edited a comment on issue #46: added ignoreQuoteInToken support to ignore quotes in strings

2019-06-22 Thread GitBox
ranjithrp edited a comment on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-504688145 > Would you mind showing an example with actual expected rows please? It is not clear to me yet if this is a good

[GitHub] [commons-csv] ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings

2019-06-22 Thread GitBox
ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-504688145 > Would you mind showing an example with actual expected rows please? It is not clear to me yet if this is a good thing.

[GitHub] [commons-csv] garydgregory commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings

2019-06-22 Thread GitBox
garydgregory commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-504681751 Would you mind showing an example with actual expected rows please? It is not clear to me yet if this is a good

[GitHub] [commons-csv] ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings

2019-06-22 Thread GitBox
ranjithrp commented on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-504674867 > @ranjithrp , > You'll need to provide unit tests so we can clearly assess what it is you are trying to achieve.

[jira] [Resolved] (NUMBERS-118) Reduce code duplication between BigFractionTest and FractionTest

2019-06-22 Thread Heinrich Bohne (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heinrich Bohne resolved NUMBERS-118. Resolution: Fixed Fix Version/s: 1.0 > Reduce code duplication between

[jira] [Resolved] (NUMBERS-116) Remove redundant methods in ArithmeticUtils

2019-06-22 Thread Heinrich Bohne (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Heinrich Bohne resolved NUMBERS-116. Resolution: Fixed Fix Version/s: 1.0 > Remove redundant methods in ArithmeticUtils

[jira] [Commented] (NUMBERS-118) Reduce code duplication between BigFractionTest and FractionTest

2019-06-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870276#comment-16870276 ] Gilles commented on NUMBERS-118: Merged in commit 860adcdb865842f673ba5010ebcbfd501abcff8b ("master").

[jira] [Work logged] (NUMBERS-118) Reduce code duplication between BigFractionTest and FractionTest

2019-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-118?focusedWorklogId=265283=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265283 ] ASF GitHub Bot logged work on NUMBERS-118: -- Author: ASF GitHub Bot

[GitHub] [commons-numbers] asfgit closed pull request #55: [NUMBERS-118] Reduce code duplication between FractionTest and BigFractionTest

2019-06-22 Thread GitBox
asfgit closed pull request #55: [NUMBERS-118] Reduce code duplication between FractionTest and BigFractionTest URL: https://github.com/apache/commons-numbers/pull/55 This is an automated message from the Apache Git Service.

[jira] [Work logged] (NUMBERS-116) Remove redundant methods in ArithmeticUtils

2019-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-116?focusedWorklogId=265282=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265282 ] ASF GitHub Bot logged work on NUMBERS-116: -- Author: ASF GitHub Bot

[GitHub] [commons-numbers] asfgit closed pull request #52: [NUMBERS-116] Remove redundant methods in org.apache.commons.numbers.core.ArithmeticUtils

2019-06-22 Thread GitBox
asfgit closed pull request #52: [NUMBERS-116] Remove redundant methods in org.apache.commons.numbers.core.ArithmeticUtils URL: https://github.com/apache/commons-numbers/pull/52 This is an automated message from the Apache

[jira] [Commented] (NUMBERS-116) Remove redundant methods in ArithmeticUtils

2019-06-22 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870269#comment-16870269 ] Gilles commented on NUMBERS-116: Merged in commit 7b36cbf23bf5c9cfa9ad29832ae57b99093a55ac ("master").

[GitHub] [commons-csv] coveralls edited a comment on issue #46: added ignoreQuoteInToken support to ignore quotes in strings

2019-06-22 Thread GitBox
coveralls edited a comment on issue #46: added ignoreQuoteInToken support to ignore quotes in strings URL: https://github.com/apache/commons-csv/pull/46#issuecomment-504546849 [![Coverage Status](https://coveralls.io/builds/24146110/badge)](https://coveralls.io/builds/24146110)

[GitHub] [commons-numbers] coveralls edited a comment on issue #56: NUMBERS-119: Correct bug in BigFraction(double) constructor

2019-06-22 Thread GitBox
coveralls edited a comment on issue #56: NUMBERS-119: Correct bug in BigFraction(double) constructor URL: https://github.com/apache/commons-numbers/pull/56#issuecomment-504617374 [![Coverage Status](https://coveralls.io/builds/24145578/badge)](https://coveralls.io/builds/24145578)

[jira] [Work logged] (NUMBERS-119) BigFraction(double) constructor does not treat subnormal numbers correctly

2019-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-119?focusedWorklogId=265236=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265236 ] ASF GitHub Bot logged work on NUMBERS-119: -- Author: ASF GitHub Bot