coveralls edited a comment on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-523302164
[![Coverage
coveralls edited a comment on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-523302164
[![Coverage
YuyuZha0 commented on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524597564
@kinow Thanks for the carefully reviewing ! Nice weekend, isn't it? I will
edit the code later follow your
YuyuZha0 commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317380867
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
YuyuZha0 commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317380836
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915135#comment-16915135
]
Silence Tai commented on LANG-1475:
---
Okay, I understand. Thank you for your reminder.
>
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915133#comment-16915133
]
Bruno P. Kinoshita commented on LANG-1475:
--
Thanks for updating the ticket [~Tai] (I had
kinow commented on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524595539
>At the time, the code used in the list, and the subsequent commits were
improved, so I was concerned at the
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved LANG-1475.
--
Resolution: Fixed
> StringUtils.unwrap incorrect throw StringIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita reopened LANG-1475:
--
Assignee: Bruno P. Kinoshita
> StringUtils.unwrap incorrect throw
Stzx commented on issue #443: Optimize string split methods: 1. Use ThreadLocal
to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524595452
> @Stzx
>
> > I am worried that some problems will still be caused by using the clear
method. such as
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Silence Tai resolved LANG-1475.
---
Resolution: Fixed
> StringUtils.unwrap incorrect throw StringIndexOutOfBoundsException
>
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915130#comment-16915130
]
Silence Tai commented on LANG-1475:
---
In git master.
> StringUtils.unwrap incorrect throw
[
https://issues.apache.org/jira/browse/LANG-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Silence Tai closed LANG-1475.
-
> StringUtils.unwrap incorrect throw StringIndexOutOfBoundsException
>
[
https://issues.apache.org/jira/browse/LANG-1475?focusedWorklogId=300802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300802
]
ASF GitHub Bot logged work on LANG-1475:
Author: ASF GitHub Bot
Stzx commented on a change in pull request #441: [LANG-1475] Fix unwrap
StringIndexOutOfBoundsException
URL: https://github.com/apache/commons-lang/pull/441#discussion_r317379946
##
File path: src/changes/changes.xml
##
@@ -61,6 +61,7 @@ The type attribute can be
[
https://issues.apache.org/jira/browse/LANG-1478?focusedWorklogId=300798=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300798
]
ASF GitHub Bot logged work on LANG-1478:
Author: ASF GitHub Bot
kinow commented on issue #445: LANG-1478 class name abbreviation fix
URL: https://github.com/apache/commons-lang/pull/445#issuecomment-524593280
@verhas I think this and #446 are good to be included in the next release.
Just need you to address the review feedback and update both branches.
kinow merged pull request #447: Fix checkstyle violations (tabs, missing spaces
after commas, missing javadocs)
URL: https://github.com/apache/commons-lang/pull/447
This is an automated message from the Apache Git Service.
kinow commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317378861
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@
kinow commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317378886
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@
kinow commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317378979
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@
kinow commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317378898
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@
kinow commented on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524592946
@jochenw
>@kinow Strongly opposed to accepting this PR: I don't have studied this in
detail, but in my
kinow commented on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524592784
@Stzx
>I am worried that some problems will still be caused by using the clear
method. such as
I
kinow commented on issue #443: Optimize string split methods: 1. Use
ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#issuecomment-524592429
@YuyuZha0
>On my Mac(Intel Core i5, 2.3GHz, openjdk version "11.0.2"), It brings about
17% of
kinow opened a new pull request #447: Fix checkstyle violations (tabs, missing
spaces after commas, missing javadocs)
URL: https://github.com/apache/commons-lang/pull/447
I think some changes slipped with some recent change. Reviewing PR of
contributors, it was quite hard to distinguish
kinow closed pull request #441: [LANG-1475] Fix unwrap
StringIndexOutOfBoundsException
URL: https://github.com/apache/commons-lang/pull/441
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/LANG-1475?focusedWorklogId=300792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300792
]
ASF GitHub Bot logged work on LANG-1475:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1475?focusedWorklogId=300791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300791
]
ASF GitHub Bot logged work on LANG-1475:
Author: ASF GitHub Bot
kinow commented on a change in pull request #441: [LANG-1475] Fix unwrap
StringIndexOutOfBoundsException
URL: https://github.com/apache/commons-lang/pull/441#discussion_r317377957
##
File path: src/changes/changes.xml
##
@@ -61,6 +61,7 @@ The type attribute can be
[
https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=300789=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300789
]
ASF GitHub Bot logged work on LANG-1474:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1474?focusedWorklogId=300790=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300790
]
ASF GitHub Bot logged work on LANG-1474:
Author: ASF GitHub Bot
kinow commented on issue #442: LANG-1474 documentation correction
URL: https://github.com/apache/commons-lang/pull/442#issuecomment-524589254
@verhas tested again today, and same behavior in master. Closing the PR, but
in case you can confirm it's indeed an issue, feel free to re-open and
kinow closed pull request #442: LANG-1474 documentation correction
URL: https://github.com/apache/commons-lang/pull/442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915110#comment-16915110
]
Bruno P. Kinoshita commented on LANG-1480:
--
See comment for LANG-1478, on whether this should go
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated LANG-1480:
-
Assignee: Bruno P. Kinoshita
> ClassUtils. getAbbreviatedName(String ,int) returns too
kinow commented on issue #445: LANG-1478 class name abbreviation fix
URL: https://github.com/apache/commons-lang/pull/445#issuecomment-524589141
@Stzx
>I think I should add javaDoc at the same time, add a new example.
+1, added a review comment for @verhas . And @verhas ,
[
https://issues.apache.org/jira/browse/LANG-1478?focusedWorklogId=300788=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300788
]
ASF GitHub Bot logged work on LANG-1478:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300785=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300785
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300786
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
kinow edited a comment on issue #446: LANG-1480 getAbbreviatedName refactored
to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-524588806
I think you need to include tests for this change. See the bot comment about
coverage decreasing. Can we
kinow edited a comment on issue #446: LANG-1480 getAbbreviatedName refactored
to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-524588806
I think you need to include tests for this change. See the bot comment about
coverage decreasing. Can we
kinow commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317377567
##
File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
##
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300784=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300784
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915109#comment-16915109
]
Bruno P. Kinoshita commented on LANG-1478:
--
Sent a message to the mailing list, asking whether
kinow commented on issue #446: LANG-1480 getAbbreviatedName refactored to
create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-524588806
I think you need to include tests for this change. See the bot comment about
coverage decreasing, and a comment
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300783=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300783
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300780=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300780
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300781
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=300782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300782
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
kinow commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317376951
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@
kinow commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317377606
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@
kinow commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317377567
##
File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
##
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated LANG-1478:
-
Assignee: Bruno P. Kinoshita
> ClassUtils getAbbreviatedName uses len one character
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated LANG-1478:
-
Affects Version/s: 3.9
> ClassUtils getAbbreviatedName uses len one character shorter
>
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915106#comment-16915106
]
Bruno P. Kinoshita commented on LANG-1478:
--
Oh, I see what you mean.
{code:java}
kinow merged pull request #439: Improvement JavaVersion get method
URL: https://github.com/apache/commons-lang/pull/439
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kinow merged pull request #425: RandomUtils : comment error
URL: https://github.com/apache/commons-lang/pull/425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/JEXL-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Biestro resolved JEXL-312.
Resolution: Fixed
Changeset: 71d185007d8ba0a935fe4ac084822784a19bcffa
Author:henrib
Date:
Henri Biestro created JEXL-312:
--
Summary: @NoJexl fails to disallow method call
Key: JEXL-312
URL: https://issues.apache.org/jira/browse/JEXL-312
Project: Commons JEXL
Issue Type: Bug
[
https://issues.apache.org/jira/browse/MATH-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914937#comment-16914937
]
Gilles commented on MATH-1490:
--
I've done it. So:
{noformat}
$ git diff MATH_3_3 MATH_3_4 --
dimitrovchi commented on issue #437: Add GenericArrayType support to
TypeUtils.containsTypeVariables
URL: https://github.com/apache/commons-lang/pull/437#issuecomment-524529307
The same **false-positive** build failure happened to
https://travis-ci.org/apache/commons-lang/jobs/575873214
dimitrovchi commented on issue #437: Add GenericArrayType support to
TypeUtils.containsTypeVariables
URL: https://github.com/apache/commons-lang/pull/437#issuecomment-524529097
I've added the test: https://github.com/apache/commons-lang/pull/437/files
Please look at CI logs again: the
64 matches
Mail list logo
