[GitHub] [commons-geometry] acid1103 commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

acid1103 commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r327889925 ## File path:

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937286#comment-16937286 ] Matt Juntunen commented on GEOMETRY-46: --- This PR is ready to go. > Additional UnitVector methods

[jira] [Work logged] (POOL-376) invalidateObject should not return NullPointerException

[ https://issues.apache.org/jira/browse/POOL-376?focusedWorklogId=317927=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317927 ] ASF GitHub Bot logged work on POOL-376: --- Author: ASF GitHub Bot

[jira] [Work logged] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

[ https://issues.apache.org/jira/browse/POOL-356?focusedWorklogId=317926=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317926 ] ASF GitHub Bot logged work on POOL-356: --- Author: ASF GitHub Bot

[GitHub] [commons-pool] psteitz merged pull request #25: POOL-356 and POOL-376

psteitz merged pull request #25: POOL-356 and POOL-376 URL: https://github.com/apache/commons-pool/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [commons-pool] psteitz closed pull request #24: POOL-376 invalidateObject should not throw NPE

psteitz closed pull request #24: POOL-376 invalidateObject should not throw NPE URL: https://github.com/apache/commons-pool/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r327887113 ## File path:

[GitHub] [commons-geometry] acid1103 commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

acid1103 commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r327886108 ## File path:

[jira] [Commented] (GEOMETRY-60) JDK 13 Build Fails

[ https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937271#comment-16937271 ] Matt Juntunen commented on GEOMETRY-60: --- So, what changes are you proposing here? I'd like to get

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937269#comment-16937269 ] Matt Juntunen commented on GEOMETRY-46: --- I added some small comments in github on the PR related

[GitHub] [commons-geometry] darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods

darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#issuecomment-534791241 I don't think any more tests are necessary since the changes are so simple.

[GitHub] [commons-geometry] darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods

darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#issuecomment-534790726 Thanks for the PR! I added a couple of nit-picky comments but it otherwise looks great.

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r327879599 ## File path:

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r327879251 ## File path:

[jira] [Resolved] (NET-673) IMAPClient.APPEND does not always calculate the correct length

[ https://issues.apache.org/jira/browse/NET-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved NET-673. -- Resolution: Fixed commit 33d23d6b6a3201cc3ffe2eb16a0e8a1a4a4b4c8a NET-673 IMAPClient.APPEND does not always

[jira] [Created] (NET-673) IMAPClient.APPEND does not always calculate the correct length

Sebb created NET-673: Summary: IMAPClient.APPEND does not always calculate the correct length Key: NET-673 URL: https://issues.apache.org/jira/browse/NET-673 Project: Commons Net Issue Type: Bug

[GitHub] [commons-rng] coveralls edited a comment on issue #67: RNG-116: RandomSource to expose supported interfaces.

coveralls edited a comment on issue #67: RNG-116: RandomSource to expose supported interfaces. URL: https://github.com/apache/commons-rng/pull/67#issuecomment-534260653 [](https://coveralls.io/builds/25907921)

[GitHub] [commons-rng] aherbert commented on issue #67: RNG-116: RandomSource to expose supported interfaces.

aherbert commented on issue #67: RNG-116: RandomSource to expose supported interfaces. URL: https://github.com/apache/commons-rng/pull/67#issuecomment-534757581 Dropped method: public int getSeedByteSize(); Exposing the byte size of the seed allows seed construction as a raw

[jira] [Updated] (GEOMETRY-46) Additional UnitVector methods

[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEOMETRY-46: --- Labels: easyfix pull-request-available starter (was: easyfix starter) > Additional

[GitHub] [commons-geometry] acid1103 opened a new pull request #39: GEOMETRY-46: Add additional UnitVector methods

acid1103 opened a new pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39 This should resolve [GEOMETRY-46](https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-46?filter=allopenissues). Are there any tests

[jira] [Updated] (BCEL-291) Verifier rejects invokevirtual on array: org.apache.bcel.generic.ClassGenException: [Ljava/lang/Object; does not represent an ObjectType

[ https://issues.apache.org/jira/browse/BCEL-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated BCEL-291: -- Fix Version/s: (was: 6.4.0) 6.4.1 > Verifier rejects invokevirtual on array: >

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327640858 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/CountingBloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327640382 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327641887 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327642152 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325403761 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325404103 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327642368 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327640148 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327646194 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327646708 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/ProtoBloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325403610 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327647091 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/ProtoBloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325403976 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327640675 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/CountingBloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327641989 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327642206 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327642713 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/ProtoBloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325404275 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r327642067 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution

garydgregory commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r325403162 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=317512=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317512 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=317510=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317510 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1480) ClassUtils. getAbbreviatedName(String ,int) returns too long result

[ https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=317509=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317509 ] ASF GitHub Bot logged work on LANG-1480: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r327637992 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java

[GitHub] [commons-lang] garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r327638102 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java

[GitHub] [commons-lang] garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length …

garydgregory commented on a change in pull request #446: LANG-1480 getAbbreviatedName refactored to create appropriate length … URL: https://github.com/apache/commons-lang/pull/446#discussion_r327638057 ## File path: src/test/java/org/apache/commons/lang3/ClassUtilsTest.java

[jira] [Commented] (BEANUTILS-523) Release 1.9.4 has broken every single OSGi installation out there which uses it through Require-Bundle

[ https://issues.apache.org/jira/browse/BEANUTILS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936692#comment-16936692 ] Melloware commented on BEANUTILS-523: - [~chtompki] Any thought on this one? > Release 1.9.4 has

[jira] [Commented] (VALIDATOR-459) Allow UrlValidator/DomainValidator to skip the TLD validation

[ https://issues.apache.org/jira/browse/VALIDATOR-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936568#comment-16936568 ] Gilles commented on VALIDATOR-459: -- Feature request and discussion should be posted on the "dev" ML.

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Description: {{GenericObjectPool.invalidateObject(T obj)}} should not return

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Priority: Critical (was: Major) > invalidateObject should not return NullPointerException >

[jira] [Commented] (VALIDATOR-459) Allow UrlValidator/DomainValidator to skip the TLD validation

[ https://issues.apache.org/jira/browse/VALIDATOR-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936562#comment-16936562 ] Michael Osipov commented on VALIDATOR-459: -- {{.local}} is a reserved domain for special

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Labels: pull-request-available pull-requests-available (was: ) > invalidateObject should not

[GitHub] [commons-imaging] kinow merged pull request #52: Fix javadoc for Java 13 (heading out of order)

kinow merged pull request #52: Fix javadoc for Java 13 (heading out of order) URL: https://github.com/apache/commons-imaging/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Issue Type: Bug (was: Improvement) > invalidateObject should not return NullPointerException >

[GitHub] [commons-imaging] coveralls edited a comment on issue #52: Fix javadoc for Java 13 (heading out of order)

coveralls edited a comment on issue #52: Fix javadoc for Java 13 (heading out of order) URL: https://github.com/apache/commons-imaging/pull/52#issuecomment-522304064 [](https://coveralls.io/builds/25890339) Coverage

[GitHub] [commons-imaging] kinow commented on issue #52: Fix javadoc for Java 13 (heading out of order)

kinow commented on issue #52: Fix javadoc for Java 13 (heading out of order) URL: https://github.com/apache/commons-imaging/pull/52#issuecomment-534442113 Related issue in the JDK https://bugs.openjdk.java.net/browse/JDK-8223552

[GitHub] [commons-imaging] kinow closed pull request #53: Close OutputStream before toByteArray() on underlying ByteArrayOutputStream

kinow closed pull request #53: Close OutputStream before toByteArray() on underlying ByteArrayOutputStream URL: https://github.com/apache/commons-imaging/pull/53 This is an automated message from the Apache Git Service. To

[GitHub] [commons-imaging] kinow commented on issue #53: Close OutputStream before toByteArray() on underlying ByteArrayOutputStream

kinow commented on issue #53: Close OutputStream before toByteArray() on underlying ByteArrayOutputStream URL: https://github.com/apache/commons-imaging/pull/53#issuecomment-534433388 Closing as per comment above. I've added a comment (b684eea67f98010b67db9587dbfb0b1a2d02bb1a) to let