[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439889 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [![Coverage Status](https://coveralls.io/builds/31176899/badge)](https://coveralls.io/builds/31176899) Coverage increased (+0.005%) to 95.046% when pulling

[GitHub] [commons-text] kinow commented on pull request #128: Add word-wise comparator

2020-06-01 Thread GitBox
kinow commented on pull request #128: URL: https://github.com/apache/commons-text/pull/128#issuecomment-637259210 @aeon-fruit sorry for the delay. The code looks really good from an initial quick look. Will try to review it the next time I have spare time to work on [text], so that we can

[GitHub] [commons-text] kinow commented on pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2020-06-01 Thread GitBox
kinow commented on pull request #103: URL: https://github.com/apache/commons-text/pull/103#issuecomment-637259000 @ameyjadiye whenever you have time to update this PR, I will have another look and try to review/merge it :+1: thanks!

[jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=439881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439881 ] ASF GitHub Bot logged work on TEXT-126: --- Author: ASF GitHub Bot

[jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=439880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439880 ] ASF GitHub Bot logged work on TEXT-126: --- Author: ASF GitHub Bot

[GitHub] [commons-text] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2020-06-01 Thread GitBox
kinow commented on a change in pull request #103: URL: https://github.com/apache/commons-text/pull/103#discussion_r433608502 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDiceSimilarity.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [![Coverage Status](https://coveralls.io/builds/31175823/badge)](https://coveralls.io/builds/31175823) Coverage decreased (-0.02%) to 95.02% when pulling

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439871 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439867 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclusion:** In cases for small content readers, the new function is slightly faster. but in cases for large content,

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439866 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory **Conclusion:** after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ comm

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439861 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439862 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-la

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439860 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [![Coverage Status](https://coveralls.io/builds/31174768/badge)](https://coveralls.io/builds/31174768) Coverage decreased (-0.008%) to 95.033% when pulling

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439857 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[jira] [Commented] (CODEC-289) Base32/64Input/OutputStream to allow optional strict/lenient decoding

2020-06-01 Thread venkata ramana reddy L (Jira)
[ https://issues.apache.org/jira/browse/CODEC-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121448#comment-17121448 ] venkata ramana reddy L commented on CODEC-289: -- [~aherbert] - When is the rel

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439822 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [![Coverage Status](https://coveralls.io/builds/31173743/badge)](https://coveralls.io/builds/31173743) Coverage increased (+0.1%) to 89.845% when pulling **

[jira] [Resolved] (BCEL-339) Throw IllegalArgumentException, IllegalStateException, UnsupportedOperationException instead of RuntimeException

2020-06-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved BCEL-339. -- Fix Version/s: 6.5.0 Resolution: Fixed > Throw IllegalArgumentException, IllegalStateExcep

[jira] [Created] (BCEL-339) Throw IllegalArgumentException, IllegalStateException, UnsupportedOperationException instead of RuntimeException

2020-06-01 Thread Gary D. Gregory (Jira)
Gary D. Gregory created BCEL-339: Summary: Throw IllegalArgumentException, IllegalStateException, UnsupportedOperationException instead of RuntimeException Key: BCEL-339 URL: https://issues.apache.org/jira/browse/

[jira] [Resolved] (BCEL-338) org.apache.bcel.generic.InstructionFactory.createInvoke() populates its internal ConstantPoolGen on bad input, then throws exception

2020-06-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved BCEL-338. -- Fix Version/s: 6.4.2 Resolution: Fixed > org.apache.bcel.generic.InstructionFactory.create

[jira] [Created] (BCEL-338) org.apache.bcel.generic.InstructionFactory.createInvoke() populates its internal ConstantPoolGen on bad input, then throws exception

2020-06-01 Thread Gary D. Gregory (Jira)
Gary D. Gregory created BCEL-338: Summary: org.apache.bcel.generic.InstructionFactory.createInvoke() populates its internal ConstantPoolGen on bad input, then throws exception Key: BCEL-338 URL: https://issues.apa

[GitHub] [commons-bcel] garydgregory merged pull request #40: add attribute name(s) to Code.toString()

2020-06-01 Thread GitBox
garydgregory merged pull request #40: URL: https://github.com/apache/commons-bcel/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (COMPRESS-514) SevenZFile fails with encoded header over 2GiB

2020-06-01 Thread A Kelday (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121361#comment-17121361 ] A Kelday commented on COMPRESS-514: --- Thanks [~bodewig] and [~peterlee] for the input.

[GitHub] [commons-bcel] garydgregory merged pull request #39: add support for invokestatic of an InterfaceMethodref

2020-06-01 Thread GitBox
garydgregory merged pull request #39: URL: https://github.com/apache/commons-bcel/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637099087 @garydgregory If you look at java.io.InputStream source code - the default is to throw an exception when reset is called if mark is unsupported... so I am just following the

[GitHub] [commons-io] adamretter edited a comment on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter edited a comment on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637099087 @garydgregory If you look at `java.io.InputStream` source code - the default is to throw an exception when reset is called if mark is unsupported... so I am just foll

[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
garydgregory commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-637090936 Yeah, this gets tricky and arbitrary: the class is called "MarkShield" which reimplements `mark()` as a noop but it also reimplements `reset()` to throw an `IOException`,

[jira] [Commented] (LANG-1544) MethodUtils.invokeMethod NullPointerException in case of null in args list

2020-06-01 Thread Robert Konior (Jira)
[ https://issues.apache.org/jira/browse/LANG-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121314#comment-17121314 ] Robert Konior commented on LANG-1544: - Can I do this ? :) > MethodUtils.invokeMethod

[jira] [Work logged] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1550?focusedWorklogId=439709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439709 ] ASF GitHub Bot logged work on LANG-1550: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls commented on pull request #551: [LANG-1550] Optimize ArrayUtils::isArrayIndexValid method.

2020-06-01 Thread GitBox
coveralls commented on pull request #551: URL: https://github.com/apache/commons-lang/pull/551#issuecomment-637077665 [![Coverage Status](https://coveralls.io/builds/31168883/badge)](https://coveralls.io/builds/31168883) Coverage decreased (-0.0006%) to 95.04% when pulling **2f8

[GitHub] [commons-csv] garydgregory merged pull request #74: Use license instead of licence

2020-06-01 Thread GitBox
garydgregory merged pull request #74: URL: https://github.com/apache/commons-csv/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.

2020-06-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121307#comment-17121307 ] Gary D. Gregory commented on LANG-1550: --- I do not understand; if you could demonstra

[jira] [Resolved] (CSV-195) Parser iterates over the last CSV Record twice.

2020-06-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CSV-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CSV-195. - Fix Version/s: (was: Patch Needed) 1.9 Resolution: Fixed In git master

[jira] [Work logged] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1550?focusedWorklogId=439701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439701 ] ASF GitHub Bot logged work on LANG-1550: Author: ASF GitHub Bot

[GitHub] [commons-lang] nstdio opened a new pull request #551: [LANG-1550] Optimize ArrayUtils::isArrayIndexValid method.

2020-06-01 Thread GitBox
nstdio opened a new pull request #551: URL: https://github.com/apache/commons-lang/pull/551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Resolved] (CSV-149) Line number is not proper at EOF

2020-06-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CSV-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CSV-149. - Fix Version/s: (was: Patch Needed) 1.9 Resolution: Fixed In git master

[jira] [Work logged] (CSV-149) Line number is not proper at EOF

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CSV-149?focusedWorklogId=439699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439699 ] ASF GitHub Bot logged work on CSV-149: -- Author: ASF GitHub Bot

[GitHub] [commons-csv] garydgregory merged pull request #60: Fix CSV-149 and CSV-195

2020-06-01 Thread GitBox
garydgregory merged pull request #60: URL: https://github.com/apache/commons-csv/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (LANG-1550) Method ArrayUtils::isArrayIndexValid not optimized.

2020-06-01 Thread Edgar Asatryan (Jira)
Edgar Asatryan created LANG-1550: Summary: Method ArrayUtils::isArrayIndexValid not optimized. Key: LANG-1550 URL: https://issues.apache.org/jira/browse/LANG-1550 Project: Commons Lang Issue

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439695 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [![Coverage Status](https://coveralls.io/builds/31168325/badge)](https://coveralls.io/builds/31168325) Coverage increased (+0.1%) to 89.845% when pulling **

[GitHub] [commons-imaging] changbaishan commented on pull request #50: Need *.webp type images reader and writer

2020-06-01 Thread GitBox
changbaishan commented on pull request #50: URL: https://github.com/apache/commons-imaging/pull/50#issuecomment-637058596 Is there way I can release myself from this PR? I witnessed wonderful works you did. However, I opened it just to suggest a useful feature. I had no idea of what it act

[GitHub] [commons-imaging] changbaishan closed pull request #50: Need *.webp type images reader and writer

2020-06-01 Thread GitBox
changbaishan closed pull request #50: URL: https://github.com/apache/commons-imaging/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread JIN XU (Jira)
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JIN XU updated IO-670: -- Attachment: jmh-result.org.apache.json > IOUtils.contentEquals is of low performance. I will refine it. > -

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439679&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439679 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] coveralls edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [![Coverage Status](https://coveralls.io/builds/31167650/badge)](https://coveralls.io/builds/31167650) Coverage increased (+0.05%) to 89.766% when pulling *

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439677 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439676&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439676 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637036540 result json: ``` [ { "jmhVersion" : "1.21", "benchmark" : "org.apache.commons.io.performance.IOUtilsContentEqualsPerformanceTest.testContent

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439674 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439672 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637035997 @garydgregory Performance test done. **Conclution:** In cases for small content readers, the new function is slightly faster. but in cases for large content, the ne

[GitHub] [commons-beanutils] fborriello closed pull request #20: [BEANUTILS-524] Copy properties improvement

2020-06-01 Thread GitBox
fborriello closed pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-beanutils] fborriello commented on pull request #20: [BEANUTILS-524] Copy properties improvement

2020-06-01 Thread GitBox
fborriello commented on pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20#issuecomment-637014234 Yes, I agree This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439634 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-637013520 @garydgregory BTW, how can I show the performance result generated? simply paste it here? This is an auto

[GitHub] [commons-beanutils] melloware commented on pull request #20: [BEANUTILS-524] Copy properties improvement

2020-06-01 Thread GitBox
melloware commented on pull request #20: URL: https://github.com/apache/commons-beanutils/pull/20#issuecomment-636997754 @fborriello I think this PR can be closed as it is not going to be merged. This is an automated message

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439615 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636996577 @garydgregory I will use this as example and change its content and add the test into this repo if you don't mind. https://github.com/apache/commons-lang/blob/5cdac9cfd

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439613 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 @garydgregory > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a

[GitHub] [commons-io] coveralls commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
coveralls commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636994860 [![Coverage Status](https://coveralls.io/builds/31165252/badge)](https://coveralls.io/builds/31165252) Coverage increased (+0.07%) to 89.791% when pulling **dc199b

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439612 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636994263 > @XenoAmess > > * When you create a PR, please do not leave the description empty. It makes it harder to review. OK > * If a PR claims a performance impr

[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
garydgregory commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636991133 We work hard to avoid breaking binary compatibility. Instead, we mark code as deprecated and that code can then be considered for removal for the next major version, which

[GitHub] [commons-io] garydgregory commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
garydgregory commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636989562 @XenoAmess - When you create a PR, please do not leave the description empty. It makes it harder to review. - If a PR claims a performance improvement, it must back

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439600&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439600 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] adamretter edited a comment on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter edited a comment on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636984631 @garydgregory Hmm I had not thought of that. Personally I prefer to have the separate classes... but I can refactor it if that's what is needed? What would happ

[GitHub] [commons-io] adamretter commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636984631 @garydgregory Hmm I had not thought of that. Personally I prefer to have the separate classes... but I can refactor it if that's what is needed? What would happen to t

[GitHub] [commons-io] garydgregory commented on pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
garydgregory commented on pull request #119: URL: https://github.com/apache/commons-io/pull/119#issuecomment-636981406 Before we need one more and one more shield types of ProxyInputStreams, shouldn't we consider a more general shield class that takes an enum {CLOSE, MARK, THIS, THAT} so w

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439599 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] coveralls commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
coveralls commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636980413 [![Coverage Status](https://coveralls.io/builds/31164655/badge)](https://coveralls.io/builds/31164655) Coverage decreased (-0.001%) to 89.718% when pulling **73dc0

[GitHub] [commons-io] adamretter opened a new pull request #119: Add a MarkShieldInputStream

2020-06-01 Thread GitBox
adamretter opened a new pull request #119: URL: https://github.com/apache/commons-io/pull/119 This is similar to the `CloseShieldInputStream` but it focuses on the mark, markSupported, and reset methods. This is an a

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439594 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636974841 I also want to change other contentEquals functions in IOUtils (using similar way), but I want to listen to your advices first. -

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439590 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[jira] [Updated] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread JIN XU (Jira)
[ https://issues.apache.org/jira/browse/IO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JIN XU updated IO-670: -- Description: [https://github.com/apache/commons-io/pull/118] > IOUtils.contentEquals is of low performance. I will refine i

[jira] [Work logged] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/IO-670?focusedWorklogId=439589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439589 ] ASF GitHub Bot logged work on IO-670: - Author: ASF GitHub Bot Cre

[GitHub] [commons-io] XenoAmess edited a comment on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test case to show the performance? This is an automated message from the Apa

[GitHub] [commons-io] XenoAmess commented on pull request #118: [IO-670] refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess commented on pull request #118: URL: https://github.com/apache/commons-io/pull/118#issuecomment-636971532 need I make a performance test? This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [commons-io] XenoAmess opened a new pull request #118: refine IOUtils.contentEquals(Reader, Reader)

2020-06-01 Thread GitBox
XenoAmess opened a new pull request #118: URL: https://github.com/apache/commons-io/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-lang] XenoAmess edited a comment on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more f

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439585 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[GitHub] [commons-lang] XenoAmess commented on pull request #534: [LANG-1548] split regionMatches for better performance

2020-06-01 Thread GitBox
XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to 72 Hour Lazy Consensus rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions

[jira] [Work logged] (LANG-1548) split regionMatches for better performance

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439584 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1549) implement TODO in CharSequenceUtils.lastIndexOf : remake it.

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1549?focusedWorklogId=439583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439583 ] ASF GitHub Bot logged work on LANG-1549: Author: ASF GitHub Bot

[GitHub] [commons-lang] XenoAmess commented on pull request #535: [LANG-1549] implement TODO in CharSequenceUtils.lastIndexOf : remake it.

2020-06-01 Thread GitBox
XenoAmess commented on pull request #535: URL: https://github.com/apache/commons-lang/pull/535#issuecomment-636958642 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means the same functin in in

[jira] [Commented] (CODEC-280) Base32/64 to allow optional strict/lenient decoding

2020-06-01 Thread Valery Tydykov (Jira)
[ https://issues.apache.org/jira/browse/CODEC-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121119#comment-17121119 ] Valery Tydykov commented on CODEC-280: -- When version 1.15 will be released? > Base32

[jira] [Created] (IO-670) IOUtils.contentEquals is of low performance. I will refine it.

2020-06-01 Thread JIN XU (Jira)
JIN XU created IO-670: - Summary: IOUtils.contentEquals is of low performance. I will refine it. Key: IO-670 URL: https://issues.apache.org/jira/browse/IO-670 Project: Commons IO Issue Type: Improvement

[jira] [Work logged] (LANG-1542) ToStringBuilder.reflectionToString - Wrong JSON format when object has a List of Enum

2020-06-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1542?focusedWorklogId=439545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439545 ] ASF GitHub Bot logged work on LANG-1542: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #530: LANG-1542: ToStringBuilder.reflectionToString - Wrong JSON format for List

2020-06-01 Thread GitBox
coveralls edited a comment on pull request #530: URL: https://github.com/apache/commons-lang/pull/530#issuecomment-629603951 [![Coverage Status](https://coveralls.io/builds/31160874/badge)](https://coveralls.io/builds/31160874) Coverage increased (+0.001%) to 95.042% when pulling

  1   2   >