[GitHub] [commons-io] arturobernalg commented on pull request #221: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

2021-05-23 Thread GitBox
arturobernalg commented on pull request #221: URL: https://github.com/apache/commons-io/pull/221#issuecomment-846767758 > Files.newInputstream() to new FileInputStream() HI @jochenw This is the reason --> 'Basically, FileInputStream and FileOutputStream both use a finalizer

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #107: Bump maven-javadoc-plugin from 3.2.0 to 3.3.0

2021-05-23 Thread GitBox
dependabot[bot] opened a new pull request #107: URL: https://github.com/apache/commons-dbcp/pull/107 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.2.0 to 3.3.0. Commits

[GitHub] [commons-parent] dependabot[bot] opened a new pull request #43: Bump maven-javadoc-plugin from 3.2.0 to 3.3.0

2021-05-23 Thread GitBox
dependabot[bot] opened a new pull request #43: URL: https://github.com/apache/commons-parent/pull/43 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.2.0 to 3.3.0. Commits

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #199: Assorted typos

2021-05-23 Thread GitBox
PeterAlfredLee commented on pull request #199: URL: https://github.com/apache/commons-compress/pull/199#issuecomment-846678348 Hi @HelderMagalhaes Thank you for your contribution. I'm a little confused about your PR #197, #198 and #199. They look pretty similar. What's the

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #198: Site nits

2021-05-23 Thread GitBox
PeterAlfredLee commented on pull request #198: URL: https://github.com/apache/commons-compress/pull/198#issuecomment-846676635 Hi @HelderMagalhaes > A changeset from PR 197 was included by mistake. Do you mean that there are commits included by mistake in #197 ? If so, you

[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable

2021-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=600993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600993 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #168: COMPRESS-566 allow gzip buffer size to be configured

2021-05-23 Thread GitBox
PeterAlfredLee commented on pull request #168: URL: https://github.com/apache/commons-compress/pull/168#issuecomment-846674351 This looks good to me. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MATH-1536) Sensitivity to RNG (unit tests)

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350195#comment-17350195 ] Gilles Sadowski commented on MATH-1536: --- bq. solving it with javadoc Will do that. Thanks. >

[jira] [Comment Edited] (MATH-1536) Sensitivity to RNG (unit tests)

2021-05-23 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350186#comment-17350186 ] Alex Herbert edited comment on MATH-1536 at 5/23/21, 11:39 PM: --- With 

[jira] [Commented] (MATH-1536) Sensitivity to RNG (unit tests)

2021-05-23 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350186#comment-17350186 ] Alex Herbert commented on MATH-1536: With MATH-1533 (the sensitivity of discrete sampling an

[jira] [Created] (GEOMETRY-124) Use Precision.DoubleEquivalence

2021-05-23 Thread Matt Juntunen (Jira)
Matt Juntunen created GEOMETRY-124: -- Summary: Use Precision.DoubleEquivalence Key: GEOMETRY-124 URL: https://issues.apache.org/jira/browse/GEOMETRY-124 Project: Apache Commons Geometry

[jira] [Commented] (MATH-1576) Reinstate "checkstyle"

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350152#comment-17350152 ] Gilles Sadowski commented on MATH-1576: --- bq. update the code to match Numbers, or relax checkstyle

[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum of U1 and U2

2021-05-23 Thread Amar Prakash Pandey (Jira)
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350151#comment-17350151 ] Amar Prakash Pandey commented on MATH-1453: --- Thank you for explaining me, I will open a PR soon.

[jira] [Commented] (MATH-1533) EnumeratedDistribution.sample() depends on ordering of input even if RNG is given

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350146#comment-17350146 ] Gilles Sadowski commented on MATH-1533: --- bq. (item, probability) pairs in a different order leads to

[jira] [Commented] (MATH-1536) Sensitivity to RNG (unit tests)

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350144#comment-17350144 ] Gilles Sadowski commented on MATH-1536: --- Do you confirm that MATH-1533 is actually not a problem? >

[jira] [Reopened] (MATH-1533) EnumeratedDistribution.sample() depends on ordering of input even if RNG is given

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski reopened MATH-1533: --- On further thought, it is expected that providing the (item, probability) pairs in a different

[jira] [Commented] (MATH-1576) Reinstate "checkstyle"

2021-05-23 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350135#comment-17350135 ] Alex Herbert commented on MATH-1576: I created the stricter checkstyle rules for Numbers and RNG. IIRC

[jira] [Commented] (MATH-1576) Reinstate "checkstyle"

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350131#comment-17350131 ] Gilles Sadowski commented on MATH-1576: --- Unless I'm mistaken, the issue is one of "translating" the

[jira] [Commented] (MATH-1576) Reinstate "checkstyle"

2021-05-23 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350123#comment-17350123 ] Bruno P. Kinoshita commented on MATH-1576: -- I was expecting some errors. But 31000 is a new

[GitHub] [commons-compress] coveralls commented on pull request #199: Assorted typos

2021-05-23 Thread GitBox
coveralls commented on pull request #199: URL: https://github.com/apache/commons-compress/pull/199#issuecomment-846601982 [![Coverage Status](https://coveralls.io/builds/39929517/badge)](https://coveralls.io/builds/39929517) Coverage remained the same at 86.784% when pulling

[GitHub] [commons-compress] HelderMagalhaes opened a new pull request #199: Assorted typos

2021-05-23 Thread GitBox
HelderMagalhaes opened a new pull request #199: URL: https://github.com/apache/commons-compress/pull/199 Same issue as with PR 198: previous changesets were included by mistake. Only changeset 6db26b0 and ones that follow were expected! If that PR is approved before this one, it becomes

[GitHub] [commons-compress] coveralls edited a comment on pull request #197: Whitespace improvement

2021-05-23 Thread GitBox
coveralls edited a comment on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846548098 [![Coverage Status](https://coveralls.io/builds/39929369/badge)](https://coveralls.io/builds/39929369) Coverage remained the same at 86.784% when

[GitHub] [commons-compress] HelderMagalhaes commented on pull request #198: Site nits

2021-05-23 Thread GitBox
HelderMagalhaes commented on pull request #198: URL: https://github.com/apache/commons-compress/pull/198#issuecomment-846595416 A changeset from PR 197 was included by mistake. If that PR is approved before this one, it becomes irrelevant (and would be my first suggestion, in order to

[GitHub] [commons-compress] coveralls edited a comment on pull request #197: Whitespace improvement

2021-05-23 Thread GitBox
coveralls edited a comment on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846548098 [![Coverage Status](https://coveralls.io/builds/39928713/badge)](https://coveralls.io/builds/39928713) Coverage increased (+0.1%) to 86.784% when

[GitHub] [commons-fileupload] arturobernalg opened a new pull request #93: feature/solve checkstyle

2021-05-23 Thread GitBox
arturobernalg opened a new pull request #93: URL: https://github.com/apache/commons-fileupload/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [commons-fileupload] coveralls commented on pull request #92: Checkstyle plugging Enhance

2021-05-23 Thread GitBox
coveralls commented on pull request #92: URL: https://github.com/apache/commons-fileupload/pull/92#issuecomment-846561466 [![Coverage Status](https://coveralls.io/builds/39927785/badge)](https://coveralls.io/builds/39927785) Coverage remained the same at 78.278% when pulling

[GitHub] [commons-compress] coveralls commented on pull request #198: Site nits

2021-05-23 Thread GitBox
coveralls commented on pull request #198: URL: https://github.com/apache/commons-compress/pull/198#issuecomment-846561157 [![Coverage Status](https://coveralls.io/builds/39927757/badge)](https://coveralls.io/builds/39927757) Coverage remained the same at 86.654% when pulling

[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum of U1 and U2

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350037#comment-17350037 ] Gilles Sadowski commented on MATH-1453: --- bq. [...] from the `master` branch No; for now, PRs should

[jira] [Closed] (COMPRESS-576) Minor improvements :

2021-05-23 Thread Arturo Bernal (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal closed COMPRESS-576. -- Resolution: Fixed In master TY > Minor improvements : > > >

[GitHub] [commons-fileupload] arturobernalg opened a new pull request #92: Remove AvoidInlineConditionals rule.

2021-05-23 Thread GitBox
arturobernalg opened a new pull request #92: URL: https://github.com/apache/commons-fileupload/pull/92 - Remove checkstyle license validations in favor of rat plugin. - Add defaultGoal checkstyle validations. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-compress] coveralls edited a comment on pull request #197: Whitespace improvement

2021-05-23 Thread GitBox
coveralls edited a comment on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846548098 [![Coverage Status](https://coveralls.io/builds/39927676/badge)](https://coveralls.io/builds/39927676) Coverage remained the same at 86.654% when

[GitHub] [commons-compress] HelderMagalhaes opened a new pull request #198: Site nits

2021-05-23 Thread GitBox
HelderMagalhaes opened a new pull request #198: URL: https://github.com/apache/commons-compress/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum of U1 and U2

2021-05-23 Thread Amar Prakash Pandey (Jira)
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350024#comment-17350024 ] Amar Prakash Pandey commented on MATH-1453: --- If I understood it clearly, I have to create a `bug

[GitHub] [commons-compress] coveralls commented on pull request #197: Whitespace improvement

2021-05-23 Thread GitBox
coveralls commented on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846548098 [![Coverage Status](https://coveralls.io/builds/39927187/badge)](https://coveralls.io/builds/39927187) Coverage remained the same at 86.654% when pulling

[GitHub] [commons-compress] HelderMagalhaes opened a new pull request #197: Whitespace improvement

2021-05-23 Thread GitBox
HelderMagalhaes opened a new pull request #197: URL: https://github.com/apache/commons-compress/pull/197 tabs to spaces; reduce padding (1 space on the longest member) for consistency with other structures. _The tabs vs. spaces mix does lead to unexpected visual formatting (only OK

[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum of U1 and U2

2021-05-23 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350015#comment-17350015 ] Gilles Sadowski commented on MATH-1453: --- You are welcome to fix as many bugs as you want. ;) Please

[jira] [Commented] (MATH-1453) Mann-Whitney U Test returns maximum of U1 and U2

2021-05-23 Thread Amar Prakash Pandey (Jira)
[ https://issues.apache.org/jira/browse/MATH-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349960#comment-17349960 ] Amar Prakash Pandey commented on MATH-1453: --- [~erans], Can I take this issue? > Mann-Whitney U

[GitHub] [commons-io] jochenw commented on pull request #221: Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.

2021-05-23 Thread GitBox
jochenw commented on pull request #221: URL: https://github.com/apache/commons-io/pull/221#issuecomment-846531377 I am unsure about this one. First of all, it changes way too many files, in my opinion. Then, I see no real benefit, when comparing Files.newInputstream() to new