[GitHub] [commons-io] SwingGuy1024 opened a new pull request, #450: IO-790 symbolic link file filter test incomplete, needs to handle windows issues

2023-04-18 Thread via GitHub
SwingGuy1024 opened a new pull request, #450: URL: https://github.com/apache/commons-io/pull/450 This should be pulled after IO-789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Updated] (IO-790) SymbolicLinkFileFilterTest Incomplete, needs to handle Windows issues

2023-04-18 Thread Miguel Munoz (Jira)
[ https://issues.apache.org/jira/browse/IO-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miguel Munoz updated IO-790: Summary: SymbolicLinkFileFilterTest Incomplete, needs to handle Windows issues (was: SymbolicLinkFileFilter In

[GitHub] [commons-io] SwingGuy1024 opened a new pull request, #449: IO-789 Symbolic link file filter accepts all files, not just symbolic links

2023-04-18 Thread via GitHub
SwingGuy1024 opened a new pull request, #449: URL: https://github.com/apache/commons-io/pull/449 This change fixed the filters, but also restructures the code slightly to facilitate Unit Testing on all platforms. (This is a challenge for this particular class. -- This is an automated mes

[GitHub] [commons-io] garydgregory commented on pull request #447: Add blocking read mode to QueueInputStream.

2023-04-18 Thread via GitHub
garydgregory commented on PR #447: URL: https://github.com/apache/commons-io/pull/447#issuecomment-1514015259 > > @maxxedev See git master where I took a different approach. [...] > > Thanks. I will look into improving the tests You can rebase this PR, or close it and create a n

[jira] [Commented] (IO-678) FileUtils.copyFile does not maintain file permissions

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713781#comment-17713781 ] Gary D. Gregory commented on IO-678: Merged [https://github.com/apache/commons-io/pull/37

[jira] [Comment Edited] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713779#comment-17713779 ] Gary D. Gregory edited comment on IO-663 at 4/18/23 9:52 PM: - Mer

[jira] [Commented] (IO-575) copyDirectory (all overloads) does not maintain file permissions

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713782#comment-17713782 ] Gary D. Gregory commented on IO-575: Merged [https://github.com/apache/commons-io/pull/37

[jira] [Resolved] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-663. Fix Version/s: 2.12.0 Resolution: Fixed Merged [https://github.com/apache/commons-io/pull/377, s

[jira] [Comment Edited] (IO-769) FileUtils.copyFileToDirectory can lead to not accessible file when preserving the file date

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713778#comment-17713778 ] Gary D. Gregory edited comment on IO-769 at 4/18/23 9:51 PM: - Mer

[jira] [Updated] (IO-575) copyDirectory (all overloads) does not maintain file permissions

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated IO-575: --- Fix Version/s: 2.12.0 Environment: Merged [https://github.com/apache/commons-io/pull/377, see the P

[jira] [Updated] (IO-678) FileUtils.copyFile does not maintain file permissions

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated IO-678: --- Fix Version/s: 2.12.0 Environment: Merged [https://github.com/apache/commons-io/pull/377, see the P

[jira] [Comment Edited] (IO-769) FileUtils.copyFileToDirectory can lead to not accessible file when preserving the file date

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713778#comment-17713778 ] Gary D. Gregory edited comment on IO-769 at 4/18/23 9:50 PM: - Mer

[jira] [Comment Edited] (IO-769) FileUtils.copyFileToDirectory can lead to not accessible file when preserving the file date

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713778#comment-17713778 ] Gary D. Gregory edited comment on IO-769 at 4/18/23 9:50 PM: - Mer

[jira] [Resolved] (IO-769) FileUtils.copyFileToDirectory can lead to not accessible file when preserving the file date

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-769. Fix Version/s: 2.12.0 Resolution: Fixed Merged https://github.com/apache/commons-io/pull/377 >

[GitHub] [commons-io] garydgregory merged pull request #377: [IO-769] FileUtils copyDirectory() should NOT use COPY_ATTRIBUTES

2023-04-18 Thread via GitHub
garydgregory merged PR #377: URL: https://github.com/apache/commons-io/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

[GitHub] [commons-io] garydgregory commented on pull request #377: [IO-769] FileUtils copyDirectory() should NOT use COPY_ATTRIBUTES

2023-04-18 Thread via GitHub
garydgregory commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1513623294 The consensus, reading this PR and the ticket, is to revert the behavior, so I will merge this PR. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [commons-io] garydgregory commented on pull request #377: [IO-769] FileUtils copyDirectory() should NOT use COPY_ATTRIBUTES

2023-04-18 Thread via GitHub
garydgregory commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1513619421 > Why did the previous setLastModified(File, File) need PathUtils.setLastModifiedTime() if > sourceFile.isFile() was true, but needed setLastModifiedTime(File, long) if sourceFil

[GitHub] [commons-lang] garydgregory merged pull request #965: Remove unnecessary conditions. It's no need it after assigns tmp to duration

2023-04-18 Thread via GitHub
garydgregory merged PR #965: URL: https://github.com/apache/commons-lang/pull/965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

[jira] [Commented] (IO-789) SymbolicLinkFileFilter accepts all files, not just symbolic links

2023-04-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713536#comment-17713536 ] Gary D. Gregory commented on IO-789: Hi [~swingguy1...@yahoo.com]  The best way to move

[jira] [Commented] (IO-790) SymbolicLinkFileFilter Incomplete, needs to handle Windows issues

2023-04-18 Thread Miguel Munoz (Jira)
[ https://issues.apache.org/jira/browse/IO-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713470#comment-17713470 ] Miguel Munoz commented on IO-790: - Patch submitted to developer's email list > SymbolicLinkF

[jira] [Commented] (IO-789) SymbolicLinkFileFilter accepts all files, not just symbolic links

2023-04-18 Thread Miguel Munoz (Jira)
[ https://issues.apache.org/jira/browse/IO-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713471#comment-17713471 ] Miguel Munoz commented on IO-789: - Patch submitted to developer's email list > SymbolicLinkF

[jira] [Created] (IO-790) SymbolicLinkFileFilter Incomplete, needs to handle Windows issues

2023-04-18 Thread Miguel Munoz (Jira)
Miguel Munoz created IO-790: --- Summary: SymbolicLinkFileFilter Incomplete, needs to handle Windows issues Key: IO-790 URL: https://issues.apache.org/jira/browse/IO-790 Project: Commons IO Issue Typ