Re: [PR] Optimize the nameMap of ZipFile [commons-compress]

2023-12-31 Thread via GitHub
kvr000 commented on code in PR #378: URL: https://github.com/apache/commons-compress/pull/378#discussion_r1438946469 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -368,9 +369,14 @@ public static void closeQuietly(final ZipFile zipFile) {

Re: [PR] Optimize the nameMap of ZipFile [commons-compress]

2023-12-31 Thread via GitHub
kvr000 commented on code in PR #378: URL: https://github.com/apache/commons-compress/pull/378#discussion_r1438946469 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -368,9 +369,14 @@ public static void closeQuietly(final ZipFile zipFile) {

[jira] [Updated] (IO-834) AbstractOrigin getReader/getWriter etc, should be abstract

2023-12-31 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated IO-834: - Description: Many methods in this base class have no useful default implementation. E.g.

[jira] [Commented] (IO-574) Add Writes of Primitive Values To OutputStream

2023-12-31 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801472#comment-17801472 ] Gary D. Gregory commented on IO-574: Answering my question from above: Possibly in

[jira] [Commented] (IO-574) Add Writes of Primitive Values To OutputStream

2023-12-31 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801470#comment-17801470 ] Elliotte Rusty Harold commented on IO-574: -- This is what DataOutputStream is for, as well as Guava's

Re: [PR] Uncomment and update null tests for FileUtils.toURLs(File...) [commons-io]

2023-12-31 Thread via GitHub
garydgregory merged PR #546: URL: https://github.com/apache/commons-io/pull/546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Reduce noise in FileUtilsTest [commons-io]

2023-12-31 Thread via GitHub
garydgregory merged PR #545: URL: https://github.com/apache/commons-io/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (IO-807) FileUtils.requireExists does not take into account soft links

2023-12-31 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801441#comment-17801441 ] Elliotte Rusty Harold commented on IO-807: -- Can you describe this bug in terms of the public API

[jira] [Created] (IO-835) FileOrigin == PathOrigin

2023-12-31 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created IO-835: Summary: FileOrigin == PathOrigin Key: IO-835 URL: https://issues.apache.org/jira/browse/IO-835 Project: Commons IO Issue Type: Improvement

[jira] [Created] (IO-834) AbstractOrigin getReader/getWriter etc, should be abstract

2023-12-31 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created IO-834: Summary: AbstractOrigin getReader/getWriter etc, should be abstract Key: IO-834 URL: https://issues.apache.org/jira/browse/IO-834 Project: Commons IO

[jira] [Created] (IO-833) Every origin needs a charset

2023-12-31 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created IO-833: Summary: Every origin needs a charset Key: IO-833 URL: https://issues.apache.org/jira/browse/IO-833 Project: Commons IO Issue Type: Bug

Re: [PR] Optimize the nameMap of ZipFile [commons-compress]

2023-12-31 Thread via GitHub
garydgregory commented on code in PR #378: URL: https://github.com/apache/commons-compress/pull/378#discussion_r1438855379 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -368,9 +369,14 @@ public static void closeQuietly(final ZipFile zipFile) {

Re: [PR] Optimize the nameMap of ZipFile [commons-compress]

2023-12-31 Thread via GitHub
garydgregory commented on code in PR #378: URL: https://github.com/apache/commons-compress/pull/378#discussion_r1438855379 ## src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java: ## @@ -368,9 +369,14 @@ public static void closeQuietly(final ZipFile zipFile) {