Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/262
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/commit/dfecbe970917754511a081f8b86efac211e624f6#commitcomment-21808707
nice refactorings :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
Concerning the coverage: I think it's because the coverage differs between
java versions. The build used to determine coverage depends on the order in
which the travis builds finish
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/231
Merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
Well we have to keep `getMethodsWithAnnotation(cls, annotationCls)` for
compatibility reasons. In my opinion it is not problem if is equal to
`getMethodsWithAnnotation(cls
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
You are right. The method signature I suggested omits the important super
part. I agree it should be something like `getMethodsWithAnnotation(Class cls,
annotationCls, boolean
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/231
@sebbASF What do you think about the latest changes? Is this pull request
ready for merging?
Thanks, Pascal
---
If your project is set up for it, you can reply to this email
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
Thanks for the pull request!
It is really unfortunate that the existing method
`getMethodsWithAnnotation` is not called `getAccessibleMethodsWithAnnotation` :
(, because
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/260
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/253
Hi @esend7881
thanks for the pull request.
I'm not sure it is a good idea to add at method that is nearly identical to
`StopWatch#createStarted`.
---
If your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/256
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/257
Required changes seem reasonable. I think we should give this a try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/256#discussion_r106023700
--- Diff:
src/test/java/org/apache/commons/lang3/reflect/MethodUtilsTest.java ---
@@ -357,16 +369,23 @@ public void testInvokeMethod() throws
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/256
@drajakumar It's really great to get a pull request for this. :+1:
I took a look at this issue some time ago, but gave up trying to solve it.
Sadly I'm too tired
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/254
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/255
LANG-1316: Deprecate classes/methods moved to commons-text
* org.apache.commons.lang3.text.translate - every class
* org.apache.commons.lang3.text - every class beside WordUtils
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/254
I think that is normal lately. Seems like a lot of apache projects enabled
travis recently and now apaches travis-ci capacity can not handle the load.
Sometimes it takes a day until
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/252
@mureinik Sorry it wasn't my intention to steal the authorship of your
commits with the javadoc fixes. :( I wasn't aware that a `git rebase` changes
the author.
---
If your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/252
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/249
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/248
+1 to adding the check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/248
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/246
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/245
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/245
For time to time there are discussion concerning the use of the for-each
loop on the mailing list. (e.g.
http://markmail.org/thread/wmedbgqmewmpiptk#query:+page:1+mid:gbo5cpywwfxl5p4w
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/244
LANG-1265: Build failures when building with Java 9 EA
Fix build on Java 9 Build 157 by adding a java-9 maven profile. This is
activated by default on Java 9 and opens up java.base
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/243
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/241
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/242
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/182
As far as I can tell @C0rWin updated the pull request 9 days ago (after
your conversation).
By the way merging this only makes sense if commons lang actually uses JHM.
Do you
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/182
I guess this is ready to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/240
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/240#discussion_r102281919
--- Diff: src/test/java/org/apache/commons/lang3/EnumUtilsTest.java ---
@@ -418,10 +418,10 @@ public void test_processBitVectors_longClass
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/231
jira issue: https://issues.apache.org/jira/browse/LANG-1313
I plan to merge this tomorrow (if there are no objections).
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/238
Yes, lets keep the pull requests as is is. Sorry if I caused the impression
of being overtly critical of this change.
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/238
Yes, currently the user has to escape single `%`s in the error message with
`%%`.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/239
@kinow: Thanks for the review. :-)
I also did not know about UN M.49 till yesterday. I just stumbled over this
while analyzing commons-lang test failures on java 9 for
https
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/239
LANG-1312: LocaleUtils#toLocale does not support language followed byâ¦
⦠UN M.49 numeric-3 area code
You can merge this pull request into a Git repository by running:
$ git
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/238
Thanks for the pull request (and you other pull requests).
This pull request actually slightly changes the behavior of the methods.
There is at least one use
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/235
Thanks! ð
I restored the casts in `ArrayUtils#testGetLength` before merging, because
otherwise these tests make no sense. (The test probably make no sense anyway,
as you
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/231
I think this is a worthy addition.
In my experience people often do not read documentation. Maybe we should
use `IS_32_BIT_JVM` so there can be no confusion? Or is this is too
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
@martin-tarjanyi Sorry for the delay. :( I finally send a mail to the
mailing list:
https://mail-archives.apache.org/mod_mbox/commons-dev/201702.mbox/%3C13256228-1650-e98e
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/231
The discussion mentioned by @kinow is here:
https://issues.apache.org/jira/browse/LANG-1145
---
If your project is set up for it, you can reply to this email and have your
reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/233
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/232
Thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/230
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/229
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/226
Thanks for the pull request. ð
StringEscapeUtils has been moved to commons-text and the commons-lang
version will soon be deprecated.
It would be nice if you
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
On further consideration, there are already methods with are "simply the
inverse of another method": `isEmpty/isNotEmpty`, `isAnyEmpty/isNoneEmpty`,
`containsAny/contai
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/224
There is also `StringUtils.defaultString(final String str)` which has
exactly the same functionality.
---
If your project is set up for it, you can reply to this email and have your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/224
Thanks for the pull request! :)
The same behavior can be achieved with `ObjectUtils.defaultIfNull(str,
"")`, but of course this new method reads much better, so I'
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/222
Thanks Sampanna!
It would be nice if you would close this pull request. (I can not do it
easily as this is a read-only repository.)
Thanks!
---
If your project
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/222
Thanks for the pull request. ð
StringEscapeUtils was ported to commons-text and will soon deprecated in
commons-lang.
It would be nice if you could open a pull
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
If only one method is added it should be `isAll*` instead of `isAnyNot*`.
Since the `isAnyNot*` are not released yet, they can be removed.
I personally would have no problem
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
I have created an jira issue for this:
https://issues.apache.org/jira/browse/LANG-1293 and also asked for opinions on
the empty/null array question there.
---
If your project is set
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
>I vote strongly for is* method naming. That's the convention for Java
methods of this type, even if it slightly upsets the English ear.
Then let's keep is* na
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/221
Thanks for the pull request. :)
I guess we better class theses methods `areAllEmpty`/`areAllBlank`. What do
you think?
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/220
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/208
As discussed on the mailing list string escaping will move to commons-text,
so I'm closing this pull request.
---
If your project is set up for it, you can reply to this email
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/213
As discussed on the mailing list string escaping will move to commons-text,
so I'm closing this pull request.
---
If your project is set up for it, you can reply to this email
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
No problem. :)
When I started contributing to Open Source and using git and github I also
had a lot of questions.
---
If your project is set up for it, you can reply
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
It's the same for the other commit, see:
https://github.com/apache/commons-lang/commits/master
---
If your project is set up for it, you can reply to this email and have your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
Yes, the changes have been merged: 51b2cab
I think the commit is marked as unmerged, because I changed the commit
message. But you are still listed as the author, so I guess
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/218
Thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
Thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
Great find! ð Thanks for the detailed explanation. :)
As this change is unrelated to improving the test coverage of ArrayUtils,
it would be nice if you could move
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/217
Thanks for the pull request! ð
>fix an issue with not getting Annotation in AnnotaionUtilsTest
Not sure what you fixed there. What is the reason of this cha
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/215
Thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/210
https://github.com/apache/commons-lang/commit/011775551ef75d75f81189eb4604fd0f2ed424ba
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-lang/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/213#discussion_r88803456
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -429,6 +429,65 @@ public StringEscapeUtils() {
super
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88799517
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -413,6 +447,47 @@ public int translate(final CharSequence input
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/208#discussion_r88799453
--- Diff: src/main/java/org/apache/commons/lang3/StringEscapeUtils.java ---
@@ -272,6 +272,40 @@ public int translate(final CharSequence input
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/213
LANG-1288: Add a builder to StringEscapeUtils
patch supplied by Mark (for LANG-1066)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/211
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/212
Thanks! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/211
related issue: https://issues.apache.org/jira/browse/LANG-806
I guess this pull request fixes the most important part of the issue.
---
If your project is set up for it, you
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/211
Thanks for the pull request. :)
Please do not mix formatting/white-space changes with functional changes in
commit.
---
If your project is set up for it, you can reply
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/207
LANG-1274: StrSubstitutor should state its thread safety
Add paragraph to class javadoc stating that StrSubstitutor is not thread
safe.
You can merge this pull request into a Git
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/199
I have updated the pull request with @Xaerxess changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/203
Memomizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang memomizer
Alternatively you can review
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/commit/e4c72a5522aabfa6a660088aa9262d849756e464#commitcomment-19532086
In src/changes/changes.xml:
In src/changes/changes.xml on line 48:
pretty optimistic ;) :)
---
If your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/202
I haven't locked at this in-depth yet, but seems like a useful enhancement.
I would remove the support for including transient fields, because that
seems like a bad practice
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/202
LANG-1034: Recursive and reflective EqualsBuilder
patch by yathos UG
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/201
LANG-1143: StringUtils should use toXxxxCase(int) rather than toXxxxCâ¦
â¦ase(char)
based on patch by Sebb
You can merge this pull request into a Git repository by running
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/200
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/141
@Derek-Ashmore Just today I learned that the resetting of the original
accessibility of the method I asked you to add is not necessary, because
`Method#setAccessible` only modifies
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/199
LANG-1258: Add ArrayUtils#toStringArray(Object[]) method
patch supplied by IG
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/198
LANG-1269: Wrong name or result of StringUtils#getJaroWinklerDistance
deprecat StringUtils#getJaroWinklerDistance and add
StringUtils#getJaroWinklerSimilarity instead
You can merge
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/189
@yufcuy: Thanks for the pull request. :+1:
@kinow: Thanks for the review. I have added the link and replaced tabs with
spaces after merging. Feel free to change/improve
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/195
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/193
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/194
Thanks for the pull request.
The method body can be shortened to `StringUtils.isBlank(cs) ||
StringUtils.equalsIgnoreCase(cs, "null")`.
The method wou
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/189
@kinow I think this has to stay in lang. At least until lang 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/39
Closed because of unresolved merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/193
I agree with both of you.
An empty array does not contain any non-empty/non-blank `CharSequence`s, so
`isAnyNotEmpty`/`isAnyNotBlank` should return `false` for an empty array
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/commit/e6ad17215d27b66b7fe43931247fc3470d8dee18#commitcomment-19077493
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/184
the non-breaking space replacement was added with
https://issues.apache.org/jira/browse/LANG-910
---
If your project is set up for it, you can reply to this email and have your
reply
101 - 200 of 331 matches
Mail list logo
