[GitHub] commons-lang issue #271: LANG-1340: Add ibmjdk8 support for travis-ci

2017-09-08 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/271 No need of this since we will be following travis for its simplicity ---

[GitHub] commons-lang pull request #271: LANG-1340: Add ibmjdk8 support for travis-ci

2017-09-08 Thread ameyjadiye
Github user ameyjadiye closed the pull request at: https://github.com/apache/commons-lang/pull/271 ---

[GitHub] commons-lang issue #279: Fraction debug printings

2017-07-22 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/279 debugging can be much effectively done with IDE, adding these kind of console output is discouraged. I would recommend to use logging _logger.debug()_, but that's not the guidelines

[GitHub] commons-lang pull request #277: run maven defaultGoal from Travis

2017-07-14 Thread ameyjadiye
Github user ameyjadiye closed the pull request at: https://github.com/apache/commons-lang/pull/277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang issue #277: run maven defaultGoal from Travis

2017-07-14 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/277 @garydgregory , I think this ia good chahe to accept . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request #277: run maven defaultGoal from Travis

2017-07-11 Thread ameyjadiye
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-lang/pull/277 run maven defaultGoal from Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-lang travis-fix Alternatively

[GitHub] commons-lang pull request #:

2017-07-11 Thread ameyjadiye
Github user ameyjadiye commented on the pull request: https://github.com/apache/commons-lang/commit/5f0d8127579c1ce73f21daa509271c14af78b143#commitcomment-23034235 I think now Travis should only have ```mvn``` and nothing else :) --- If your project is set up for it, you can reply

[GitHub] commons-lang issue #272: Replaced test with verify

2017-06-25 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/272 Merged, thanks @garydgregory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] commons-lang pull request #272: Replaced test with verify

2017-06-25 Thread ameyjadiye
Github user ameyjadiye closed the pull request at: https://github.com/apache/commons-lang/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang issue #272: Replaced test with verify

2017-06-23 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/272 I don't see any harm merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] commons-lang pull request #272: Replaced test with verify

2017-06-12 Thread ameyjadiye
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-lang/pull/272 Replaced test with verify You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-lang mvn-test-verify Alternatively you

[GitHub] commons-lang issue #268: .travis.yml: add oraclejdk9

2017-06-12 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/268 Hmm, how about using docker service for this ? , I have raised same for ibmjdk8 https://github.com/apache/commons-lang/pull/271 --- If your project is set up for it, you can reply

[GitHub] commons-lang pull request #271: LANG-1340: Added ibmjdk8 support for travis-...

2017-06-12 Thread ameyjadiye
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-lang/pull/271 LANG-1340: Added ibmjdk8 support for travis-ci Addition of the ibmjdk8 to Commons Text is successful, so adding it to Commons Lang would be an advantage. You can merge this pull request

[GitHub] commons-lang issue #268: .travis.yml: add oraclejdk9

2017-06-12 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-lang/pull/268 As per Travis-ci documentation doesnt seems they support oraclejdk9 https://docs.travis-ci.com/user/languages/java/ >The Travis CI environment provides Oracle JD