[GitHub] commons-lang pull request #357: Proposal for LANG-1421

2018-09-21 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/357#discussion_r219537218 --- Diff: src/main/java/org/apache/commons/lang3/ObjectUtils.java --- @@ -236,6 +236,39 @@ public static boolean anyNotNull(final Object

[GitHub] commons-lang pull request #357: Proposal for LANG-1421

2018-09-21 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/357#discussion_r219536392 --- Diff: src/main/java/org/apache/commons/lang3/ObjectUtils.java --- @@ -236,6 +236,39 @@ public static boolean anyNotNull(final Object

[GitHub] commons-lang pull request #269: LANG-1337: Fix test failures in IBM JDK 8 fo...

2017-06-06 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/269#discussion_r120386094 --- Diff: src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java --- @@ -316,7 +316,7 @@ public void

[GitHub] commons-lang issue #269: LANG-1337: Fix test failures in IBM JDK 8 for ToStr...

2017-06-06 Thread andyklimczak
Github user andyklimczak commented on the issue: https://github.com/apache/commons-lang/pull/269 probably related to [this](https://stackoverflow.com/a/34250231)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang issue #223: [LANG-1304] StringUtils method to check for mixed c...

2017-05-23 Thread andyklimczak
Github user andyklimczak commented on the issue: https://github.com/apache/commons-lang/pull/223 hello friends, I've updated `isMixedCase()` to be much more accepting of special characters, numbers, and spaces. Please double check that my tests assert the strings correctly, and match

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

2017-05-22 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/223#discussion_r117889175 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -7193,6 +7193,45 @@ public static boolean isAllUpperCase(final

[GitHub] commons-lang pull request #228: Increase test coverage

2017-01-21 Thread andyklimczak
GitHub user andyklimczak opened a pull request: https://github.com/apache/commons-lang/pull/228 Increase test coverage CharRangeTest 98% -> 100% RandomUtilsTest 90% -> 100% StringEscapeUtilsTest 95% -> 100% StringUtilsTest -> 99% (a few more lines covered) Y

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

2016-12-29 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/223#discussion_r94203294 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -7193,6 +7193,45 @@ public static boolean isAllUpperCase(final

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

2016-12-29 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/223#discussion_r94201194 --- Diff: src/test/java/org/apache/commons/lang3/StringUtilsTest.java --- @@ -2563,6 +2563,24 @@ public void testIsAllUpperCase

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

2016-12-29 Thread andyklimczak
Github user andyklimczak commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/223#discussion_r94200421 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -7193,6 +7193,45 @@ public static boolean isAllUpperCase(final

[GitHub] commons-lang pull request #223: [LANG-1304] StringUtils method to check for ...

2016-12-29 Thread andyklimczak
GitHub user andyklimczak opened a pull request: https://github.com/apache/commons-lang/pull/223 [LANG-1304] StringUtils method to check for mixed case in string [jira link](https://issues.apache.org/jira/browse/LANG-1304) You can merge this pull request into a Git repository

[GitHub] commons-lang pull request #200: LANG-1276

2016-10-22 Thread andyklimczak
GitHub user andyklimczak opened a pull request: https://github.com/apache/commons-lang/pull/200 LANG-1276 Fix issue of buf using nonupdated buffer in StrBuilder replaceImpl Avoid array OoB error by keeping variable buf consistent with buffer You can merge this pull request